Skip to contentSkip to conversation

regulator: dummy, make dummy_regulator_driver static

PATCH In review Ben Dooks 2 participants 2 messages Jan 12 – Jan 13 Voltage and current regulator framework

lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 regulator: dummy, make dummy_regulator_driver static

When converting to faux_device the dummy_regulator_driver was made non-static however it isn't exported or defined anywhere outside the file it is in. Make it static to avoid the following sparse warning:

drivers/regulator/dummy.c:59:24: warning: symbol 'dummy_regulator_driver' was not declared. Should it be static?

Fixes dcd2a9a5550ef556c8 ("regulator: dummy: convert to use the faux device interface")
---
 drivers/regulator/dummy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/regulator/dummy.c +1 -1
index e5197ec7234d..c3e416fd3c3e 100644
@@ -56,7 +56,7 @@ static int dummy_regulator_probe(struct faux_device *fdev)
 	return 0;
 }
 
-struct faux_device_ops dummy_regulator_driver = {
+static struct faux_device_ops dummy_regulator_driver = {
 	.probe = dummy_regulator_probe,
 };
 
Signature · 1 line
2.37.2.352.g3c44437643
maintainer
#1 lore raw
Quoted 8 lines · Ben Dooks

When converting to faux_device the dummy_regulator_driver was made non-static however it isn't exported or defined anywhere outside the file it is in. Make it static to avoid the following sparse warning:

drivers/regulator/dummy.c:59:24: warning: symbol 'dummy_regulator_driver' was not declared. Should it be static?

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: dummy, make dummy_regulator_driver static

      commit: 09dc08b396c954820f119e1ab0c7d72333c18323

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark