Skip to contentSkip to conversation

mm/khugepaged: make khugepaged_collapse_control static

PATCH In review Ben Dooks 3 participants 3 messages Jan 12 – Jan 14

Subsystems (2)
lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

PATCH 1/1 mm/khugepaged: make khugepaged_collapse_control static

Make khugepaged_collapse_control as it is not exported. Fixes the following sparse warning:

mm/khugepaged.c:829:25: warning: symbol 'khugepaged_collapse_control' was not declared. Should it be static?

Fixes 34d6b470ab9cf ("mm/khugepaged: add struct collapse_control")
---
 mm/khugepaged.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/khugepaged.c +1 -1
index 97d1b2824386..c9bd0df632bd 100644
@@ -826,7 +826,7 @@ static void khugepaged_alloc_sleep(void)
 	remove_wait_queue(&khugepaged_wait, &wait);
 }
 
-struct collapse_control khugepaged_collapse_control = {
+static struct collapse_control khugepaged_collapse_control = {
 	.is_khugepaged = true,
 };
 
Signature · 1 line
2.37.2.352.g3c44437643
Reviewed-by on v1 1/1
#1 lore raw
Quoted 16 lines · Ben Dooks

Make khugepaged_collapse_control as it is not exported. Fixes the following sparse warning:

mm/khugepaged.c:829:25: warning: symbol 'khugepaged_collapse_control' was not declared. Should it be static?

Fixes 34d6b470ab9cf ("mm/khugepaged: add struct collapse_control")
---
 mm/khugepaged.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/khugepaged.c +0 -0
index 97d1b2824386..c9bd0df632bd 100644

mm/khugepaged.c static void khugepaged_alloc_sleep(void) · line 832

Quoted 8 lines
mm/khugepaged.c +1 -1
@@ -826,7 +826,7 @@ static void khugepaged_alloc_sleep(void)
 	remove_wait_queue(&khugepaged_wait, &wait);
 }
 
-struct collapse_control khugepaged_collapse_control = {
+static struct collapse_control khugepaged_collapse_control = {
 	.is_khugepaged = true,
 };
 
#2 lore raw

Andrew - just to avoid confusion - this patch should be ignored, is an accidentally sent duplicate and was already sent by a previous submitter see [0].

Cheers, Lorenzo

Quoted 20 lines · Anshuman Khandual
Quoted 19 lines · Ben Dooks

Make khugepaged_collapse_control as it is not exported. Fixes the following sparse warning:

mm/khugepaged.c:829:25: warning: symbol 'khugepaged_collapse_control' was not declared. Should it be static?

Fixes 34d6b470ab9cf ("mm/khugepaged: add struct collapse_control")
---
 mm/khugepaged.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/khugepaged.c +0 -0
index 97d1b2824386..c9bd0df632bd 100644
@@ -826,7 +826,7 @@ static void khugepaged_alloc_sleep(void)
 	remove_wait_queue(&khugepaged_wait, &wait);
 }
 
Quoted 7 lines

mm/khugepaged.c static void khugepaged_alloc_sleep(void) · line 832

Quoted 5 lines
mm/khugepaged.c +1 -1
-struct collapse_control khugepaged_collapse_control = {
+static struct collapse_control khugepaged_collapse_control = {
 	.is_khugepaged = true,
 };
 

[0]: https://lore.kernel.org/linux-mm/[email protected]/