Skip to contentSkip to conversation

staging: rtl8723bs: style cleanups in rtw_mlme.c

PATCH In review Lorenzo Simonelli 2 participants 3 messages Jan 12 Staging

lore
Share & tools
lore
#0 lore raw

v2 cover staging: rtl8723bs: style cleanups in rtw_mlme.c

This series contains style cleanups for the rtl8723bs driver. The changes focus on removing unnecessary comparisons and trailing whitespaces in rtw_mlme.c.

---
v2:
- Dropped the patch for sm750fb due to build regression.
- Consolidated remaining style cleanups into a single patch.
- Verified build with make M=drivers/staging/rtl8723bs/

Lorenzo Simonelli (1):
staging: rtl8723bs: style cleanups in rtw_mlme.c

 drivers/staging/rtl8723bs/core/rtw_mlme.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
Signature · 1 line
2.52.0
#1 lore raw

PATCH v2 1/1 staging: rtl8723bs: style cleanups in rtw_mlme.c

This patch performs style cleanups in rtw_mlme.c, specifically removing unnecessary boolean comparisons and trailing whitespaces. These changes improve adherence to the kernel coding style.

---
v2:
- Dropped the patch for sm750fb due to build regression.
- Consolidated remaining style cleanups into this single patch.
- Verified build for rtl8723bs/core/rtw_mlme.o

 drivers/staging/rtl8723bs/core/rtw_mlme.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/staging/rtl8723bs/core/rtw_mlme.c +7 -7
index 98704179a..d9e6778e1 100644
@@ -468,11 +468,11 @@ static void update_current_network(struct adapter *adapter, struct wlan_bssid_ex
 		 &pmlmepriv->cur_network.network,
 		 &pmlmepriv->cur_network.network,
 		 &pmlmepriv->cur_network.network);
-
-	if ((check_fwstate(pmlmepriv, _FW_LINKED) == true) && (is_same_network(&pmlmepriv->cur_network.network, pnetwork, 0))) {
+	if ((check_fwstate(pmlmepriv, _FW_LINKED) == true) &&
+	    (is_same_network(&pmlmepriv->cur_network.network, pnetwork, 0))) {
 		 update_network(&pmlmepriv->cur_network.network, pnetwork, adapter, true);
 		 rtw_update_protection(adapter, (pmlmepriv->cur_network.network.ies) + sizeof(struct ndis_802_11_fix_ie),
-				       pmlmepriv->cur_network.network.ie_length);
+				 pmlmepriv->cur_network.network.ie_length);
 	 }
 }
 
@@ -710,7 +710,7 @@ void rtw_surveydone_event_callback(struct adapter    *adapter, u8 *pbuf)
 	 rtw_set_signal_stat_timer(&adapter->recvpriv);
 
 	 if (pmlmepriv->to_join) {
-		if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true)) {
+		if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) {
 			 if (check_fwstate(pmlmepriv, _FW_LINKED) == false) {
 				 set_fwstate(pmlmepriv, _FW_UNDER_LINKING);
 
@@ -1386,8 +1386,8 @@ void rtw_stassoc_event_callback(struct adapter *adapter, u8 *pbuf)
 
 	 spin_lock_bh(&pmlmepriv->lock);
 
-	if ((check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) == true) ||
-		(check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) == true)) {
+	if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) ||
+		check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) {
 		 if (adapter->stapriv.asoc_sta_count == 2) {
 			 spin_lock_bh(&pmlmepriv->scanned_queue.lock);
 			 ptarget_wlan = rtw_find_network(&pmlmepriv->scanned_queue, cur_network->network.mac_address);
@@ -2018,7 +2018,7 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, uint in_
 	 return ielength;
 }
 
-/* Ported from 8185: IsInPreAuthKeyList(). 
+/* Ported from 8185: IsInPreAuthKeyList().
  * (Renamed from SecIsInPreAuthKeyList(), 2006-10-13.)
  * Added by Annie, 2006-05-07.
  *
Signature · 1 line
2.52.0
maintainer
#2 lore raw
Quoted 10 lines · Lorenzo Simonelli

This patch performs style cleanups in rtw_mlme.c, specifically removing unnecessary boolean comparisons and trailing whitespaces. These changes improve adherence to the kernel coding style.

---
v2:
- Dropped the patch for sm750fb due to build regression.
- Consolidated remaining style cleanups into this single patch.

As my bot said, you need to do only one-logical-thing per patch. That is not what is happening here :(

Please break this up into multiple patches.

thanks,

greg k-h