Skip to contentSkip to conversation

checkpatch: Suppress warnings when Reported-by: is followed by Link:

PATCH RESEND In review Cryolitia PukNgae 2 participants 2 messages Jan 13 – Jan 15

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND v2 1/1 checkpatch: Suppress warnings when Reported-by: is followed by Link:

Quoted 4 lines

The tag should be followed by a Closes: tag pointing to the report, unless the report is not available on the web. The Link: tag can be used instead of Closes: if the patch fixes a part of the issue(s) being reported.

Accroding to Documentation/process/submitting-patches.rst , Link: is also acceptable to followed a Reported-by:

---
Link to previous: https://lore.kernel.org/r/[email protected]

---
 scripts/checkpatch.pl | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
scripts/checkpatch.pl +3 -3
index c0250244cf7a..dac9d98133c6 100755
@@ -3209,10 +3209,10 @@ sub process {
 			if ($sign_off =~ /^reported(?:|-and-tested)-by:$/i) {
 				if (!defined $lines[$linenr]) {
 					WARN("BAD_REPORTED_BY_LINK",
-					     "Reported-by: should be immediately followed by Closes: with a URL to the report\n" . $herecurr . "\n");
-				} elsif ($rawlines[$linenr] !~ /^closes:\s*/i) {
+					     "Reported-by: should be immediately followed by Closes: or Link: with a URL to the report\n" . $herecurr . "\n");
+				} elsif ($rawlines[$linenr] !~ /^(closes|link):\s*/i) {
 					WARN("BAD_REPORTED_BY_LINK",
-					     "Reported-by: should be immediately followed by Closes: with a URL to the report\n" . $herecurr . $rawlines[$linenr] . "\n");
+					     "Reported-by: should be immediately followed by Closes: or Link: with a URL to the report\n" . $herecurr . $rawlines[$linenr] . "\n");
 				}
 			}
 		}

---
base-commit: 9448598b22c50c8a5bb77a9103e2d49f134c9578
change-id: 20250919-checkpatch-0276787ebfbe

Best regards,

Signature · 1 line
Cryolitia PukNgae <[email protected]>
Reviewed-by on v2 1/1
#1 lore raw

Hi Cryolitia,

Quoted 6 lines

From: Cryolitia PukNgae <[email protected]>

Quoted 4 lines

The tag should be followed by a Closes: tag pointing to the report, unless the report is not available on the web. The Link: tag can be used instead of Closes: if the patch fixes a part of the issue(s) being reported.

Indeed, this is true, although there is a prerequisite:

The Link: tag can be used instead of Closes: if the patch fixes a part of the issue(s) being reported.

I also see you Cc LTP ML. FYI we vendored scripts/checkpatch.pl (with occasional updates).

Kind regards,
Petr

Quoted 28 lines

Accroding to Documentation/process/submitting-patches.rst , Link: is also acceptable to followed a Reported-by:

---
Link to previous: https://lore.kernel.org/r/[email protected]

---
 scripts/checkpatch.pl | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
scripts/checkpatch.pl +3 -3
index c0250244cf7a..dac9d98133c6 100755
@@ -3209,10 +3209,10 @@ sub process {
 			if ($sign_off =~ /^reported(?:|-and-tested)-by:$/i) {
 				if (!defined $lines[$linenr]) {
 					WARN("BAD_REPORTED_BY_LINK",
-					     "Reported-by: should be immediately followed by Closes: with a URL to the report\n" . $herecurr . "\n");
-				} elsif ($rawlines[$linenr] !~ /^closes:\s*/i) {
+					     "Reported-by: should be immediately followed by Closes: or Link: with a URL to the report\n" . $herecurr . "\n");
+				} elsif ($rawlines[$linenr] !~ /^(closes|link):\s*/i) {
 					WARN("BAD_REPORTED_BY_LINK",
-					     "Reported-by: should be immediately followed by Closes: with a URL to the report\n" . $herecurr . $rawlines[$linenr] . "\n");
+					     "Reported-by: should be immediately followed by Closes: or Link: with a URL to the report\n" . $herecurr . $rawlines[$linenr] . "\n");
 				}
 			}
 		}