Skip to contentSkip to conversation

dt-bindings: goldfish: Convert to DT schema

PATCH Applied Kuan-Wei Chiu 6 participants 15 messages Jan 13 – Jan 30

Subsystems (9)
lore
Share & tools
lore
#0 lore raw

v4 cover dt-bindings: goldfish: Convert to DT schema

Convert the Android Goldfish emulator platform bindings from text format to DT schema.

Most of these bindings are currently located in Documentation/devicetree/bindings/goldfish/. Move them to the appropriate subsystem directories (serial, input, power, sound, misc) to align with the kernel directory structure.

Update the examples to use generic node names (e.g., 'serial' instead of 'goldfish_tty') and fix minor inconsistencies in the original documentation to comply with current DT specifications.
---
Changes in v4:
- Update 'interrupts' property in examples to use decimal values where appropriate, replacing hex values.

Changes in v3:
- Update 'interrupts' property in examples to use decimal values where appropriate, replacing hex values.

Changes in v2:
- Add references to generic subsystem schemas (serial, input, power-supply) where applicable.
- Update property validation to use 'unevaluatedProperties: false' for schemas referencing generic bindings.

v3: https://lore.kernel.org/lkml/[email protected]/
v2: https://lore.kernel.org/lkml/[email protected]/
v1: https://lore.kernel.org/lkml/[email protected]/

Kuan-Wei Chiu (6):
dt-bindings: serial: google,goldfish-tty: Convert to DT schema
dt-bindings: misc: google,android-pipe: Convert to DT schema
dt-bindings: input: google,goldfish-events-keypad: Convert to DT
schema
dt-bindings: power: supply: google,goldfish-battery: Convert to DT
schema
dt-bindings: sound: google,goldfish-audio: Convert to DT schema
dt-bindings: display: google,goldfish-fb: Convert to DT schema

 .../bindings/display/google,goldfish-fb.txt   | 17 --------
 .../bindings/display/google,goldfish-fb.yaml  | 38 +++++++++++++++++
 .../devicetree/bindings/goldfish/audio.txt    | 17 --------
 .../devicetree/bindings/goldfish/battery.txt  | 17 --------
 .../devicetree/bindings/goldfish/events.txt   | 17 --------
 .../devicetree/bindings/goldfish/pipe.txt     | 17 --------
 .../devicetree/bindings/goldfish/tty.txt      | 17 --------
 .../input/google,goldfish-events-keypad.yaml  | 41 +++++++++++++++++++
 .../bindings/misc/google,android-pipe.yaml    | 38 +++++++++++++++++
 .../power/supply/google,goldfish-battery.yaml | 41 +++++++++++++++++++
 .../bindings/serial/google,goldfish-tty.yaml  | 41 +++++++++++++++++++
 .../bindings/sound/google,goldfish-audio.yaml | 38 +++++++++++++++++
 12 files changed, 237 insertions(+), 102 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/google,goldfish-fb.txt
 create mode 100644 Documentation/devicetree/bindings/display/google,goldfish-fb.yaml
 delete mode 100644 Documentation/devicetree/bindings/goldfish/audio.txt
 delete mode 100644 Documentation/devicetree/bindings/goldfish/battery.txt
 delete mode 100644 Documentation/devicetree/bindings/goldfish/events.txt
 delete mode 100644 Documentation/devicetree/bindings/goldfish/pipe.txt
 delete mode 100644 Documentation/devicetree/bindings/goldfish/tty.txt
 create mode 100644 Documentation/devicetree/bindings/input/google,goldfish-events-keypad.yaml
 create mode 100644 Documentation/devicetree/bindings/misc/google,android-pipe.yaml
 create mode 100644 Documentation/devicetree/bindings/power/supply/google,goldfish-battery.yaml
 create mode 100644 Documentation/devicetree/bindings/serial/google,goldfish-tty.yaml
 create mode 100644 Documentation/devicetree/bindings/sound/google,goldfish-audio.yaml
Signature · 1 line
2.52.0.457.g6b5491de43-goog
#1 lore raw

PATCH v4 1/6 dt-bindings: serial: google,goldfish-tty: Convert to DT schema

Convert the Google Goldfish TTY binding to DT schema format. Move the file to the serial directory to match the subsystem. Update the example node name to 'serial' to comply with generic node naming standards.

---
Changes in v4:
- Use decimal format for interrupts in the example.

 .../devicetree/bindings/goldfish/tty.txt      | 17 --------
 .../bindings/serial/google,goldfish-tty.yaml  | 41 +++++++++++++++++++
 2 files changed, 41 insertions(+), 17 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/goldfish/tty.txt
 create mode 100644 Documentation/devicetree/bindings/serial/google,goldfish-tty.yaml
Documentation/devicetree/bindings/goldfish/tty.txt deleted +0 -17
deleted file mode 100644
index 82648278da77..000000000000
@@ -1,17 +0,0 @@
-Android Goldfish TTY
-
-Android goldfish tty device generated by android emulator.
-
-Required properties:
-
-- compatible : should contain "google,goldfish-tty" to match emulator
-- reg        : <registers mapping>
-- interrupts : <interrupt mapping>
-
-Example:
-
-	goldfish_tty@1f004000 {
-		compatible = "google,goldfish-tty";
-		reg = <0x1f004000 0x1000>;
-		interrupts = <0xc>;
-	};
Documentation/devicetree/bindings/serial/google,goldfish-tty.yaml new file +41 -0

41 lines not on this page · raw message

Signature · 1 line
2.52.0.457.g6b5491de43-goog
#2 lore raw

PATCH v4 2/6 dt-bindings: misc: google,android-pipe: Convert to DT schema

In reply to Kuan-Wei Chiu

Convert the Android Goldfish QEMU Pipe binding to DT schema format. Move the file to the misc directory as it represents a miscellaneous communication device.
Update the example node name to 'pipe' to comply with generic node naming standards and fix the mismatch between unit address and reg property in the original example.

---
Changes in v4:
- Use decimal format for interrupts in the example.

 .../devicetree/bindings/goldfish/pipe.txt     | 17 ---------
 .../bindings/misc/google,android-pipe.yaml    | 38 +++++++++++++++++++
 2 files changed, 38 insertions(+), 17 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/goldfish/pipe.txt
 create mode 100644 Documentation/devicetree/bindings/misc/google,android-pipe.yaml
Documentation/devicetree/bindings/goldfish/pipe.txt deleted +0 -17
deleted file mode 100644
index 5637ce701788..000000000000
@@ -1,17 +0,0 @@
-Android Goldfish QEMU Pipe
-
-Android pipe virtual device generated by android emulator.
-
-Required properties:
-
-- compatible : should contain "google,android-pipe" to match emulator
-- reg        : <registers mapping>
-- interrupts : <interrupt mapping>
-
-Example:
-
-	android_pipe@a010000 {
-		compatible = "google,android-pipe";
-		reg = <ff018000 0x2000>;
-		interrupts = <0x12>;
-	};
Documentation/devicetree/bindings/misc/google,android-pipe.yaml new file +38 -0
new file mode 100644
index 000000000000..9e8046fd358d
@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/misc/google,android-pipe.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Android Goldfish QEMU Pipe
+
+maintainers:
+  - Kuan-Wei Chiu <[email protected]>
+
+description:
+  Android QEMU pipe virtual device generated by Android emulator.
+
+properties:
+  compatible:
+    const: google,android-pipe
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    pipe@ff018000 {
+        compatible = "google,android-pipe";
+        reg = <0xff018000 0x2000>;
+        interrupts = <18>;
+    };
Signature · 1 line
2.52.0.457.g6b5491de43-goog
maintainer Reviewed-by on v4 2/6
#3 lore raw

Re: [PATCH v4 2/6] dt-bindings: misc: google,android-pipe: Convert to DT schema

Quoted 13 lines · Kuan-Wei Chiu

Convert the Android Goldfish QEMU Pipe binding to DT schema format. Move the file to the misc directory as it represents a miscellaneous communication device.
Update the example node name to 'pipe' to comply with generic node naming standards and fix the mismatch between unit address and reg property in the original example.

---
Changes in v4:
- Use decimal format for interrupts in the example.

Quoted 6 lines
 .../devicetree/bindings/goldfish/pipe.txt     | 17 ---------
 .../bindings/misc/google,android-pipe.yaml    | 38 +++++++++++++++++++
 2 files changed, 38 insertions(+), 17 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/goldfish/pipe.txt
 create mode 100644 Documentation/devicetree/bindings/misc/google,android-pipe.yaml
#4 lore raw

PATCH v4 3/6 dt-bindings: input: google,goldfish-events-keypad: Convert to DT schema

In reply to Kuan-Wei Chiu

Convert the Android Goldfish Events Keypad binding to DT schema format. Move the file to the input directory to match the subsystem. Update the example node name to 'keypad' to comply with generic node naming standards.

---
 .../devicetree/bindings/goldfish/events.txt   | 17 --------
 .../input/google,goldfish-events-keypad.yaml  | 41 +++++++++++++++++++
 2 files changed, 41 insertions(+), 17 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/goldfish/events.txt
 create mode 100644 Documentation/devicetree/bindings/input/google,goldfish-events-keypad.yaml
Documentation/devicetree/bindings/goldfish/events.txt deleted +0 -17
deleted file mode 100644
index 5babf46317a4..000000000000
@@ -1,17 +0,0 @@
-Android Goldfish Events Keypad
-
-Android goldfish events keypad device generated by android emulator.
-
-Required properties:
-
-- compatible : should contain "google,goldfish-events-keypad" to match emulator
-- reg        : <registers mapping>
-- interrupts : <interrupt mapping>
-
-Example:
-
-	goldfish-events@9040000 {
-		compatible = "google,goldfish-events-keypad";
-		reg = <0x9040000 0x1000>;
-		interrupts = <0x5>;
-	};
Documentation/devicetree/bindings/input/google,goldfish-events-keypad.yaml new file +41 -0

41 lines not on this page · raw message

Signature · 1 line
2.52.0.457.g6b5491de43-goog
Reviewed-by on v4 3/6
#5 lore raw

Re: [PATCH v4 3/6] dt-bindings: input: google,goldfish-events-keypad: Convert to DT schema

Quoted 6 lines · Kuan-Wei Chiu

Convert the Android Goldfish Events Keypad binding to DT schema format. Move the file to the input directory to match the subsystem. Update the example node name to 'keypad' to comply with generic node naming standards.

Best regards,
Krzysztof

maintainer Applied
#6 lore raw

Re: [PATCH v4 3/6] dt-bindings: input: google,goldfish-events-keypad: Convert to DT schema

In reply to Kuan-Wei Chiu
Quoted 6 lines · Kuan-Wei Chiu

Convert the Android Goldfish Events Keypad binding to DT schema format. Move the file to the input directory to match the subsystem. Update the example node name to 'keypad' to comply with generic node naming standards.

Applied, thank you.

Signature · 1 line
Dmitry
#7 lore raw

PATCH v4 4/6 dt-bindings: power: supply: google,goldfish-battery: Convert to DT schema

In reply to Kuan-Wei Chiu

Convert the Android Goldfish Battery binding to DT schema format. Move the file to the power/supply directory to match the subsystem. Update the example node name to 'battery' to comply with generic node naming standards.

---
 .../devicetree/bindings/goldfish/battery.txt  | 17 --------
 .../power/supply/google,goldfish-battery.yaml | 41 +++++++++++++++++++
 2 files changed, 41 insertions(+), 17 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/goldfish/battery.txt
 create mode 100644 Documentation/devicetree/bindings/power/supply/google,goldfish-battery.yaml
Documentation/devicetree/bindings/goldfish/battery.txt deleted +0 -17
deleted file mode 100644
index 4fb613933214..000000000000
@@ -1,17 +0,0 @@
-Android Goldfish Battery
-
-Android goldfish battery device generated by android emulator.
-
-Required properties:
-
-- compatible : should contain "google,goldfish-battery" to match emulator
-- reg        : <registers mapping>
-- interrupts : <interrupt mapping>
-
-Example:
-
-	goldfish_battery@9020000 {
-		compatible = "google,goldfish-battery";
-		reg = <0x9020000 0x1000>;
-		interrupts = <0x3>;
-	};
Documentation/devicetree/bindings/power/supply/google,goldfish-battery.yaml new file +41 -0

41 lines not on this page · raw message

Signature · 1 line
2.52.0.457.g6b5491de43-goog
Reviewed-by on v4 4/6
#8 lore raw

Re: [PATCH v4 4/6] dt-bindings: power: supply: google,goldfish-battery: Convert to DT schema

Quoted 6 lines · Kuan-Wei Chiu

Convert the Android Goldfish Battery binding to DT schema format. Move the file to the power/supply directory to match the subsystem. Update the example node name to 'battery' to comply with generic node naming standards.

Best regards,
Krzysztof

#9 lore raw

PATCH v4 5/6 dt-bindings: sound: google,goldfish-audio: Convert to DT schema

In reply to Kuan-Wei Chiu

Convert the Android Goldfish Audio binding to DT schema format. Move the file to the sound directory to match the subsystem. Update the example node name to 'sound' to comply with generic node naming standards.

---
 .../devicetree/bindings/goldfish/audio.txt    | 17 ---------
 .../bindings/sound/google,goldfish-audio.yaml | 38 +++++++++++++++++++
 2 files changed, 38 insertions(+), 17 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/goldfish/audio.txt
 create mode 100644 Documentation/devicetree/bindings/sound/google,goldfish-audio.yaml
Documentation/devicetree/bindings/goldfish/audio.txt deleted +0 -17
deleted file mode 100644
index d043fda433ba..000000000000
@@ -1,17 +0,0 @@
-Android Goldfish Audio
-
-Android goldfish audio device generated by android emulator.
-
-Required properties:
-
-- compatible : should contain "google,goldfish-audio" to match emulator
-- reg        : <registers mapping>
-- interrupts : <interrupt mapping>
-
-Example:
-
-	goldfish_audio@9030000 {
-		compatible = "google,goldfish-audio";
-		reg = <0x9030000 0x100>;
-		interrupts = <0x4>;
-	};
Documentation/devicetree/bindings/sound/google,goldfish-audio.yaml new file +38 -0
new file mode 100644
index 000000000000..d395a5cbc945
@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/google,goldfish-audio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Android Goldfish Audio
+
+maintainers:
+  - Kuan-Wei Chiu <[email protected]>
+
+description:
+  Android goldfish audio device generated by Android emulator.
+
+properties:
+  compatible:
+    const: google,goldfish-audio
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    sound@9030000 {
+        compatible = "google,goldfish-audio";
+        reg = <0x9030000 0x100>;
+        interrupts = <4>;
+    };
Signature · 1 line
2.52.0.457.g6b5491de43-goog
Reviewed-by on v4 5/6
#10 lore raw

Re: [PATCH v4 5/6] dt-bindings: sound: google,goldfish-audio: Convert to DT schema

Quoted 5 lines · Kuan-Wei Chiu

Convert the Android Goldfish Audio binding to DT schema format. Move the file to the sound directory to match the subsystem. Update the example node name to 'sound' to comply with generic node naming standards.

Quoted 7 lines
---
 .../devicetree/bindings/goldfish/audio.txt    | 17 ---------
 .../bindings/sound/google,goldfish-audio.yaml | 38 +++++++++++++++++++
 2 files changed, 38 insertions(+), 17 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/goldfish/audio.txt
 create mode 100644 Documentation/devicetree/bindings/sound/google,goldfish-audio.yaml

Best regards,
Krzysztof

#11 lore raw

PATCH v4 6/6 dt-bindings: display: google,goldfish-fb: Convert to DT schema

In reply to Kuan-Wei Chiu

Convert the Android Goldfish Framebuffer binding to DT schema format. Update the example node name to 'display' to comply with generic node naming standards.

---
 .../bindings/display/google,goldfish-fb.txt   | 17 ---------
 .../bindings/display/google,goldfish-fb.yaml  | 38 +++++++++++++++++++
 2 files changed, 38 insertions(+), 17 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/google,goldfish-fb.txt
 create mode 100644 Documentation/devicetree/bindings/display/google,goldfish-fb.yaml
Documentation/devicetree/bindings/display/google,goldfish-fb.txt deleted +0 -17
deleted file mode 100644
index 751fa9f51e5d..000000000000
@@ -1,17 +0,0 @@
-Android Goldfish framebuffer
-
-Android Goldfish framebuffer device used by Android emulator.
-
-Required properties:
-
-- compatible : should contain "google,goldfish-fb"
-- reg        : <registers mapping>
-- interrupts : <interrupt mapping>
-
-Example:
-
-	display-controller@1f008000 {
-		compatible = "google,goldfish-fb";
-		interrupts = <0x10>;
-		reg = <0x1f008000 0x100>;
-	};
Documentation/devicetree/bindings/display/google,goldfish-fb.yaml new file +38 -0
new file mode 100644
index 000000000000..36ed77cbbcd7
@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/google,goldfish-fb.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Android Goldfish Framebuffer
+
+maintainers:
+  - Kuan-Wei Chiu <[email protected]>
+
+description:
+  Android Goldfish framebuffer device used by Android emulator.
+
+properties:
+  compatible:
+    const: google,goldfish-fb
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+additionalProperties: false
+
+examples:
+  - |
+    display@1f008000 {
+        compatible = "google,goldfish-fb";
+        reg = <0x1f008000 0x100>;
+        interrupts = <16>;
+    };
Signature · 1 line
2.52.0.457.g6b5491de43-goog
maintainer Applied
#12 lore raw

Re: [PATCH v4 6/6] dt-bindings: display: google,goldfish-fb: Convert to DT schema

Quoted 4 lines · Kuan-Wei Chiu

Convert the Android Goldfish Framebuffer binding to DT schema format. Update the example node name to 'display' to comply with generic node naming standards.

Quoted 8 lines
---
 .../bindings/display/google,goldfish-fb.txt   | 17 ---------
 .../bindings/display/google,goldfish-fb.yaml  | 38 +++++++++++++++++++
 2 files changed, 38 insertions(+), 17 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/google,goldfish-fb.txt
 create mode 100644 Documentation/devicetree/bindings/display/google,goldfish-fb.yaml

Applied, thanks!

maintainer
#13 lore raw

Re: (subset) [PATCH v4 0/6] dt-bindings: goldfish: Convert to DT schema

In reply to Kuan-Wei Chiu
Quoted 9 lines · Kuan-Wei Chiu

Convert the Android Goldfish emulator platform bindings from text format to DT schema.

Most of these bindings are currently located in Documentation/devicetree/bindings/goldfish/. Move them to the appropriate subsystem directories (serial, input, power, sound, misc) to align with the kernel directory structure.

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[5/6] dt-bindings: sound: google,goldfish-audio: Convert to DT schema

      commit: 10303b32519f52a5afd40593a507543143c8ec6a

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

#14 lore raw

Re: (subset) [PATCH v4 0/6] dt-bindings: goldfish: Convert to DT schema

In reply to Kuan-Wei Chiu
Quoted 9 lines · Kuan-Wei Chiu

Convert the Android Goldfish emulator platform bindings from text format to DT schema.

Most of these bindings are currently located in Documentation/devicetree/bindings/goldfish/. Move them to the appropriate subsystem directories (serial, input, power, sound, misc) to align with the kernel directory structure.

[...]

Applied, thanks!

[4/6] dt-bindings: power: supply: google,goldfish-battery: Convert to DT schema

      commit: 4c3f02f843999a590f4481791f59a2f9a7f34fe4

Best regards,

Signature · 1 line
Sebastian Reichel <[email protected]>