Skip to contentSkip to conversation

net: can: etas_es58x: full cleanup in the error case

PATCH In review Oliver Neukum 2 participants 2 messages Jan 13

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: can: etas_es58x: full cleanup in the error case

Memory allocation can fail in the middle. Hence the cleanup needs to be called in every case.

---
 drivers/net/can/usb/etas_es58x/es58x_core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/can/usb/etas_es58x/es58x_core.c +2 -1
index f799233c2b72..8a8764374713 100644
@@ -1783,8 +1783,9 @@ static int es58x_open(struct net_device *netdev)
 
 	if (!es58x_dev->opened_channel_cnt) {
 		ret = es58x_alloc_rx_urbs(es58x_dev);
+		/* can fail partially */
 		if (ret)
-			return ret;
+			goto free_urbs;
 
 		ret = es58x_set_realtime_diff_ns(es58x_dev);
 		if (ret)
Signature · 1 line
2.52.0