Skip to contentSkip to conversation

package/evilwm: fix compilation with external toolchains

PATCH Applied Waldemar Brodkorb 2 participants 3 messages Sep 11, 2025 – Jan 13

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/evilwm: fix compilation with external toolchains

Switch to generic-package, as the configure script isn't really a autotool generated script. This fixes building evilwm with an external toolchain.

Fixes:
- https://autobuild.buildroot.org/results/250/25040ce7e94acf8f92c24db895d7dea081de1d7a

---
v1->v2:
- add link to autobuilder (suggested by Arnout)
- use TARGET_CROSS (suggested by Arnout)

---
 package/evilwm/evilwm.mk | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)
package/evilwm/evilwm.mk +23 -1
index 78b531095b..12934427b9 100644
@@ -18,4 +18,26 @@ endef
 
 EVILWM_POST_INSTALL_TARGET_HOOKS += EVILWM_INSTALL_XSESSION_FILE
 
-$(eval $(autotools-package))
+EVILWM_TOOLS_PREFIX += $(patsubst %-,%,$(TARGET_CROSS))
+
+# the configure script is not generated by autoconf
+define EVILWM_CONFIGURE_CMDS
+	(cd $(@D); $(TARGET_CONFIGURE_OPTS) \
+		CFLAGS="$(TARGET_CFLAGS)" \
+		LDFLAGS="$(TARGET_LDFLAGS)" \
+		./configure \
+		--prefix=/usr \
+		--mandir=/usr/share/man \
+		--host=$(EVILWM_TOOLS_PREFIX) \
+	)
+endef
+
+define EVILWM_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
+endef
+
+define EVILWM_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) DESTDIR="$(TARGET_DIR)" -C $(@D) install
+endef
+
+$(eval $(generic-package))
Signature · 6 lines
2.47.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 7 lines · On Thu, 11 Sep 2025 11:23:08 +0200 Waldemar Brodkorb <[email protected]> wrote:

Switch to generic-package, as the configure script isn't really a autotool generated script. This fixes building evilwm with an external toolchain.

Fixes:
- https://autobuild.buildroot.org/results/250/25040ce7e94acf8f92c24db895d7dea081de1d7a

Quoted 8 lines

---
v1->v2:
- add link to autobuilder (suggested by Arnout)
- use TARGET_CROSS (suggested by Arnout)

---
 package/evilwm/evilwm.mk | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

Applied to master, thanks.

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw
In reply to Waldemar Brodkorb

In reply of:

Quoted 8 lines

Switch to generic-package, as the configure script isn't really a autotool generated script. This fixes building evilwm with an external toolchain.

Fixes:
- https://autobuild.buildroot.org/results/250/25040ce7e94acf8f92c24db895d7dea081de1d7a

Applied to 2025.02.x and 2025.11.x. Thanks

Quoted 47 lines

---
v1->v2:
- add link to autobuilder (suggested by Arnout)
- use TARGET_CROSS (suggested by Arnout)

---
 package/evilwm/evilwm.mk | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)
package/evilwm/evilwm.mk +23 -1
index 78b531095b..12934427b9 100644
@@ -18,4 +18,26 @@ endef
 
 EVILWM_POST_INSTALL_TARGET_HOOKS += EVILWM_INSTALL_XSESSION_FILE
 
-$(eval $(autotools-package))
+EVILWM_TOOLS_PREFIX += $(patsubst %-,%,$(TARGET_CROSS))
+
+# the configure script is not generated by autoconf
+define EVILWM_CONFIGURE_CMDS
+	(cd $(@D); $(TARGET_CONFIGURE_OPTS) \
+		CFLAGS="$(TARGET_CFLAGS)" \
+		LDFLAGS="$(TARGET_LDFLAGS)" \
+		./configure \
+		--prefix=/usr \
+		--mandir=/usr/share/man \
+		--host=$(EVILWM_TOOLS_PREFIX) \
+	)
+endef
+
+define EVILWM_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D)
+endef
+
+define EVILWM_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) DESTDIR="$(TARGET_DIR)" -C $(@D) install
+endef
+
+$(eval $(generic-package))
Signature · 6 lines
2.47.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot