staging: fbtft: Change udelay() to fsleep()
Subsystems (3)
PATCH v3 1/1 staging: fbtft: Change udelay() to fsleep()
Replace udelay() calls >= 100us with fsleep() to avoid busy-waiting.
The delays are used in init_display() callbacks. These callbacks are invoked by fbtft_probe_common() during the driver's probe path. The probe path runs in process context which already uses sleeping APIs. This makes fsleep() safe to use in these situations.
--- drivers/staging/fbtft/fb_tinylcd.c | 2 +- drivers/staging/fbtft/fb_upd161704.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/staging/fbtft/fb_tinylcd.c +1 -1
@@ -41,7 +41,7 @@ static int init_display(struct fbtft_par *par) 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);write_reg (par,MIPI_DCS_SET_PIXEL_FORMAT ,0x55 );write_reg (par,MIPI_DCS_EXIT_SLEEP_MODE ); -udelay (250 ); +fsleep (250 );write_reg (par,MIPI_DCS_SET_DISPLAY_ON );return 0 ;
drivers/staging/fbtft/fb_upd161704.c +2 -2
@@ -32,7 +32,7 @@ static int init_display(struct fbtft_par *par)/* oscillator start */ write_reg (par,0x003A ,0x0001 );/*Oscillator 0: stop, 1: operation */ -udelay (100 ); +fsleep (100 );/* y-setting */ write_reg (par,0x0024 ,0x007B );/* amplitude setting */
@@ -60,7 +60,7 @@ static int init_display(struct fbtft_par *par)/* Power supply setting */ write_reg (par,0x0019 ,0x0000 );/* DC/DC output setting */ -udelay (200 ); +fsleep (200 );write_reg (par,0x001A ,0x1000 );/* DC/DC frequency setting */ write_reg (par,0x001B ,0x0023 );/* DC/DC rising setting */ write_reg (par,0x001C ,0x0C01 );/* Regulator voltage setting */
Signature · 1 line
2.34.1
Quoted 7 lines · Gideon Adjei
Replace
udelay()calls >= 100us withfsleep()to avoid busy-waiting.The delays are used in
init_display()callbacks. These callbacks are invoked byfbtft_probe_common()during the driver's probe path. The probe path runs in process context which already uses sleeping APIs. This makesfsleep()safe to use in these situations.
You forgot to add a changelog...
Quoted 2 lines
Signed-off-by Gideon Adjei <[email protected]>---
...somewhere here.
No need to send v4 because of this, just reply with the changelogs for v1->v2 and v2->v3.
Also note, it's assumed that even for such a simple patch the time between versions is at least 24h.
Quoted 3 lines
drivers/staging/fbtft/fb_tinylcd.c | 2 +- drivers/staging/fbtft/fb_upd161704.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 3 lines · Andy Shevchenko
No need to send v4 because of this, just reply with the changelogs for
v1->v2andv2->v3.
Changelog:
v1->v2:
- Added explanation to why usleep_range() is safe in this context to commit message.
v2->v3:
- Switched from usleep_range() to fsleep().
- Corrected a minor grammar error in commit message.
No functional changes to the code itself.
Quoted 2 lines
Also note, it's assumed that even for such a simple patch the time between versions is at least 24h.
Thank you for the reminder regarding the expected interval between revions. I will ensure this observed going forward.
Greg Kroah-Hartman
maintainerQuoted 18 lines · Gideon Adjei
Replace
udelay()calls >= 100us withfsleep()to avoid busy-waiting.The delays are used in
init_display()callbacks. These callbacks are invoked byfbtft_probe_common()during the driver's probe path. The probe path runs in process context which already uses sleeping APIs. This makesfsleep()safe to use in these situations.Signed-off-by Gideon Adjei <[email protected]>--- drivers/staging/fbtft/fb_tinylcd.c | 2 +- drivers/staging/fbtft/fb_upd161704.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)drivers/staging/fbtft/fb_tinylcd.c +0
-0
drivers/staging/fbtft/fb_tinylcd.c static int init_display(struct fbtft_par *par) · line 44
Quoted 5 lines
drivers/staging/fbtft/fb_tinylcd.c +1
-1@@ -41,7 +41,7 @@ static int init_display(struct fbtft_par *par) 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);write_reg (par,MIPI_DCS_SET_PIXEL_FORMAT ,0x55 );write_reg (par,MIPI_DCS_EXIT_SLEEP_MODE ); -udelay (250 ); +fsleep (250 );
Without the hardware and specifications to test this with, we can't take this type of patch. Please see the mailing list archives for the multitude of times it has been rejected in the past.
sorry, but checkpatch can be ignored here.
thanks,
greg k-h