drm/bridge: Separate of_drm_find_bridge() preconditions list
Subsystems (3)
PATCH 1/1 drm/bridge: Separate of_drm_find_bridge() preconditions list
Sphinx reports htmldocs warnings:
Documentation/gpu/drm-kms-helpers:197: drivers/gpu/drm/drm_bridge.c:1521: ERROR: Unexpected indentation. [docutils] Documentation/gpu/drm-kms-helpers:197: drivers/gpu/drm/drm_bridge.c:1523: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
Fix them by separating preconditions list in of_drm_find_bridge() kernel-doc comment from previous paragraph.
--- drivers/gpu/drm/drm_bridge.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/drm_bridge.c +1 -0
@@ -1518,6 +1518,7 @@ EXPORT_SYMBOL(of_drm_find_and_get_bridge);* The bridge returned by this function is not refcounted. This is * dangerous because the bridge might be deallocated even before the caller * has a chance to use it. To use this function you have to do one of: +* * - get a reference with drm_bridge_get() as soon as possible to * minimize the race window, and then drm_bridge_put() when no longer * using the pointer
base-commit: c40b50c3cfbe274f054c6a2d2fa62cd7c4650460
Signature · 1 line
An old man doll... just what I always wanted! - Clara
Luca Ceresoli
reviewerHello Bagas,
Quoted 5 lines · Bagas Sanjaya
Sphinx reports htmldocs warnings:
Documentation/gpu/drm-kms-helpers:197:drivers/gpu/drm/drm_bridge.c:1521: ERROR: Unexpected indentation. [docutils]Documentation/gpu/drm-kms-helpers:197:drivers/gpu/drm/drm_bridge.c:1523: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils]
Quoted 7 lines
Fix them by separating preconditions list in
of_drm_find_bridge()kernel-doc comment from previous paragraph.Fixes 9da0e06abda87b ("drm/bridge: deprecate of_drm_find_bridge()")Reported-by Stephen Rothwell <[email protected]>Signed-off-by Bagas Sanjaya <[email protected]>
Thanks for your patch.
However the issue had been previously reported on Dec 30 [0] and I had sent a fix the next day [1], but without any feedback so I couldn't apply it to drm-misc-next.
My patch is slightly different from yours. I'm OK with either version.
[0] https://lore.kernel.org/oe-kbuild-all/[email protected]/
[1] https://lore.kernel.org/lkml/20251231-drm-bridge-alloc-getput-drm_of_find_bridge-kdoc-fix-v1-1-193a03f0609c@bootlin.com/
Best regards,
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com