Skip to contentSkip to conversation

arm64: dts: meson-s4: add support for Khadas VIM1S

PATCH In review Nick Xie 3 participants 10 messages Jan 14

Subsystems (2)
lore
Share & tools
lore

Nick Xie

author
#0 lore raw

v2 cover arm64: dts: meson-s4: add support for Khadas VIM1S

This series adds initial support for the Khadas VIM1S single board computer.

The Khadas VIM1S is based on the Amlogic S905Y4 (S4 family) SoC. It features:
- 2GB LPDDR4 RAM
- 16GB eMMC 5.1 storage
- 32MB SPI flash
- 100 Base-T Ethernet
- AP6256 Wireless (802.11 a/b/g/n/ac, BT5.0)
- HDMI 2.1 video
- 2x USB 2.0 ports
- 1x USB-C (power) with USB 2.0 OTG
- 2x LED's (1x red, 1x white)
- 3x buttons (power, function, reset)
- IR receiver
- 40pin GPIO Header
- 1x micro SD card slot

The first patch adds the devicetree binding, and the second patch adds the board device tree.

Changes in v2:
- dts: fixed dtbs_check warning: removed unsupported 'enable-active-low' property from regulator-sd-3v3 node
- Link to v1: https://lore.kernel.org/linux-amlogic/[email protected]/

Nick Xie (2):
dt-bindings: arm: amlogic: add Khadas VIM1S binding
arm64: dts: add initial device-tree for Khadas VIM1S

 .../devicetree/bindings/arm/amlogic.yaml      |   6 +
 arch/arm64/boot/dts/amlogic/Makefile          |   1 +
 .../amlogic/meson-s4-s905y4-khadas-vim1s.dts  | 190 ++++++++++++++++++
 3 files changed, 197 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amlogic/meson-s4-s905y4-khadas-vim1s.dts
Signature · 1 line
2.34.1
author
#1 lore raw

PATCH v2 1/2 dt-bindings: arm: amlogic: add Khadas VIM1S binding

Add devicetree binding for Khadas VIM1S board based on Amlogic S4 S905Y4 SoC.

---
 Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/amlogic.yaml +6 -0
index 08d9963fe9259..55663e0f7f915 100644
@@ -247,6 +247,12 @@ properties:
               - amlogic,aq222
           - const: amlogic,s4
 
+      - description: Boards with the Amlogic Meson S4 S905Y4 SoC
+        items:
+          - enum:
+              - khadas,vim1s
+          - const: amlogic,s4
+
       - description: Boards with the Amlogic S6 S905X5 SoC
         items:
           - enum:
Signature · 1 line
2.34.1
#2 lore raw

Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add Khadas VIM1S binding

Quoted 4 lines · Nick Xie

Add devicetree binding for Khadas VIM1S board based on Amlogic S4 S905Y4 SoC.

You still have the same From/SoB mismatch.

Quoted 9 lines
---
 Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/amlogic.yaml +0 -0
index 08d9963fe9259..55663e0f7f915 100644

Documentation/devicetree/bindings/arm/amlogic.yaml properties: · line 252

Quoted 6 lines
Documentation/devicetree/bindings/arm/amlogic.yaml +3 -0
@@ -247,6 +247,12 @@ properties:
               - amlogic,aq222
           - const: amlogic,s4
 
+      - description: Boards with the Amlogic Meson S4 S905Y4 SoC
+        items:
+          - enum:

Yopu already have exactly such enum with such description, so your compatible goes there. Look - it is called "Boards" - plural.

Documentation/devicetree/bindings/arm/amlogic.yaml properties: · line 254

Quoted 2 lines
Documentation/devicetree/bindings/arm/amlogic.yaml +2 -0
+              - khadas,vim1s
+          - const: amlogic,s4

Best regards,
Krzysztof

author
#3 lore raw

Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add Khadas VIM1S binding

Quoted 8 lines · Krzysztof Kozlowski <[email protected]> 于2026年1月14日周三 16:51写道:
Quoted 4 lines · Nick Xie

Add devicetree binding for Khadas VIM1S board based on Amlogic S4 S905Y4 SoC.

You still have the same From/SoB mismatch.

OK, I will fix it in next version.

Quoted 13 lines
Quoted 13 lines
---
 Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/amlogic.yaml +0 -0
index 08d9963fe9259..55663e0f7f915 100644
@@ -247,6 +247,12 @@ properties:
               - amlogic,aq222
           - const: amlogic,s4
 
Quoted 6 lines

Documentation/devicetree/bindings/arm/amlogic.yaml properties: · line 252

Quoted 3 lines
Documentation/devicetree/bindings/arm/amlogic.yaml +3 -0
+      - description: Boards with the Amlogic Meson S4 S905Y4 SoC
+        items:
+          - enum:

Yopu already have exactly such enum with such description, so your compatible goes there. Look - it is called "Boards" - plural.

The exist board aq222 is based on SoC S905X2, but the new board vim1s is baed on S905Y4,
they are different SoC, so we need to put S905Y4 under S805X2 ?

Quoted 7 lines

Documentation/devicetree/bindings/arm/amlogic.yaml properties: · line 254

Quoted 3 lines
Documentation/devicetree/bindings/arm/amlogic.yaml +2 -0
+              - khadas,vim1s
+          - const: amlogic,s4

Best regards,
Krzysztof

#4 lore raw

Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add Khadas VIM1S binding

Quoted 32 lines · Nick Xie
Quoted 8 lines · Krzysztof Kozlowski <[email protected]> 于2026年1月14日周三 16:51写道:
Quoted 4 lines · Nick Xie

Add devicetree binding for Khadas VIM1S board based on Amlogic S4 S905Y4 SoC.

You still have the same From/SoB mismatch.

OK, I will fix it in next version.

Quoted 13 lines
Quoted 13 lines
---
  Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
  1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/amlogic.yaml +0 -0
index 08d9963fe9259..55663e0f7f915 100644
@@ -247,6 +247,12 @@ properties:
                - amlogic,aq222
            - const: amlogic,s4
 
Quoted 6 lines

Documentation/devicetree/bindings/arm/amlogic.yaml properties: · line 252

Quoted 3 lines
Documentation/devicetree/bindings/arm/amlogic.yaml +3 -0
+      - description: Boards with the Amlogic Meson S4 S905Y4 SoC
+        items:
+          - enum:

Yopu already have exactly such enum with such description, so your compatible goes there. Look - it is called "Boards" - plural.

Quoted 3 lines

The exist board aq222 is based on SoC S905X2, but the new board vim1s is baed on S905Y4,
they are different SoC, so we need to put S905Y4 under S805X2 ?

It depends, if the S805X2 and the S905Y4 are not compatible (different dies) and not the same die in 2 different but compatible packages, then a secondary compatible should be added like we did for amlogic,g12b or amlogic,meson-gxl.

Neil

Quoted 8 lines
Quoted 8 lines

Documentation/devicetree/bindings/arm/amlogic.yaml properties: · line 254

Quoted 4 lines
Documentation/devicetree/bindings/arm/amlogic.yaml +2 -0
+              - khadas,vim1s
+          - const: amlogic,s4

Best regards,
Krzysztof

#5 lore raw

Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add Khadas VIM1S binding

In reply to Nick Xie
Quoted 17 lines · Nick Xie
Quoted 8 lines · Krzysztof Kozlowski <[email protected]> 于2026年1月14日周三 16:51写道:
Quoted 4 lines · Nick Xie

Add devicetree binding for Khadas VIM1S board based on Amlogic S4 S905Y4 SoC.

You still have the same From/SoB mismatch.

OK, I will fix it in next version.

Quoted 5 lines
Quoted 5 lines
---
 Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Quoted 7 lines
Quoted 7 lines

Documentation/devicetree/bindings/arm/amlogic.yaml properties: · line 248

Quoted 7 lines
Documentation/devicetree/bindings/arm/amlogic.yaml +0 -0
index 08d9963fe9259..55663e0f7f915 100644
@@ -247,6 +247,12 @@ properties:
               - amlogic,aq222
           - const: amlogic,s4

Look here

Quoted 11 lines
Quoted 7 lines

Documentation/devicetree/bindings/arm/amlogic.yaml properties: · line 252

Quoted 4 lines
Documentation/devicetree/bindings/arm/amlogic.yaml +3 -0
+      - description: Boards with the Amlogic Meson S4 S905Y4 SoC
+        items:
+          - enum:

Yopu already have exactly such enum with such description, so your compatible goes there. Look - it is called "Boards" - plural.

The exist board aq222 is based on SoC S905X2, but the new board vim1s is baed on S905Y4,
they are different SoC, so we need to put S905Y4 under S805X2 ?

What is the point of having two separate lists with enums ending the same SoC compatible?

Quoted 4 lines
Quoted 4 lines

Documentation/devicetree/bindings/arm/amlogic.yaml properties: · line 254

Quoted 4 lines
Documentation/devicetree/bindings/arm/amlogic.yaml +2 -0
+              - khadas,vim1s
+          - const: amlogic,s4

And here.

Quoted 4 lines
Quoted 4 lines

Best regards,
Krzysztof

Best regards,
Krzysztof

author
#6 lore raw

Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add Khadas VIM1S binding

Quoted 37 lines · Krzysztof Kozlowski <[email protected]> 于2026年1月14日周三 18:33写道:
Quoted 17 lines · Nick Xie
Quoted 8 lines · Krzysztof Kozlowski <[email protected]> 于2026年1月14日周三 16:51写道:
Quoted 4 lines · Nick Xie

Add devicetree binding for Khadas VIM1S board based on Amlogic S4 S905Y4 SoC.

You still have the same From/SoB mismatch.

OK, I will fix it in next version.

Quoted 5 lines
Quoted 5 lines
---
 Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Quoted 7 lines
Quoted 7 lines

Documentation/devicetree/bindings/arm/amlogic.yaml properties: · line 248

Quoted 7 lines
Documentation/devicetree/bindings/arm/amlogic.yaml +0 -0
index 08d9963fe9259..55663e0f7f915 100644
@@ -247,6 +247,12 @@ properties:
               - amlogic,aq222
           - const: amlogic,s4

Look here

Quoted 8 lines
Quoted 7 lines

Documentation/devicetree/bindings/arm/amlogic.yaml properties: · line 252

Quoted 4 lines
Documentation/devicetree/bindings/arm/amlogic.yaml +3 -0
+      - description: Boards with the Amlogic Meson S4 S905Y4 SoC
+        items:
+          - enum:

Yopu already have exactly such enum with such description, so your compatible goes there. Look - it is called "Boards" - plural.

Quoted 6 lines
Quoted 3 lines

The exist board aq222 is based on SoC S905X2, but the new board vim1s is baed on S905Y4,
they are different SoC, so we need to put S905Y4 under S805X2 ?

What is the point of having two separate lists with enums ending the same SoC compatible?

Actually S805X2 and S905Y4 are different SoC. So maybe like this ?

S805X2:
- description: Boards with the Amlogic Meson S4 S805X2 SoC items:
- enum:
- amlogic,aq222
- const: amlogic,s805x2
- const: amlogic,s4

S905Y4:
- description: Boards with the Amlogic Meson S4 S905Y4 SoC items:
- enum:
- khadas,vim1s
- const: amlogic,s905y4
- const: amlogic,s4

Same as Amlogic A311D & S922X

S922X:
- const: amlogic,s922x
- const: amlogic,g12b

A311D:
- const: amlogic,a311d
- const: amlogic,g12b

Quoted 16 lines
Quoted 5 lines
Quoted 5 lines

Documentation/devicetree/bindings/arm/amlogic.yaml properties: · line 254

Quoted 5 lines
Documentation/devicetree/bindings/arm/amlogic.yaml +2 -0
+              - khadas,vim1s
+          - const: amlogic,s4

And here.

Quoted 4 lines
Quoted 4 lines

Best regards,
Krzysztof

Best regards,
Krzysztof

#7 lore raw

Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add Khadas VIM1S binding

Quoted 55 lines · Nick Xie
Quoted 37 lines · Krzysztof Kozlowski <[email protected]> 于2026年1月14日周三 18:33写道:
Quoted 17 lines · Nick Xie
Quoted 8 lines · Krzysztof Kozlowski <[email protected]> 于2026年1月14日周三 16:51写道:
Quoted 4 lines · Nick Xie

Add devicetree binding for Khadas VIM1S board based on Amlogic S4 S905Y4 SoC.

You still have the same From/SoB mismatch.

OK, I will fix it in next version.

Quoted 5 lines
Quoted 5 lines
---
  Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
  1 file changed, 6 insertions(+)
Quoted 7 lines
Quoted 7 lines

Documentation/devicetree/bindings/arm/amlogic.yaml properties: · line 248

Quoted 7 lines
Documentation/devicetree/bindings/arm/amlogic.yaml +0 -0
index 08d9963fe9259..55663e0f7f915 100644
@@ -247,6 +247,12 @@ properties:
                - amlogic,aq222
            - const: amlogic,s4

Look here

Quoted 8 lines
Quoted 7 lines

Documentation/devicetree/bindings/arm/amlogic.yaml properties: · line 252

Quoted 4 lines
Documentation/devicetree/bindings/arm/amlogic.yaml +3 -0
+      - description: Boards with the Amlogic Meson S4 S905Y4 SoC
+        items:
+          - enum:

Yopu already have exactly such enum with such description, so your compatible goes there. Look - it is called "Boards" - plural.

Quoted 6 lines
Quoted 3 lines

The exist board aq222 is based on SoC S905X2, but the new board vim1s is baed on S905Y4,
they are different SoC, so we need to put S905Y4 under S805X2 ?

What is the point of having two separate lists with enums ending the same SoC compatible?

Actually S805X2 and S905Y4 are different SoC. So maybe like this ?

S805X2:
- description: Boards with the Amlogic Meson S4 S805X2 SoC items:
- enum:
- amlogic,aq222
- const: amlogic,s805x2
- const: amlogic,s4

Quoted 7 lines

S905Y4:
- description: Boards with the Amlogic Meson S4 S905Y4 SoC items:
- enum:
- khadas,vim1s
- const: amlogic,s905y4
- const: amlogic,s4

It's ok for me, but you'll need to update the aq222 DT aswell.

Quoted 27 lines

Same as Amlogic A311D & S922X

S922X:
- const: amlogic,s922x
- const: amlogic,g12b

A311D:
- const: amlogic,a311d
- const: amlogic,g12b

Quoted 16 lines
Quoted 5 lines
Quoted 5 lines

Documentation/devicetree/bindings/arm/amlogic.yaml properties: · line 254

Quoted 5 lines
Documentation/devicetree/bindings/arm/amlogic.yaml +2 -0
+              - khadas,vim1s
+          - const: amlogic,s4

And here.

Quoted 4 lines
Quoted 4 lines

Best regards,
Krzysztof

Best regards,
Krzysztof

#8 lore raw

Re: [PATCH v2 1/2] dt-bindings: arm: amlogic: add Khadas VIM1S binding

In reply to Krzysztof Kozlowski
Quoted 36 lines · Krzysztof Kozlowski
Quoted 17 lines · Nick Xie
Quoted 8 lines · Krzysztof Kozlowski <[email protected]> 于2026年1月14日周三 16:51写道:
Quoted 4 lines · Nick Xie

Add devicetree binding for Khadas VIM1S board based on Amlogic S4 S905Y4 SoC.

You still have the same From/SoB mismatch.

OK, I will fix it in next version.

Quoted 5 lines
Quoted 5 lines
---
  Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
  1 file changed, 6 insertions(+)
Quoted 7 lines
Quoted 7 lines

Documentation/devicetree/bindings/arm/amlogic.yaml properties: · line 248

Quoted 7 lines
Documentation/devicetree/bindings/arm/amlogic.yaml +0 -0
index 08d9963fe9259..55663e0f7f915 100644
@@ -247,6 +247,12 @@ properties:
                - amlogic,aq222
            - const: amlogic,s4

Look here

Quoted 8 lines
Quoted 7 lines

Documentation/devicetree/bindings/arm/amlogic.yaml properties: · line 252

Quoted 4 lines
Documentation/devicetree/bindings/arm/amlogic.yaml +3 -0
+      - description: Boards with the Amlogic Meson S4 S905Y4 SoC
+        items:
+          - enum:

Yopu already have exactly such enum with such description, so your compatible goes there. Look - it is called "Boards" - plural.

Quoted 6 lines
Quoted 3 lines

The exist board aq222 is based on SoC S905X2, but the new board vim1s is baed on S905Y4,
they are different SoC, so we need to put S905Y4 under S805X2 ?

What is the point of having two separate lists with enums ending the same SoC compatible?

It's very usual for SoC vendors to reuse the same SoC design (here Amlogic S4) into multiple different packages, with some different features enabled & so on, and even new version of the die with some bugfixes.

We did this in the past for goop reasons, and here it also applies. In fact the currently supported SoC (S805X2) is a stripped down version of the S4 SoC like it was done for the S805X which was aalso a stripped down version of the S905X, with a different IO layout and different internal characteristics even if the die logic was the same.

Neil

Quoted 16 lines
Quoted 5 lines
Quoted 5 lines

Documentation/devicetree/bindings/arm/amlogic.yaml properties: · line 254

Quoted 5 lines
Documentation/devicetree/bindings/arm/amlogic.yaml +2 -0
+              - khadas,vim1s
+          - const: amlogic,s4

And here.

Quoted 4 lines
Quoted 4 lines

Best regards,
Krzysztof

Best regards,
Krzysztof

author
#9 lore raw

PATCH v2 2/2 arm64: dts: add initial device-tree for Khadas VIM1S

In reply to Nick Xie

The Khadas VIM1S uses the Amlogic S905Y4 SoC, based on the Amlogic S4 SoC family, on a board with the same form factor as the VIM/VIM2/VIM3/VIM4 models. Serial debug console, ethernet, SD card work with this initial device-tree.

It features:
- 2GB LPDDR4 RAM
- 16GB eMMC 5.1 storage
- 32MB SPI flash
- 100 Base-T Ethernet
- AP6256 Wireless (802.11 a/b/g/n/ac, BT5.0)
- HDMI 2.1 video
- 2x USB 2.0 ports
- 1x USB-C (power) with USB 2.0 OTG
- 2x LED's (1x red, 1x white)
- 3x buttons (power, function, reset)
- IR receiver
- 40pin GPIO Header
- 1x micro SD card slot

---
 arch/arm64/boot/dts/amlogic/Makefile          |   1 +
 .../amlogic/meson-s4-s905y4-khadas-vim1s.dts  | 190 ++++++++++++++++++
 2 files changed, 191 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amlogic/meson-s4-s905y4-khadas-vim1s.dts
arch/arm64/boot/dts/amlogic/Makefile +1 -0
index 219fb088c704d..15f9c817e5023 100644
@@ -85,6 +85,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxm-ugoos-am3.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxm-vega-s96.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxm-wetek-core2.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-s4-s805x2-aq222.dtb
+dtb-$(CONFIG_ARCH_MESON) += meson-s4-s905y4-khadas-vim1s.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-sm1-a95xf3-air-gbit.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-sm1-a95xf3-air.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-sm1-bananapi-m2-pro.dtb
arch/arm64/boot/dts/amlogic/meson-s4-s905y4-khadas-vim1s.dts new file +190 -0

190 lines not on this page · raw message

Signature · 1 line
2.34.1