Skip to contentSkip to conversation

imx8mp-evk trivial patches

PATCH Applied Bernhard Beschow 2 participants 4 messages Jan 14 – Jan 20 Arm i.MX and Layerscape

lore
Share & tools
lore
#0 lore raw

cover imx8mp-evk trivial patches

This series contains just some quality of life improvements for imx8mp-evk machine's CLI usage. The first patch removes the need to pass "-smp 4 -m 6G" and the second one does not suggest passing redundant "-cpu host" when using KVM.

Bernhard Beschow (2):
hw/arm/imx8mp-evk: Provide some defaults matching real hardware docs/system/arm/imx8mp-evk: Avoid suggesting redundant CLI parameters

 docs/system/arm/imx8mp-evk.rst | 4 ++--
 hw/arm/imx8mp-evk.c            | 2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)
Signature · 1 line
2.52.0
#1 lore raw

PATCH 1/2 hw/arm/imx8mp-evk: Provide some defaults matching real hardware

Having four CPUs and 6 GiB of RAM matches real hardware. Fix the machine defaults to make its use more ergonomic and less error-prone.

---
 docs/system/arm/imx8mp-evk.rst | 2 +-
 hw/arm/imx8mp-evk.c            | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)
docs/system/arm/imx8mp-evk.rst +1 -1
index 75c8fbd366..79600cf39a 100644
@@ -54,7 +54,7 @@ Now that everything is prepared the machine can be started as follows:
 
 .. code-block:: bash
 
-  $ qemu-system-aarch64 -M imx8mp-evk -smp 4 -m 3G \
+  $ qemu-system-aarch64 -M imx8mp-evk \
       -display none -serial null -serial stdio \
       -kernel Image \
       -dtb imx8mp-evk.dtb \
hw/arm/imx8mp-evk.c +2 -0
index 0af5aad583..b84ac91a17 100644
@@ -117,8 +117,10 @@ static void imx8mp_evk_machine_init(MachineClass *mc)
 {
     mc->desc = "NXP i.MX 8M Plus EVK Board";
     mc->init = imx8mp_evk_init;
+    mc->default_cpus = 4;
     mc->max_cpus = FSL_IMX8MP_NUM_CPUS;
     mc->default_ram_id = "imx8mp-evk.ram";
+    mc->default_ram_size = 6 * GiB;
     mc->get_default_cpu_type = imx8mp_evk_get_default_cpu_type;
 }
 
Signature · 1 line
2.52.0
#2 lore raw

PATCH 2/2 docs/system/arm/imx8mp-evk: Avoid suggesting redundant CLI parameters

In reply to Bernhard Beschow

Commit 094fd7d36f2a ("hw/arm/imx8mp-evk: Add KVM support") introduced KVM support for the imx8mp-evk machine. KVM only works with the "host" CPU type such that it has been made the default CPU type for KVM. No need to repeat that on the command line.

Fixes 094fd7d36f2a ("hw/arm/imx8mp-evk: Add KVM support")
---
 docs/system/arm/imx8mp-evk.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
docs/system/arm/imx8mp-evk.rst +1 -1
index 79600cf39a..e60a422824 100644
@@ -66,7 +66,7 @@ KVM Acceleration
 ----------------
 
 To enable hardware-assisted acceleration via KVM, append
-``-accel kvm -cpu host`` to the command line. While this speeds up performance
+``-accel kvm`` to the command line. While this speeds up performance
 significantly, be aware of the following limitations:
 
 * The ``imx8mp-evk`` machine is not included under the "virtualization use case"
Signature · 1 line
2.52.0
#3 lore raw
In reply to Bernhard Beschow
Quoted 6 lines · Bernhard Beschow

This series contains just some quality of life improvements for imx8mp-evk machine's CLI usage. The first patch removes the need to pass "-smp 4 -m 6G" and the second one does not suggest passing redundant "-cpu host" when using KVM.

Quoted 7 lines

Bernhard Beschow (2):
hw/arm/imx8mp-evk: Provide some defaults matching real hardware docs/system/arm/imx8mp-evk: Avoid suggesting redundant CLI parameters

 docs/system/arm/imx8mp-evk.rst | 4 ++--
 hw/arm/imx8mp-evk.c            | 2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)

Applied to target-arm.next, thanks.

-- PMM