Skip to contentSkip to conversation

pc-bios: Update vbootrom image to commit 1c8e9510b22c

PATCH In review Jamin Lin via qemu development 4 participants 10 messages Jan 15 – Jan 16

lore
Share & tools
lore
#0 lore raw

cover pc-bios: Update vbootrom image to commit 1c8e9510b22c

v1
Update vbootrom image to commit 1c8e9510b22c

Jamin Lin (1):
pc-bios: Update vbootrom image to commit 1c8e9510b22c

 pc-bios/ast27x0_bootrom.bin | Bin 16408 -> 28564 bytes
 pc-bios/npcm7xx_bootrom.bin | Bin 672 -> 736 bytes
 pc-bios/npcm8xx_bootrom.bin | Bin 672 -> 672 bytes
 3 files changed, 0 insertions(+), 0 deletions(-)
Signature · 1 line
2.43.0
#1 lore raw

PATCH 1/1 pc-bios: Update vbootrom image to commit 1c8e9510b22c

Full changelog since last update (183c9ff8056b) :

Joe Komlodi (1):
npcm8xx: Fix u-boot copy size

Jamin Lin (3):
ast27x0: refactor FIT boot loader into fmc_image.c for future Caliptra Manifest support
ast27x0: Add Caliptra Manifest boot support and MCU runtime loader framework
ast27x0: Fix compilation issues on Ubuntu 22.04

Compiled with gcc version 13.3.0

---
 pc-bios/ast27x0_bootrom.bin | Bin 16408 -> 28564 bytes
 pc-bios/npcm7xx_bootrom.bin | Bin 672 -> 736 bytes
 pc-bios/npcm8xx_bootrom.bin | Bin 672 -> 672 bytes
 3 files changed, 0 insertions(+), 0 deletions(-)
pc-bios/ast27x0_bootrom.bin binary +0 -0
index a4c94d64da55ade9b4beb2a409132f315fb51347..626499b117c72ea59d906c60655780d91229616e 100644
GIT binary patch
pc-bios/npcm7xx_bootrom.bin binary +0 -0
index 92282892b70dbcd6828c5054dff33ffe3385c485..60e5517eedfd6b35095bfb8d18181f561bafe556 100644
GIT binary patch
pc-bios/npcm8xx_bootrom.bin binary +0 -0
index 45fb40fb5987ab681cc902659d85e76a7385cb53..4b6f82f38d61750c49f2eba61fb3f77dbcb179f4 100644
GIT binary patch
Signature · 1 line
2.43.0
#2 lore raw
Quoted 6 lines · Jamin Lin

Full changelog since last update (183c9ff8056b) :

Joe Komlodi (1):
npcm8xx: Fix u-boot copy size

Quoted 8 lines

Jamin Lin (3):
ast27x0: refactor FIT boot loader into fmc_image.c for future Caliptra Manifest support
ast27x0: Add Caliptra Manifest boot support and MCU runtime loader framework
ast27x0: Fix compilation issues on Ubuntu 22.04

Compiled with gcc version 13.3.0

Thank you for updating the QEMU binaries for the bootroms Jamin!

-Nabih

Quoted 396 lines
---
 pc-bios/ast27x0_bootrom.bin | Bin 16408 -> 28564 bytes
 pc-bios/npcm7xx_bootrom.bin | Bin 672 -> 736 bytes
 pc-bios/npcm8xx_bootrom.bin | Bin 672 -> 672 bytes
 3 files changed, 0 insertions(+), 0 deletions(-)
pc-bios/ast27x0_bootrom.bin binary +0 -0
index a4c94d64da55ade9b4beb2a409132f315fb51347..626499b117c72ea59d906c60655780d91229616e 100644
GIT binary patch
pc-bios/npcm7xx_bootrom.bin binary +0 -0
index 92282892b70dbcd6828c5054dff33ffe3385c485..60e5517eedfd6b35095bfb8d18181f561bafe556 100644
GIT binary patch
pc-bios/npcm8xx_bootrom.bin binary +0 -1
index 45fb40fb5987ab681cc902659d85e76a7385cb53..4b6f82f38d61750c49f2eba61fb3f77dbcb179f4 100644
GIT binary patch
 
--

2.43.0

#3 lore raw

hmm, I didn't receive the initial email.

Quoted 12 lines · Nabih Estefan
Quoted 11 lines · Jamin Lin

Full changelog since last update (183c9ff8056b) :

Joe Komlodi (1):
npcm8xx: Fix u-boot copy size

Jamin Lin (3):
ast27x0: refactor FIT boot loader into fmc_image.c for future Caliptra Manifest support
ast27x0: Add Caliptra Manifest boot support and MCU runtime loader framework
ast27x0: Fix compilation issues on Ubuntu 22.04

Quoted 5 lines
Quoted 3 lines

Compiled with gcc version 13.3.0

Reviewed-by ?

Thanks,

C.

Quoted 1 line

Thank you for updating the QEMU binaries for the bootroms Jamin!

Reviewed-by
#4 lore raw
Quoted 21 lines · Cédric Le Goater

hmm, I didn't receive the initial email.

Quoted 7 lines · Nabih Estefan
Quoted 6 lines · Jamin Lin

Full changelog since last update (183c9ff8056b) :

Joe Komlodi (1):
npcm8xx: Fix u-boot copy size

Quoted 9 lines
Quoted 8 lines

Jamin Lin (3):
ast27x0: refactor FIT boot loader into fmc_image.c for future Caliptra Manifest support
ast27x0: Add Caliptra Manifest boot support and MCU runtime loader framework
ast27x0: Fix compilation issues on Ubuntu 22.04

Compiled with gcc version 13.3.0

Quoted 8 lines

Reviewed-by ?

Thanks,

C.

Yup. Did the same mistake in two separate places.

Thanks,

-Nabih

Quoted 2 lines
Quoted 2 lines

Thank you for updating the QEMU binaries for the bootroms Jamin!

#5 lore raw
In reply to Cédric Le Goater
Quoted 11 lines

From: Cédric Le Goater <[email protected]>
Sent: Friday, January 16, 2026 12:21 AM
To: Nabih Estefan <[email protected]>; Jamin Lin <[email protected]>
Cc: [email protected]; [email protected]; Troy Lee <[email protected]>; [email protected]; [email protected]
Subject: Re: [PATCH v1 1/1] pc-bios: Update vbootrom image to commit 1c8e9510b22c

hmm, I didn't receive the initial email.

Cédric,

I used the following command to generate a patch to update the pre-built vbootrom images:

git format-patch -o ../v1-patch HEAD~1

However, when I ran get_maintainer.pl, it could not find any maintainers and printed the following message:

./scripts/get_maintainer.pl -f ../v1-patch/v1-0001-pc-bios-Update-vbootrom-image-to-commit-1c8e9510b.patch get_maintainer.pl: No maintainers found, printing recent contributors.
get_maintainer.pl: Do not blindly cc: them on patches! Use common sense.

fatal: ../v1-patch/v1-0001-pc-bios-Update-vbootrom-image-to-commit-1c8e9510b.patch: '../v1-patch/v1-0001-pc-bios-Update-vbootrom-image-to-commit-1c8e9510b.patch' is outside repository at '/home/jamin_lin/upstream/qemu/vbootrom/qemu' [email protected] (open list:All patches CC here)

As a result, only the mailing list was suggested:
Eventually, I sent the patch using the following command

git send-email -cc [email protected] -cc [email protected] -cc --to [email protected] --to [email protected] --to [email protected] ../v1-patch/*.patch --no-smtp-auth --smtp-domain=mail.aspeedtech.com

It seems that I included you in the --to list. Do I need to resend the patch?

https://lore.kernel.org/qemu-devel/[email protected]/

Thanks-Jamin

Quoted 32 lines · Nabih Estefan
Quoted 1 line

On Wed, Jan 14, 2026 at 6:38 PM Jamin Lin <[email protected]>

Quoted 8 lines · wrote:
Quoted 8 lines

Full changelog since last update (183c9ff8056b) :

Joe Komlodi (1):
npcm8xx: Fix u-boot copy size

Jamin Lin (3):
ast27x0: refactor FIT boot loader into fmc_image.c for future

Caliptra Manifest support

Quoted 1 line
Quoted 1 line

ast27x0: Add Caliptra Manifest boot support and MCU runtime

loader framework

Quoted 7 lines
Quoted 5 lines

ast27x0: Fix compilation issues on Ubuntu 22.04

Compiled with gcc version 13.3.0

Reviewed-by ?

Thanks,

C.

Quoted 1 line

Thank you for updating the QEMU binaries for the bootroms Jamin!

#6 lore raw

Hello Jamin,

Quoted 16 lines · Jamin Lin
Quoted 11 lines

From: Cédric Le Goater <[email protected]>
Sent: Friday, January 16, 2026 12:21 AM
To: Nabih Estefan <[email protected]>; Jamin Lin <[email protected]>
Cc: [email protected]; [email protected]; Troy Lee <[email protected]>; [email protected]; [email protected]
Subject: Re: [PATCH v1 1/1] pc-bios: Update vbootrom image to commit 1c8e9510b22c

hmm, I didn't receive the initial email.

Cédric,

I used the following command to generate a patch to update the pre-built vbootrom images:

Quoted 7 lines

git format-patch -o ../v1-patch HEAD~1

However, when I ran get_maintainer.pl, it could not find any maintainers and printed the following message:

./scripts/get_maintainer.pl -f ../v1-patch/v1-0001-pc-bios-Update-vbootrom-image-to-commit-1c8e9510b.patch get_maintainer.pl: No maintainers found, printing recent contributors.
get_maintainer.pl: Do not blindly cc: them on patches! Use common sense.

Weird. MAINTAINERS has :

Nuvoton NPCM7xx
...
F: pc-bios/npcm7xx_bootrom.bin
F: pc-bios/npcm8xx_bootrom.bin
F: roms/vbootrom

We do lack a MAINTAINERS entry for Aspeed :

F: pc-bios/ast27x0_bootrom.bin

Can you please send an update ?

Quoted 8 lines

fatal: ../v1-patch/v1-0001-pc-bios-Update-vbootrom-image-to-commit-1c8e9510b.patch: '../v1-patch/v1-0001-pc-bios-Update-vbootrom-image-to-commit-1c8e9510b.patch' is outside repository at '/home/jamin_lin/upstream/qemu/vbootrom/qemu' [email protected] (open list:All patches CC here)

As a result, only the mailing list was suggested:
Eventually, I sent the patch using the following command

git send-email -cc [email protected] -cc [email protected] -cc --to [email protected] --to [email protected] --to [email protected] ../v1-patch/*.patch --no-smtp-auth --smtp-domain=mail.aspeedtech.com

Looks correct.

I hope my provider OVH is not silently dropping email :/ The same thing happened with an email from Kane. Was any email returned to you ?

Quoted 1 line

It seems that I included you in the --to list. Do I need to resend the patch?

You do need to resend for another reason : roms/vbootrom needs an update too.

Also, for updates with large binaries, for FW updates typically, we prefer subsystem PRs :

See an example for a SLOF update from Thomas :

https://lore.kernel.org/qemu-devel/[email protected]/

Some docs here :

https://www.qemu.org/docs/master/devel/submitting-a-pull-request.html

Ping me if you need help setting up your environment,

Thanks,

C.

#7 lore raw

Hi Cédric

Quoted 83 lines

Subject: Re: [PATCH v1 1/1] pc-bios: Update vbootrom image to commit 1c8e9510b22c

Hello Jamin,

Quoted 6 lines · Jamin Lin
Quoted 6 lines

From: Cédric Le Goater <[email protected]>
Sent: Friday, January 16, 2026 12:21 AM
To: Nabih Estefan <[email protected]>; Jamin Lin <[email protected]>
Cc: [email protected]; [email protected]; Troy Lee <[email protected]>; [email protected];

[email protected]

Quoted 9 lines
Quoted 5 lines

Subject: Re: [PATCH v1 1/1] pc-bios: Update vbootrom image to commit 1c8e9510b22c

hmm, I didn't receive the initial email.

Cédric,

I used the following command to generate a patch to update the pre-built

vbootrom images:

Quoted 4 lines

git format-patch -o ../v1-patch HEAD~1

However, when I ran get_maintainer.pl, it could not find any maintainers and

printed the following message:

Quoted 6 lines

./scripts/get_maintainer.pl -f ../v1-patch/v1-0001-pc-bios-Update-vbootrom-image-to-commit-1c8e9510b. patch
get_maintainer.pl: No maintainers found, printing recent contributors. get_maintainer.pl: Do not blindly cc: them on patches! Use common sense.

Weird. MAINTAINERS has :

   Nuvoton NPCM7xx
   ...
   F: pc-bios/npcm7xx_bootrom.bin
   F: pc-bios/npcm8xx_bootrom.bin
   F: roms/vbootrom

We do lack a MAINTAINERS entry for Aspeed :

   F: pc-bios/ast27x0_bootrom.bin

Can you please send an update ?

Quoted 2 lines

fatal: ../v1-patch/v1-0001-pc-bios-Update-vbootrom-image-to-commit-1c8e95 10b.patch:
'../v1-patch/v1-0001-pc-bios-Update-vbootrom-image-to-commit-1c8e9510b.p atch' is outside repository at '/home/jamin_lin/upstream/qemu/vbootrom/qemu'

Quoted 9 lines

[email protected] (open list:All patches CC here)

As a result, only the mailing list was suggested:
Eventually, I sent the patch using the following command

git send-email -cc [email protected] -cc [email protected] -cc --to [email protected] --to [email protected] --to [email protected] ../v1-patch/*.patch --no-smtp-auth --smtp-domain=mail.aspeedtech.com

Looks correct.

I hope my provider OVH is not silently dropping email :/ The same thing happened with an email from Kane. Was any email returned to you ?

Quoted 1 line

It seems that I included you in the --to list. Do I need to resend the patch?

You do need to resend for another reason : roms/vbootrom needs an update too.

Also, for updates with large binaries, for FW updates typically, we prefer subsystem PRs :

See an example for a SLOF update from Thomas :

Quoted 9 lines

https://lore.kernel.org/qemu-devel/[email protected]
om/

Some docs here :

https://www.qemu.org/docs/master/devel/submitting-a-pull-request.html

Ping me if you need help setting up your environment,

This is my first time submitting a pull request. Please let me know if there is anything incorrect.
https://patchwork.kernel.org/project/qemu-devel/patch/[email protected]/

Thanks-Jamin

Quoted 4 lines

Thanks,

C.

#8 lore raw
Quoted 90 lines · Jamin Lin

Hi Cédric

Quoted 88 lines

Subject: Re: [PATCH v1 1/1] pc-bios: Update vbootrom image to commit 1c8e9510b22c

Hello Jamin,

Quoted 6 lines · Jamin Lin
Quoted 6 lines

From: Cédric Le Goater <[email protected]>
Sent: Friday, January 16, 2026 12:21 AM
To: Nabih Estefan <[email protected]>; Jamin Lin <[email protected]>
Cc: [email protected]; [email protected]; Troy Lee <[email protected]>; [email protected];

[email protected]

Quoted 9 lines
Quoted 5 lines

Subject: Re: [PATCH v1 1/1] pc-bios: Update vbootrom image to commit 1c8e9510b22c

hmm, I didn't receive the initial email.

Cédric,

I used the following command to generate a patch to update the pre-built

vbootrom images:

Quoted 4 lines

git format-patch -o ../v1-patch HEAD~1

However, when I ran get_maintainer.pl, it could not find any maintainers and

printed the following message:

Quoted 6 lines

./scripts/get_maintainer.pl -f ../v1-patch/v1-0001-pc-bios-Update-vbootrom-image-to-commit-1c8e9510b. patch
get_maintainer.pl: No maintainers found, printing recent contributors. get_maintainer.pl: Do not blindly cc: them on patches! Use common sense.

Weird. MAINTAINERS has :

    Nuvoton NPCM7xx
    ...
    F: pc-bios/npcm7xx_bootrom.bin
    F: pc-bios/npcm8xx_bootrom.bin
    F: roms/vbootrom

We do lack a MAINTAINERS entry for Aspeed :

    F: pc-bios/ast27x0_bootrom.bin

Can you please send an update ?

Quoted 2 lines

fatal: ../v1-patch/v1-0001-pc-bios-Update-vbootrom-image-to-commit-1c8e95 10b.patch:
'../v1-patch/v1-0001-pc-bios-Update-vbootrom-image-to-commit-1c8e9510b.p atch' is outside repository at '/home/jamin_lin/upstream/qemu/vbootrom/qemu'

Quoted 9 lines

[email protected] (open list:All patches CC here)

As a result, only the mailing list was suggested:
Eventually, I sent the patch using the following command

git send-email -cc [email protected] -cc [email protected] -cc --to [email protected] --to [email protected] --to [email protected] ../v1-patch/*.patch --no-smtp-auth --smtp-domain=mail.aspeedtech.com

Looks correct.

I hope my provider OVH is not silently dropping email :/ The same thing happened with an email from Kane. Was any email returned to you ?

Quoted 1 line

It seems that I included you in the --to list. Do I need to resend the patch?

You do need to resend for another reason : roms/vbootrom needs an update too.

Also, for updates with large binaries, for FW updates typically, we prefer subsystem PRs :

See an example for a SLOF update from Thomas :

https://lore.kernel.org/qemu-devel/[email protected]
om/

Some docs here :

Quoted 8 lines
Quoted 4 lines

https://www.qemu.org/docs/master/devel/submitting-a-pull-request.html

Ping me if you need help setting up your environment,

This is my first time submitting a pull request. Please let me know if there is anything incorrect.
https://patchwork.kernel.org/project/qemu-devel/patch/[email protected]/

The subject should be:

[PULL SUBSYSTEM vbootrom 0/x] ...

I didn't get the email again :/

C.

#9 lore raw
Quoted 114 lines

From: Cédric Le Goater <[email protected]>
Sent: Friday, January 16, 2026 3:51 PM
To: Jamin Lin <[email protected]>; Nabih Estefan <[email protected]>
Cc: [email protected]; [email protected]; Troy Lee <[email protected]>; [email protected]; [email protected]; Kane Chen <[email protected]>
Subject: Re: [PATCH v1 1/1] pc-bios: Update vbootrom image to commit 1c8e9510b22c

Quoted 35 lines · Jamin Lin

Hi Cédric

Quoted 33 lines

Subject: Re: [PATCH v1 1/1] pc-bios: Update vbootrom image to commit 1c8e9510b22c

Hello Jamin,

Quoted 6 lines · Jamin Lin
Quoted 6 lines

From: Cédric Le Goater <[email protected]>
Sent: Friday, January 16, 2026 12:21 AM
To: Nabih Estefan <[email protected]>; Jamin Lin <[email protected]>
Cc: [email protected]; [email protected]; Troy Lee <[email protected]>; [email protected];

[email protected]

Quoted 10 lines
Quoted 5 lines

Subject: Re: [PATCH v1 1/1] pc-bios: Update vbootrom image to commit 1c8e9510b22c

hmm, I didn't receive the initial email.

Cédric,

I used the following command to generate a patch to update the pre-built

vbootrom images:

Quoted 5 lines

git format-patch -o ../v1-patch HEAD~1

However, when I ran get_maintainer.pl, it could not find any maintainers and

printed the following message:

Quoted 3 lines

./scripts/get_maintainer.pl -f ../v1-patch/v1-0001-pc-bios-Update-vbootrom-image-to-commit-1c8e9510

b.

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

patch
get_maintainer.pl: No maintainers found, printing recent contributors. get_maintainer.pl: Do not blindly cc: them on patches! Use common

sense.

Quoted 63 lines
Quoted 62 lines

Weird. MAINTAINERS has :

    Nuvoton NPCM7xx
    ...
    F: pc-bios/npcm7xx_bootrom.bin
    F: pc-bios/npcm8xx_bootrom.bin
    F: roms/vbootrom

We do lack a MAINTAINERS entry for Aspeed :

    F: pc-bios/ast27x0_bootrom.bin

Can you please send an update ?

Quoted 2 lines

fatal:
../v1-patch/v1-0001-pc-bios-Update-vbootrom-image-to-commit-1c8e95 10b.patch:
'../v1-patch/v1-0001-pc-bios-Update-vbootrom-image-to-commit-1c8e9510 b.p
atch' is outside repository at '/home/jamin_lin/upstream/qemu/vbootrom/qemu'

Quoted 9 lines

[email protected] (open list:All patches CC here)

As a result, only the mailing list was suggested:
Eventually, I sent the patch using the following command

git send-email -cc [email protected] -cc [email protected] -cc --to [email protected] --to [email protected] --to [email protected] ../v1-patch/*.patch --no-smtp-auth --smtp-domain=mail.aspeedtech.com

Looks correct.

I hope my provider OVH is not silently dropping email :/ The same thing happened with an email from Kane. Was any email returned to you ?

Quoted 1 line

It seems that I included you in the --to list. Do I need to resend the patch?

You do need to resend for another reason : roms/vbootrom needs an update too.

Also, for updates with large binaries, for FW updates typically, we prefer subsystem PRs :

See an example for a SLOF update from Thomas :

https://lore.kernel.org/qemu-devel/20251027074404.25758-1-thuth@redha
t.c
om/

Some docs here :

https://www.qemu.org/docs/master/devel/submitting-a-pull-request.html

Ping me if you need help setting up your environment,

Quoted 8 lines
Quoted 4 lines

This is my first time submitting a pull request. Please let me know if there is anything incorrect.
https://patchwork.kernel.org/project/qemu-devel/patch/20260116073024.3
[email protected]/

The subject should be:

[PULL SUBSYSTEM vbootrom 0/x] ...

Okay, will resend

Thanks-Jamin

Quoted 1 line

I didn't get the email again :/

It is very strange. I did not receive return or reject information from your mail server.

Quoted 2 lines

C.