Skip to contentSkip to conversation

net: airoha_eth: increase max MTU to 9220 for DSA jumbo frame support the industry standard for jumbo frame MTU is 9216 bytes. When using DSA sub-system, an extra 4 byte tag is added to each frame. To allow users to set the standard 9216-byte MTU via ifconfig ,increase AIROHA_MAX_MTU to 9220 bytes (9216+4).

PATCH In review Sayantan Nandy 3 participants 3 messages Jan 15 – Jan 20

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: airoha_eth: increase max MTU to 9220 for DSA jumbo frame support the industry standard for jumbo frame MTU is 9216 bytes. When using DSA sub-system, an extra 4 byte tag is added to each frame. To allow users to set the standard 9216-byte MTU via ifconfig ,increase AIROHA_MAX_MTU to 9220 bytes (9216+4).

This change ensures compatibility with common network equipment and jumbo frame configurations.

---
 drivers/net/ethernet/airoha/airoha_eth.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/airoha/airoha_eth.h +1 -1
index fbbc58133364..20e602d61e61 100644
@@ -21,7 +21,7 @@
 #define AIROHA_MAX_NUM_IRQ_BANKS	4
 #define AIROHA_MAX_DSA_PORTS		7
 #define AIROHA_MAX_NUM_RSTS		3
-#define AIROHA_MAX_MTU			9216
+#define AIROHA_MAX_MTU			9220
 #define AIROHA_MAX_PACKET_SIZE		2048
 #define AIROHA_NUM_QOS_CHANNELS		4
 #define AIROHA_NUM_QOS_QUEUES		8
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 1 line

This change ensures compatibility with common network equipment and jumbo frame configurations.

can you please provide more details?

Regards,
Lorenzo

Quoted 22 lines
---
 drivers/net/ethernet/airoha/airoha_eth.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/airoha/airoha_eth.h +1 -1
index fbbc58133364..20e602d61e61 100644
@@ -21,7 +21,7 @@
 #define AIROHA_MAX_NUM_IRQ_BANKS	4
 #define AIROHA_MAX_DSA_PORTS		7
 #define AIROHA_MAX_NUM_RSTS		3
-#define AIROHA_MAX_MTU			9216
+#define AIROHA_MAX_MTU			9220
 #define AIROHA_MAX_PACKET_SIZE		2048
 #define AIROHA_NUM_QOS_CHANNELS		4
 #define AIROHA_NUM_QOS_QUEUES		8
Signature · 1 line
2.43.0
maintainer
#2 lore raw
In reply to Sayantan Nandy
Quoted 1 line · Sayantan Nandy

This change ensures compatibility with common network equipment and jumbo frame configurations.

It looks like that a significant amount of the description landed in the subject, which is not good.

Please reformat the changelog carefully.

Also it looks like this is intended to address a bug; if so it should target the 'net' tree and include a Fixes tag.

Thanks,

Paolo