tests/tracetool: Honor the Python interpreter that "configure" detected
PATCH v2 1/1 tests/tracetool: Honor the Python interpreter that "configure" detected
From: Thomas Huth <[email protected]>
The tracetool tests currently fail if the host installation does not have a "python3" binary (and you compiled QEMU by selecting a different one during the "configure" step). This happens because tracetool-test.py executes scripts/tracetool.py directly, so that this script is run via its shebang line. To fix the issue, use the same Python interpreter to run scripts/tracetool.py as we are using to run the tracetool-test.py script.
---
v2: Use sys.executable instead of passing the Python interpreter around
via a PYTHON environment variable.
tests/tracetool/tracetool-test.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
tests/tracetool/tracetool-test.py +2 -1
@@ -36,7 +36,8 @@ def test_tracetool_one(tracetool, backend, fmt, src_dir, build_dir): actual_file = Path(build_dir, rel_filename) expect_file = Path(src_dir, rel_filename) - args = [tracetool, f"--format={fmt}", f"--backends={backend}", "--group=testsuite"] + args = [sys.executable, tracetool, + f"--format={fmt}", f"--backends={backend}", "--group=testsuite"] if fmt.find("stap") != -1: args += ["--binary=qemu", "--probe-prefix=qemu"]
Signature · 1 line
2.52.0
Quoted 10 lines · Thomas Huth
From: Thomas Huth <[email protected]>
The tracetool tests currently fail if the host installation does not have a "python3" binary (and you compiled QEMU by selecting a different one during the "configure" step). This happens because
tracetool-test.pyexecutesscripts/tracetool.pydirectly, so that this script is run via its shebang line. To fix the issue, use the same Python interpreter to runscripts/tracetool.pyas we are using to run thetracetool-test.pyscript.
Quoted 8 lines
Suggested-by Paolo Bonzini <[email protected]>Signed-off-by Thomas Huth <[email protected]>---
v2: Use sys.executable instead of passing the Python interpreter around
via a PYTHON environment variable.tests/tracetool/tracetool-test.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
With regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Stefan Hajnoczi
AppliedQuoted 10 lines · Thomas Huth
From: Thomas Huth <[email protected]>
The tracetool tests currently fail if the host installation does not have a "python3" binary (and you compiled QEMU by selecting a different one during the "configure" step). This happens because
tracetool-test.pyexecutesscripts/tracetool.pydirectly, so that this script is run via its shebang line. To fix the issue, use the same Python interpreter to runscripts/tracetool.pyas we are using to run thetracetool-test.pyscript.
Quoted 8 lines
Suggested-by Paolo Bonzini <[email protected]>Signed-off-by Thomas Huth <[email protected]>---
v2: Use sys.executable instead of passing the Python interpreter around
via a PYTHON environment variable.tests/tracetool/tracetool-test.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks, applied to my tracing tree:
https://gitlab.com/stefanha/qemu/commits/tracing
Stefan