Skip to contentSkip to conversation

mm: prefer 'unsigned int' over bare 'unsigned' in page_alloc.c

PATCH In review Manish Kumar 3 participants 4 messages Jan 15

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm: prefer 'unsigned int' over bare 'unsigned' in page_alloc.c

Change the declaration of 'seq' from 'unsigned' to 'unsigned int' to follow kernel coding style. No functional change.

---
 mm/page_alloc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
mm/page_alloc.c +2 -2
index 231950d9d5c0..5e132ead5ea0 100644
@@ -577,7 +577,7 @@ void __meminit init_pageblock_migratetype(struct page *page,
 static int page_outside_zone_boundaries(struct zone *zone, struct page *page)
 {
 	int ret;
-	unsigned seq;
+	unsigned int seq;
 	unsigned long pfn = page_to_pfn(page);
 	unsigned long sp, start_pfn;
 
@@ -659,7 +659,7 @@ static inline unsigned int order_to_pindex(int migratetype, int order)
 
 #ifdef CONFIG_TRANSPARENT_HUGEPAGE
 	bool movable;
-	
+
 	if (order > PAGE_ALLOC_COSTLY_ORDER) {
 		VM_BUG_ON(order != HPAGE_PMD_ORDER);
 
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · On Fri, 16 Jan 2026 01:18:45 +0530 Manish Kumar <[email protected]> wrote:

Change the declaration of 'seq' from 'unsigned' to 'unsigned int' to follow kernel coding style. No functional change.

Hello Manish, I hope you're doing well!

The patch looks good to me. However, I just have a few comments about the other patches that you've recently sent out as well.

I think it could be very helpful for reviewers, if you grouped related commits together (in this case, mm/page_alloc.c cleanups) into a single patchset. This lets the reviewers view all related commits together, in each others' contexts.

It would also be super helpful to Cc some of the reviewers / maintainers who are relevant to the change you are making! scripts/get_maintainer.pl will give you a good idea of who might be people who are expereinced in the area and are willing to review the patch.

Thank you for the patchset, have a great day!

#2 lore raw
Quoted 17 lines · On Thu, 15 Jan 2026 15:07:52 -0500 Joshua Hahn <[email protected]> wrote:
Quoted 4 lines · On Fri, 16 Jan 2026 01:18:45 +0530 Manish Kumar <[email protected]> wrote:

Change the declaration of 'seq' from 'unsigned' to 'unsigned int' to follow kernel coding style. No functional change.

Hello Manish, I hope you're doing well!

The patch looks good to me. However, I just have a few comments about the other patches that you've recently sent out as well.

I think it could be very helpful for reviewers, if you grouped related commits together (in this case, mm/page_alloc.c cleanups) into a single patchset. This lets the reviewers view all related commits together, in each others' contexts.

Quoted 8 lines

It would also be super helpful to Cc some of the reviewers / maintainers who are relevant to the change you are making! scripts/get_maintainer.pl will give you a good idea of who might be people who are expereinced in the area and are willing to review the patch.

Thank you for the patchset, have a great day!

Whoops, one more thing. The deletion of an empty tab is included in this patch, but it's not mentioned at all in the changelog. Before adding my reviewed-by, please elaborate on it in the changelog, or submit it in a separate patch.

#3 lore raw
In reply to Manish Kumar
Quoted 2 lines · Manish Kumar

Change the declaration of 'seq' from 'unsigned' to 'unsigned int' to follow kernel coding style. No functional change.

Please don't send these kind of unnecessary cleanup patches to mm.