sched: Fix build for modules using set_tsk_need_resched()
PATCH 1/1 sched: Fix build for modules using set_tsk_need_resched()
Commit adcc3bfa8806 ("sched: Adapt sched tracepoints for RV task model") added a tracepoint to the need_resched action that can be triggered also by set_tsk_need_resched.
This function was previously accessible from out-of-tree modules but it's no longer available because the __trace_set_need_resched() symbol is not exported (together with the tracepoint itself, which was exported in a separate patch) and building such modules fails.
Export __trace_set_need_resched to modules to fix those build issues.
--- kernel/sched/core.c | 1 + 1 file changed, 1 insertion(+)
kernel/sched/core.c +1 -0
@@ -1136,6 +1136,7 @@ void __trace_set_need_resched(struct task_struct *curr, int tif) {trace_sched_set_need_resched_tp (curr,smp_processor_id (), tif); } +EXPORT_SYMBOL_GPL (__trace_set_need_resched);void resched_curr (struct rq *rq) {
base-commit: 0f61b1860cc3f52aef9036d7235ed1f017632193
Signature · 1 line
2.52.0
Quoted 30 lines · On Mon, Jan 12, 2026 at 03:04:13PM +0100 Gabriele Monaco wrote:
Commit
adcc3bfa8806("sched: Adapt sched tracepoints for RV task model") added a tracepoint to theneed_reschedaction that can be triggered also byset_tsk_need_resched.
This function was previously accessible from out-of-tree modules but it's no longer available because the__trace_set_need_resched()symbol is not exported (together with the tracepoint itself, which was exported in a separate patch) and building such modules fails.Export
__trace_set_need_reschedto modules to fix those build issues.Fixes adcc3bfa8806 ("sched: Adapt sched tracepoints for RV task model")Cc Phil Auld <[email protected]>Signed-off-by Gabriele Monaco <[email protected]>--- kernel/sched/core.c | 1 + 1 file changed, 1 insertion(+)kernel/sched/core.c +1
-0@@ -1136,6 +1136,7 @@ void __trace_set_need_resched(struct task_struct *curr, int tif) {trace_sched_set_need_resched_tp (curr,smp_processor_id (), tif); } +EXPORT_SYMBOL_GPL (__trace_set_need_resched);void resched_curr (struct rq *rq) {
Quoted 4 lines
base-commit:
0f61b1860cc3f52aef9036d7235ed1f017632193Signature · 1 line
2.52.0
Thanks Gabriele! And good catch that the other patch is not sufficient.
The following commit has been merged into the sched/core branch of tip:
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 8d737320166bd145af70a3133a9964b00ca81cba Gitweb: https://git.kernel.org/tip/8d737320166bd145af70a3133a9964b00ca81cba Author: Gabriele Monaco <[email protected]> AuthorDate: Mon, 12 Jan 2026 15:04:13 +01:00 Committer: Peter Zijlstra <[email protected]> CommitterDate: Thu, 15 Jan 2026 22:41:26 +01:00
sched: Fix build for modules using set_tsk_need_resched()
Commit adcc3bfa8806 ("sched: Adapt sched tracepoints for RV task model") added a tracepoint to the need_resched action that can be triggered also by set_tsk_need_resched.
This function was previously accessible from out-of-tree modules but it's no longer available because the __trace_set_need_resched() symbol is not exported (together with the tracepoint itself, which was exported in a separate patch) and building such modules fails.
Export __trace_set_need_resched to modules to fix those build issues.
--- kernel/sched/core.c | 1 + 1 file changed, 1 insertion(+)
kernel/sched/core.c +1 -0
@@ -1139,6 +1139,7 @@ void __trace_set_need_resched(struct task_struct *curr, int tif) {trace_sched_set_need_resched_tp (curr,smp_processor_id (), tif); } +EXPORT_SYMBOL_GPL (__trace_set_need_resched);void resched_curr (struct rq *rq) {
Quoted 9 lines · On Thu, Jan 15, 2026 at 09:44:19PM -0000 tip-bot2 for Gabriele Monaco wrote:
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 8d737320166bd145af70a3133a9964b00ca81cba Gitweb: https://git.kernel.org/tip/8d737320166bd145af70a3133a9964b00ca81cba Author: Gabriele Monaco <[email protected]> AuthorDate: Mon, 12 Jan 2026 15:04:13 +01:00 Committer: Peter Zijlstra <[email protected]> CommitterDate: Thu, 15 Jan 2026 22:41:26 +01:00
Thank you for both of these, Peter!
Cheers,
Phil
Quoted 34 lines
sched: Fix build for modules using
set_tsk_need_resched()Commit
adcc3bfa8806("sched: Adapt sched tracepoints for RV task model") added a tracepoint to theneed_reschedaction that can be triggered also byset_tsk_need_resched.
This function was previously accessible from out-of-tree modules but it's no longer available because the__trace_set_need_resched()symbol is not exported (together with the tracepoint itself, which was exported in a separate patch) and building such modules fails.Export
__trace_set_need_reschedto modules to fix those build issues.Fixes adcc3bfa8806 ("sched: Adapt sched tracepoints for RV task model")Signed-off-by Gabriele Monaco <[email protected]>Signed-off-by Peter Zijlstra (Intel) <[email protected]>Reviewed-by Phil Auld <[email protected]>--- kernel/sched/core.c | 1 + 1 file changed, 1 insertion(+)kernel/sched/core.c +1
-0@@ -1139,6 +1139,7 @@ void __trace_set_need_resched(struct task_struct *curr, int tif) {trace_sched_set_need_resched_tp (curr,smp_processor_id (), tif); } +EXPORT_SYMBOL_GPL (__trace_set_need_resched);void resched_curr (struct rq *rq) {
Hi Peter and Gabriele,
Quoted 11 lines · On Thu, Jan 15, 2026 at 06:38:03PM -0500 Phil Auld wrote:
Quoted 9 lines · On Thu, Jan 15, 2026 at 09:44:19PM -0000 tip-bot2 for Gabriele Monaco wrote:
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 8d737320166bd145af70a3133a9964b00ca81cba Gitweb: https://git.kernel.org/tip/8d737320166bd145af70a3133a9964b00ca81cba Author: Gabriele Monaco <[email protected]> AuthorDate: Mon, 12 Jan 2026 15:04:13 +01:00 Committer: Peter Zijlstra <[email protected]> CommitterDate: Thu, 15 Jan 2026 22:41:26 +01:00
Quoted 1 line
Thank you for both of these, Peter!
Well, I think this one and the related one need to lose the _GPL because they are called from things, like wake_up_process(), which are exported without that restriction. This essentially adds _GPL to that and anything else that ends up in resched_curr().
I prefer to add new symbols _GPL too but this case seems different.
Thoughts?
I can spin up a patch against tip:sched/core if you want it.
Cheers,
Phil
Quoted 38 lines
Quoted 35 lines
sched: Fix build for modules using
set_tsk_need_resched()Commit
adcc3bfa8806("sched: Adapt sched tracepoints for RV task model") added a tracepoint to theneed_reschedaction that can be triggered also byset_tsk_need_resched.
This function was previously accessible from out-of-tree modules but it's no longer available because the__trace_set_need_resched()symbol is not exported (together with the tracepoint itself, which was exported in a separate patch) and building such modules fails.Export
__trace_set_need_reschedto modules to fix those build issues.Fixes adcc3bfa8806 ("sched: Adapt sched tracepoints for RV task model")Signed-off-by Gabriele Monaco <[email protected]>Signed-off-by Peter Zijlstra (Intel) <[email protected]>Reviewed-by Phil Auld <[email protected]>--- kernel/sched/core.c | 1 + 1 file changed, 1 insertion(+)kernel/sched/core.c +1
-0@@ -1139,6 +1139,7 @@ void __trace_set_need_resched(struct task_struct *curr, int tif) {trace_sched_set_need_resched_tp (curr,smp_processor_id (), tif); } +EXPORT_SYMBOL_GPL (__trace_set_need_resched);void resched_curr (struct rq *rq) {