arm64: dts: rockchip: Do not enable hdmi_sound node on Pinebook Pro
Subsystems (3)
PATCH v2 1/1 arm64: dts: rockchip: Do not enable hdmi_sound node on Pinebook Pro
Remove the redundant enabling of the hdmi_sound node in the Pinebook Pro board dts file, because the HDMI output is unused on this device. [1][2]
This change also eliminates the following kernel log warning, which is caused by the unenabled dependent node of hdmi_sound that ultimately results in the node's probe failure:
platform hdmi-sound: deferred probe pending: asoc-simple-card: parse error
[1] https://files.pine64.org/doc/PinebookPro/pinebookpro_v2.1_mainboard_schematic.pdf
[2] https://files.pine64.org/doc/PinebookPro/pinebookpro_schematic_v21a_20220419.pdf
---
Changes in v2:
- Rewrite the description of change
- Link to v1: https://lore.kernel.org/linux-rockchip/[email protected]/
--- arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 4 ---- 1 file changed, 4 deletions(-)
arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts +0 -4
@@ -421,10 +421,6 @@ &gpu { status = "okay"; }; -&hdmi_sound { - status = "okay"; -}; - &i2c0 { clock-frequency = <400000>; i2c-scl-falling-time-ns = <4>;
Signature · 1 line
2.52.0
Hello Jun,
Quoted 30 lines · Jun Yan
Remove the redundant enabling of the
hdmi_soundnode in the Pinebook Pro board dts file, because the HDMI output is unused on this device. [1][2]This change also eliminates the following kernel log warning, which is caused by the unenabled dependent node of
hdmi_soundthat ultimately results in the node's probe failure:platform hdmi-sound: deferred probe pending: asoc-simple-card: parse error
[1] https://files.pine64.org/doc/PinebookPro/pinebookpro_v2.1_mainboard_schematic.pdf
[2] https://files.pine64.org/doc/PinebookPro/pinebookpro_schematic_v21a_20220419.pdfFixes 5a65505a69884 ("arm64: dts: rockchip: Add initial support for Pinebook Pro")Signed-off-by Jun Yan <[email protected]>---
Changes in v2:
- Rewrite the description of change
- Link to v1: https://lore.kernel.org/linux-rockchip/[email protected]/--- arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 4 ---- 1 file changed, 4 deletions(-)arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts +0
-0
arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts &gpu { · line 426
Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts +0
-4@@ -421,10 +421,6 @@ &gpu { status = "okay"; }; -&hdmi_sound { - status = "okay"; -}; - &i2c0 { clock-frequency = <400000>; i2c-scl-falling-time-ns = <4>;
Thanks for the v2! It is looking good to me, so please free to include
Quoted 8 lines · Jun Yan
Remove the redundant enabling of the
hdmi_soundnode in the Pinebook Pro board dts file, because the HDMI output is unused on this device. [1][2]This change also eliminates the following kernel log warning, which is caused by the unenabled dependent node of
hdmi_soundthat ultimately results in the node's probe failure:
Quoted 8 lines
platform hdmi-sound: deferred probe pending: asoc-simple-card: parse error
[1] https://files.pine64.org/doc/PinebookPro/pinebookpro_v2.1_mainboard_schematic.pdf
[2] https://files.pine64.org/doc/PinebookPro/pinebookpro_schematic_v21a_20220419.pdfFixes 5a65505a69884 ("arm64: dts: rockchip: Add initial support for Pinebook Pro")Signed-off-by Jun Yan <[email protected]>
Looks good to me.
Quoted 28 lines
---
Changes in v2:
- Rewrite the description of change
- Link to v1: https://lore.kernel.org/linux-rockchip/[email protected]/--- arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 4 ---- 1 file changed, 4 deletions(-)arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts +0
-5@@ -421,10 +421,6 @@ &gpu { status = "okay"; }; -&hdmi_sound { - status = "okay"; -}; - &i2c0 { clock-frequency = <400000>; i2c-scl-falling-time-ns = <4>; --2.52.0
Quoted 8 lines · Jun Yan
Remove the redundant enabling of the
hdmi_soundnode in the Pinebook Pro board dts file, because the HDMI output is unused on this device. [1][2]This change also eliminates the following kernel log warning, which is caused by the unenabled dependent node of
hdmi_soundthat ultimately results in the node's probe failure:[...]
Applied, thanks!
[1/1] arm64: dts: rockchip: Do not enable hdmi_sound node on Pinebook Pro
commit: b18247f9dab735c9c2d63823d28edc9011e7a1ad
Best regards,
Signature · 1 line
Heiko Stuebner <[email protected]>