platform/x86: asus-armoury: ppt fixes and new models
cover platform/x86: asus-armoury: ppt fixes and new models
Hi,
this patch series includes some fixes to the PPT data table and adds support for two new models: G835L and GA403WW.
Cheers,
Denis
Denis Benato (4):
platform/x86: asus-armoury: fix ppt data for FA608UM platform/x86: asus-armoury: add support for G835L platform/x86: asus-armoury: keep the list ordered alphabetically platform/x86: asus-armoury: add support for GA403WW
drivers/platform/x86/asus-armoury.h | 73 ++++++++++++++++++++++++++--- 1 file changed, 67 insertions(+), 6 deletions(-)
Signature · 1 line
2.52.0
PATCH 1/4 platform/x86: asus-armoury: fix ppt data for FA608UM
ppt_pl3_fppt_def and ppt_pl3_fppt_max are wrong: correct it.
--- drivers/platform/x86/asus-armoury.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/platform/x86/asus-armoury.h +2 -2
@@ -611,8 +611,8 @@ static const struct dmi_system_id power_limits[] = { .ppt_pl2_sppt_def = 54, .ppt_pl2_sppt_max = 90, .ppt_pl3_fppt_min = 35, - .ppt_pl3_fppt_def = 90, - .ppt_pl3_fppt_max = 65, + .ppt_pl3_fppt_def = 65, + .ppt_pl3_fppt_max = 90, .nv_dynamic_boost_min = 10, .nv_dynamic_boost_max = 15, .nv_temp_target_min = 75,
Signature · 1 line
2.52.0
PATCH 2/4 platform/x86: asus-armoury: add support for G835L
In reply to Denis BenatoAdd TDP data for laptop model G835L.
--- drivers/platform/x86/asus-armoury.h | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)
drivers/platform/x86/asus-armoury.h +29 -0
@@ -1724,6 +1724,35 @@ static const struct dmi_system_id power_limits[] = { .requires_fan_curve = true, }, }, + { + .matches = { + DMI_MATCH(DMI_BOARD_NAME, "G835LR"), + }, + .driver_data = &(struct power_data ) { + .ac_data = &(struct power_limits ) { + .ppt_pl1_spl_min =28 , + .ppt_pl1_spl_def =140 , + .ppt_pl1_spl_max =175 , + .ppt_pl2_sppt_min =28 , + .ppt_pl2_sppt_max =175 , + .nv_dynamic_boost_min =5 , + .nv_dynamic_boost_max =25 , + .nv_temp_target_min =75 , + .nv_temp_target_max =87 , + .nv_tgp_min =65 , + .nv_tgp_max =115 , + }, + .dc_data = &(struct power_limits ) { + .ppt_pl1_spl_min =25 , + .ppt_pl1_spl_max =55 , + .ppt_pl2_sppt_min =25 , + .ppt_pl2_sppt_max =70 , + .nv_temp_target_min =75 , + .nv_temp_target_max =87 , + }, + .requires_fan_curve = true, + }, + }, { .matches = { DMI_MATCH(DMI_BOARD_NAME, "G835LW"),
Signature · 1 line
2.52.0
PATCH 3/4 platform/x86: asus-armoury: keep the list ordered alphabetically
In reply to Denis BenatoModel GA403WM appears after GA403WR breaking the alphabetical order:
swap theirs position.
--- drivers/platform/x86/asus-armoury.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/platform/x86/asus-armoury.h +8 -8
@@ -957,7 +957,7 @@ static const struct dmi_system_id power_limits[] = { }, { .matches = { - DMI_MATCH(DMI_BOARD_NAME, "GA403WR"), + DMI_MATCH(DMI_BOARD_NAME, "GA403WM"), }, .driver_data = &(struct power_data ) { .ac_data = &(struct power_limits ) {
@@ -968,11 +968,11 @@ static const struct dmi_system_id power_limits[] = { .ppt_pl3_fppt_min = 35, .ppt_pl3_fppt_max = 80, .nv_dynamic_boost_min = 0, - .nv_dynamic_boost_max = 25, + .nv_dynamic_boost_max = 15, .nv_temp_target_min = 75, .nv_temp_target_max = 87, - .nv_tgp_min = 80, - .nv_tgp_max = 95, + .nv_tgp_min = 55, + .nv_tgp_max = 85, }, .dc_data = &(struct power_limits ) { .ppt_pl1_spl_min =15 ,
@@ -989,7 +989,7 @@ static const struct dmi_system_id power_limits[] = { }, { .matches = { - DMI_MATCH(DMI_BOARD_NAME, "GA403WM"), + DMI_MATCH(DMI_BOARD_NAME, "GA403WR"), }, .driver_data = &(struct power_data ) { .ac_data = &(struct power_limits ) {
@@ -1000,11 +1000,11 @@ static const struct dmi_system_id power_limits[] = { .ppt_pl3_fppt_min = 35, .ppt_pl3_fppt_max = 80, .nv_dynamic_boost_min = 0, - .nv_dynamic_boost_max = 15, + .nv_dynamic_boost_max = 25, .nv_temp_target_min = 75, .nv_temp_target_max = 87, - .nv_tgp_min = 55, - .nv_tgp_max = 85, + .nv_tgp_min = 80, + .nv_tgp_max = 95, }, .dc_data = &(struct power_limits ) { .ppt_pl1_spl_min =15 ,
Signature · 1 line
2.52.0
PATCH 4/4 platform/x86: asus-armoury: add support for GA403WW
In reply to Denis BenatoAdd TDP data for laptop model GA403WW.
--- drivers/platform/x86/asus-armoury.h | 32 +++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+)
drivers/platform/x86/asus-armoury.h +32 -0
@@ -1019,6 +1019,38 @@ static const struct dmi_system_id power_limits[] = { .requires_fan_curve = true, }, }, + { + .matches = { + DMI_MATCH(DMI_BOARD_NAME, "GA403WW"), + }, + .driver_data = &(struct power_data ) { + .ac_data = &(struct power_limits ) { + .ppt_pl1_spl_min =15 , + .ppt_pl1_spl_max =80 , + .ppt_pl2_sppt_min =25 , + .ppt_pl2_sppt_max =80 , + .ppt_pl3_fppt_min =35 , + .ppt_pl3_fppt_max =80 , + .nv_dynamic_boost_min =0 , + .nv_dynamic_boost_max =25 , + .nv_temp_target_min =75 , + .nv_temp_target_max =87 , + .nv_tgp_min =80 , + .nv_tgp_max =95 , + }, + .dc_data = &(struct power_limits ) { + .ppt_pl1_spl_min =15 , + .ppt_pl1_spl_max =35 , + .ppt_pl2_sppt_min =25 , + .ppt_pl2_sppt_max =35 , + .ppt_pl3_fppt_min =35 , + .ppt_pl3_fppt_max =65 , + .nv_temp_target_min =75 , + .nv_temp_target_max =87 , + }, + .requires_fan_curve = true, + }, + }, { .matches = { DMI_MATCH(DMI_BOARD_NAME, "GA503QR"),
Signature · 1 line
2.52.0
Ilpo Järvinen
maintainerQuoted 6 lines · Denis Benato
this patch series includes some fixes to the PPT data table and adds support for two new models: G835L and GA403WW.
Cheers,
Denis
Quoted 7 lines
Denis Benato (4):
platform/x86: asus-armoury: fix ppt data for FA608UM platform/x86: asus-armoury: add support for G835L platform/x86: asus-armoury: keep the list ordered alphabetically platform/x86: asus-armoury: add support for GA403WW[...]
Thank you for your contribution, it has been applied to my local review-ilpo-fixes branch. Note it will show up in the public platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my local branch there, which might take a while.
The list of commits applied:
[1/4] platform/x86: asus-armoury: fix ppt data for FA608UM
commit: 66f26bcc8aba2f3e6ae4af2f3c7eb72b5e3918b8
[2/4] platform/x86: asus-armoury: add support for G835L
commit: 1dfc441140ede4f19b7c135664452465fb6a95d4
[3/4] platform/x86: asus-armoury: keep the list ordered alphabetically
commit: 3072c1c919aeca8a09cada4465c32f1e933c6c5e
[4/4] platform/x86: asus-armoury: add support for GA403WW
commit: 9b8e78f78056080ef91802ab44b0145262f34599--
i.