arm64: dts: qcom: hamoa: Add 1443 MHz OPP to iris video codec
PATCH 1/1 arm64: dts: qcom: hamoa: Add 1443 MHz OPP to iris video codec
Add the missing 1443 MHz operating point to the iris video codec OPP table. The qcom-iris driver requests this frequency but fails with:
qcom-iris aa00000.video-codec: dev_pm_opp_set_rate: failed to find OPP for freq 1443000000 (-34) qcom-iris aa00000.video-codec: power on failed
qcom-iris aa00000.video-codec: core init failed
The iris driver uses the sm8550 compatible fallback and expects higher frequencies for turbo modes. Without this OPP, hardware video encoding and decoding fails on x1e80100-based devices.
--- arch/arm64/boot/dts/qcom/hamoa.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)
arch/arm64/boot/dts/qcom/hamoa.dtsi +6 -0
@@ -5397,6 +5397,12 @@ opp-481000000 { required-opps = <&rpmhpd_opp_turbo>, <&rpmhpd_opp_turbo>; }; + + opp-1443000000 { + opp-hz = /bits/ 64 <1443000000>; + required-opps = <&rpmhpd_opp_turbo_l1>, + <&rpmhpd_opp_turbo_l1>; + }; }; };
Signature · 1 line
2.51.0
hi,
Quoted 10 lines · Alejandro Quintanar
Add the missing 1443 MHz operating point to the iris video codec OPP table. The qcom-iris driver requests this frequency but fails with:
qcom-iris aa00000.video-codec:
dev_pm_opp_set_rate: failed to find OPP for freq 1443000000 (-34) qcom-iris aa00000.video-codec: power on failed
qcom-iris aa00000.video-codec: core init failedThe iris driver uses the sm8550 compatible fallback and expects higher frequencies for turbo modes. Without this OPP, hardware video encoding and decoding fails on x1e80100-based devices.
That sounds strange. I never needed to add an OPP to iris, let alone such a massively higher one. I can decode two 4K AV1 streams simultaneously on x1e80100-dell-latitude-7455 and it works fine (adding a 3rd one just grinds them all to a halt, no power errors).
Looking at the code, the clock is calculated as a sum of *minimum* frequencies required for all running sessions (with a fallback to ULONG_MAX if that's not available.. hmm) so maybe something is off somewhere..
~val
Quoted 21 lines · Alejandro Quintanar
Add the missing 1443 MHz operating point to the iris video codec OPP table. The qcom-iris driver requests this frequency but fails with:
qcom-iris aa00000.video-codec:
dev_pm_opp_set_rate: failed to find OPP for freq 1443000000 (-34) qcom-iris aa00000.video-codec: power on failed
qcom-iris aa00000.video-codec: core init failedThe iris driver uses the sm8550 compatible fallback and expects higher frequencies for turbo modes. Without this OPP, hardware video encoding and decoding fails on x1e80100-based devices.
Signed-off-by Alejandro Quintanar <[email protected]>--- arch/arm64/boot/dts/qcom/hamoa.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)arch/arm64/boot/dts/qcom/hamoa.dtsi +0
-0
arch/arm64/boot/dts/qcom/hamoa.dtsi opp-481000000 { · line 5399
Quoted 3 lines
arch/arm64/boot/dts/qcom/hamoa.dtsi +0
-0@@ -5397,6 +5397,12 @@ opp-481000000 { required-opps = <&rpmhpd_opp_turbo>, <&rpmhpd_opp_turbo>; };
The above opp-481000000 is the 1443 MHz setting.. the clock is div3
Is the kernel you're running patched against upstream, wrt iris?
Konrad
Quoted 9 lines
arch/arm64/boot/dts/qcom/hamoa.dtsi +6
-0+ + opp-1443000000 { + opp-hz = /bits/ 64 <1443000000>; + required-opps = <&rpmhpd_opp_turbo_l1>, + <&rpmhpd_opp_turbo_l1>; + }; }; };