bus: ti-sysc: fix reference count leak in sysc_init_stdout_path()
Subsystems (2)
PATCH 1/1 bus: ti-sysc: fix reference count leak in sysc_init_stdout_path()
of_find_node_by_path() returns a device_node with refcount incremented. When of_get_property() is called to get the stdout-path property, the reference to the "/chosen" node stored in np is either leaked if the property lookup fails, or overwritten when np is reassigned to the uart node path without releasing the "/chosen" reference first.
Add of_node_put(np) after of_get_property() to properly release the "/chosen" node reference before either going to the error path or acquiring a new reference for the uart path.
Fixes 3bb37c8e6e6a ("bus: ti-sysc: Handle stdout-path for debug console")
Signed-off-by Weigang He <[email protected]>
--- drivers/bus/ti-sysc.c | 1 + 1 file changed, 1 insertion(+)
drivers/bus/ti-sysc.c +1 -0
@@ -696,6 +696,7 @@ static void sysc_init_stdout_path(struct sysc *ddata) goto err; uart =of_get_property (np,"stdout-path" ,NULL ); +of_node_put (np);if (!uart) goto err;
Signature · 1 line
2.34.1