Skip to contentSkip to conversation

bus: ti-sysc: fix reference count leak on module unload

PATCH New Weigang He 1 participant 1 message Jan 17

Subsystems (2)
lore
Share & tools
lore

Weigang He

author
#0 lore raw

PATCH 1/1 bus: ti-sysc: fix reference count leak on module unload

The stdout_path static variable holds a reference to a device_node obtained from of_find_node_by_path(). When the ti-sysc module is unloaded, this reference is never released, causing a reference count leak.

Add of_node_put(stdout_path) in sysc_exit() to properly release the device_node reference when the module is unloaded.

Fixes 3bb37c8e6e6a ("bus: ti-sysc: Handle stdout-path for debug console")
---
 drivers/bus/ti-sysc.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/bus/ti-sysc.c +3 -0
index fd631a9889c1e..822b9b1b2f6fa 100644
@@ -3338,6 +3338,9 @@ module_init(sysc_init);
 
 static void __exit sysc_exit(void)
 {
+	if (!IS_ERR_OR_NULL(stdout_path))
+		of_node_put(stdout_path);
+
 	bus_unregister_notifier(&platform_bus_type, &sysc_nb);
 	platform_driver_unregister(&sysc_driver);
 	sysc_cleanup_static_data();
Signature · 1 line
2.34.1