Change in openvpn[master]: crypto_openssl: Fix various conversion warnings
A message that is not in the archive (sent off-list or not yet received): gerrit.1765907598000.I99bc4692526f9143a913e29b266a1816295dfd51@...2715...
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1446?usp=email
to review the following change.
Change subject: crypto_openssl: Fix various conversion warnings
......................................................................
crypto_openssl: Fix various conversion warnings
EVP_CIPHER_CTX_flags is documented to output
int on OpenSSL, but is actually unsigned long
OpenSSL 3.
On libressl it is correctly documented to output
unsigned long.
---
M src/openvpn/crypto_openssl.c
1 file changed, 4 insertions(+), 13 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/46/1446/1
src/openvpn/crypto_openssl.c +4 -13
@@ -896,11 +896,6 @@return EVP_CIPHER_CTX_mode (ctx); } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wconversion" -#endif -bool cipher_ctx_mode_cbc (const cipher_ctx_t *ctx) {
@@ -909,7 +904,7 @@return false; } -int flags =EVP_CIPHER_CTX_flags (ctx); +unsigned long flags =EVP_CIPHER_CTX_flags (ctx);int mode =EVP_CIPHER_CTX_mode (ctx);return mode ==EVP_CIPH_CBC_MODE
@@ -940,7 +935,7 @@ {if (ctx) { -int flags =EVP_CIPHER_CTX_flags (ctx); +unsigned long flags =EVP_CIPHER_CTX_flags (ctx);if (flags &EVP_CIPH_FLAG_AEAD_CIPHER ) {return true;
@@ -995,8 +990,8 @@cipher_ctx_final_check_tag (EVP_CIPHER_CTX *ctx, uint8_t *dst, int *dst_len, uint8_t *tag, size_t tag_len) { -ASSERT (tag_len <SIZE_MAX ); -if (!EVP_CIPHER_CTX_ctrl (ctx,EVP_CTRL_AEAD_SET_TAG , tag_len, tag)) +ASSERT (tag_len <INT_MAX ); +if (!EVP_CIPHER_CTX_ctrl (ctx,EVP_CTRL_AEAD_SET_TAG , (int )tag_len, tag)) {return 0 ; }
@@ -1004,10 +999,6 @@return cipher_ctx_final (ctx, dst, dst_len); } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic pop -#endif -/* * * Generic message digest information functions
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1446?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I99bc4692526f9143a913e29b266a1816295dfd51
Gerrit-Change-Number: 1446
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/1446?usp=email
to look at the new patch set (#2).
Change subject: crypto_openssl: Fix various conversion warnings
......................................................................
crypto_openssl: Fix various conversion warnings
EVP_CIPHER_CTX_flags is documented to output
int in OpenSSL, but is actually unsigned long
in OpenSSL 3.
In libressl it is correctly documented to output
unsigned long.
---
M src/openvpn/crypto_openssl.c
1 file changed, 4 insertions(+), 13 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/46/1446/2
src/openvpn/crypto_openssl.c +4 -13
@@ -896,11 +896,6 @@return EVP_CIPHER_CTX_mode (ctx); } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wconversion" -#endif -bool cipher_ctx_mode_cbc (const cipher_ctx_t *ctx) {
@@ -909,7 +904,7 @@return false; } -int flags =EVP_CIPHER_CTX_flags (ctx); +unsigned long flags =EVP_CIPHER_CTX_flags (ctx);int mode =EVP_CIPHER_CTX_mode (ctx);return mode ==EVP_CIPH_CBC_MODE
@@ -940,7 +935,7 @@ {if (ctx) { -int flags =EVP_CIPHER_CTX_flags (ctx); +unsigned long flags =EVP_CIPHER_CTX_flags (ctx);if (flags &EVP_CIPH_FLAG_AEAD_CIPHER ) {return true;
@@ -995,8 +990,8 @@cipher_ctx_final_check_tag (EVP_CIPHER_CTX *ctx, uint8_t *dst, int *dst_len, uint8_t *tag, size_t tag_len) { -ASSERT (tag_len <SIZE_MAX ); -if (!EVP_CIPHER_CTX_ctrl (ctx,EVP_CTRL_AEAD_SET_TAG , tag_len, tag)) +ASSERT (tag_len <INT_MAX ); +if (!EVP_CIPHER_CTX_ctrl (ctx,EVP_CTRL_AEAD_SET_TAG , (int )tag_len, tag)) {return 0 ; }
@@ -1004,10 +999,6 @@return cipher_ctx_final (ctx, dst, dst_len); } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic pop -#endif -/* * * Generic message digest information functions
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1446?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I99bc4692526f9143a913e29b266a1816295dfd51
Gerrit-Change-Number: 1446
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Attention is currently required from: flichtenheld, plaisthos.
cron2 has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1446?usp=email )
Change subject: crypto_openssl: Fix various conversion warnings
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1446?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I99bc4692526f9143a913e29b266a1816295dfd51
Gerrit-Change-Number: 1446
Gerrit-PatchSet: 4
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Fri, 16 Jan 2026 17:19:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
PATCH v4 1/1 crypto_openssl: Fix various conversion warnings
In reply to a message not in the archiveFrom: Frank Lichtenheld <[email protected]...>
EVP_CIPHER_CTX_flags is documented to output
int in OpenSSL, but is actually unsigned long
in OpenSSL 3.
In libressl it is correctly documented to output
unsigned long.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1446
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1446
This mail reflects revision 4 of this Change.
Acked-by according to Gerrit (reflected above):
Gert Doering <[email protected]...>
src/openvpn/crypto_openssl.c +4 -13
@@ -896,11 +896,6 @@return EVP_CIPHER_CTX_mode (ctx); } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wconversion" -#endif -bool cipher_ctx_mode_cbc (const cipher_ctx_t *ctx) {
@@ -909,7 +904,7 @@return false; } -int flags =EVP_CIPHER_CTX_flags (ctx); +unsigned long flags =EVP_CIPHER_CTX_flags (ctx);int mode =EVP_CIPHER_CTX_mode (ctx);return mode ==EVP_CIPH_CBC_MODE
@@ -940,7 +935,7 @@ {if (ctx) { -int flags =EVP_CIPHER_CTX_flags (ctx); +unsigned long flags =EVP_CIPHER_CTX_flags (ctx);if (flags &EVP_CIPH_FLAG_AEAD_CIPHER ) {return true;
@@ -995,8 +990,8 @@cipher_ctx_final_check_tag (EVP_CIPHER_CTX *ctx, uint8_t *dst, int *dst_len, uint8_t *tag, size_t tag_len) { -ASSERT (tag_len <SIZE_MAX ); -if (!EVP_CIPHER_CTX_ctrl (ctx,EVP_CTRL_AEAD_SET_TAG , tag_len, tag)) +ASSERT (tag_len <INT_MAX ); +if (!EVP_CIPHER_CTX_ctrl (ctx,EVP_CTRL_AEAD_SET_TAG , (int )tag_len, tag)) {return 0 ; }
@@ -1004,10 +999,6 @@return cipher_ctx_final (ctx, dst, dst_len); } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic pop -#endif -/* * * Generic message digest information functions
[Openvpn-devel] [PATCH applied] Re: crypto_openssl: Fix various conversion warnings
Straightforward, and one #pragma set gone...
Your patch has been applied to the master branch.
commit 07fc73025b8679540c9964853e9ca47ff385abc8
Author: Frank Lichtenheld Date: Fri Jan 16 18:19:42 2026 +0100
crypto_openssl: Fix various conversion warnings
Signed-off-by: Frank Lichtenheld <[email protected]...>
Acked-by: Gert Doering <[email protected]...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1446
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg35311.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
cron2 has uploaded a new patch set (#5) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1446?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by cron2
Change subject: crypto_openssl: Fix various conversion warnings
......................................................................
crypto_openssl: Fix various conversion warnings
EVP_CIPHER_CTX_flags is documented to output
int in OpenSSL, but is actually unsigned long
in OpenSSL 3.
In libressl it is correctly documented to output
unsigned long.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1446
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg35311.html
---
M src/openvpn/crypto_openssl.c
1 file changed, 4 insertions(+), 13 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/46/1446/5
src/openvpn/crypto_openssl.c +4 -13
@@ -896,11 +896,6 @@return EVP_CIPHER_CTX_mode (ctx); } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wconversion" -#endif -bool cipher_ctx_mode_cbc (const cipher_ctx_t *ctx) {
@@ -909,7 +904,7 @@return false; } -int flags =EVP_CIPHER_CTX_flags (ctx); +unsigned long flags =EVP_CIPHER_CTX_flags (ctx);int mode =EVP_CIPHER_CTX_mode (ctx);return mode ==EVP_CIPH_CBC_MODE
@@ -940,7 +935,7 @@ {if (ctx) { -int flags =EVP_CIPHER_CTX_flags (ctx); +unsigned long flags =EVP_CIPHER_CTX_flags (ctx);if (flags &EVP_CIPH_FLAG_AEAD_CIPHER ) {return true;
@@ -995,8 +990,8 @@cipher_ctx_final_check_tag (EVP_CIPHER_CTX *ctx, uint8_t *dst, int *dst_len, uint8_t *tag, size_t tag_len) { -ASSERT (tag_len <SIZE_MAX ); -if (!EVP_CIPHER_CTX_ctrl (ctx,EVP_CTRL_AEAD_SET_TAG , tag_len, tag)) +ASSERT (tag_len <INT_MAX ); +if (!EVP_CIPHER_CTX_ctrl (ctx,EVP_CTRL_AEAD_SET_TAG , (int )tag_len, tag)) {return 0 ; }
@@ -1004,10 +999,6 @@return cipher_ctx_final (ctx, dst, dst_len); } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic pop -#endif -/* * * Generic message digest information functions
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1446?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I99bc4692526f9143a913e29b266a1816295dfd51
Gerrit-Change-Number: 1446
Gerrit-PatchSet: 5
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1446?usp=email )
Change subject: crypto_openssl: Fix various conversion warnings
......................................................................
crypto_openssl: Fix various conversion warnings
EVP_CIPHER_CTX_flags is documented to output
int in OpenSSL, but is actually unsigned long
in OpenSSL 3.
In libressl it is correctly documented to output
unsigned long.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1446
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg35311.html
---
M src/openvpn/crypto_openssl.c
1 file changed, 4 insertions(+), 13 deletions(-)
src/openvpn/crypto_openssl.c +4 -13
@@ -896,11 +896,6 @@return EVP_CIPHER_CTX_mode (ctx); } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wconversion" -#endif -bool cipher_ctx_mode_cbc (const cipher_ctx_t *ctx) {
@@ -909,7 +904,7 @@return false; } -int flags =EVP_CIPHER_CTX_flags (ctx); +unsigned long flags =EVP_CIPHER_CTX_flags (ctx);int mode =EVP_CIPHER_CTX_mode (ctx);return mode ==EVP_CIPH_CBC_MODE
@@ -940,7 +935,7 @@ {if (ctx) { -int flags =EVP_CIPHER_CTX_flags (ctx); +unsigned long flags =EVP_CIPHER_CTX_flags (ctx);if (flags &EVP_CIPH_FLAG_AEAD_CIPHER ) {return true;
@@ -995,8 +990,8 @@cipher_ctx_final_check_tag (EVP_CIPHER_CTX *ctx, uint8_t *dst, int *dst_len, uint8_t *tag, size_t tag_len) { -ASSERT (tag_len <SIZE_MAX ); -if (!EVP_CIPHER_CTX_ctrl (ctx,EVP_CTRL_AEAD_SET_TAG , tag_len, tag)) +ASSERT (tag_len <INT_MAX ); +if (!EVP_CIPHER_CTX_ctrl (ctx,EVP_CTRL_AEAD_SET_TAG , (int )tag_len, tag)) {return 0 ; }
@@ -1004,10 +999,6 @@return cipher_ctx_final (ctx, dst, dst_len); } -#if defined(__GNUC__) || defined(__clang__) -#pragma GCC diagnostic pop -#endif -/* * * Generic message digest information functions
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1446?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I99bc4692526f9143a913e29b266a1816295dfd51
Gerrit-Change-Number: 1446
Gerrit-PatchSet: 5
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>