power: supply: qcom_battmgr: Recognize "LiP" as lithium-polymer
Subsystems (2)
PATCH 1/1 power: supply: qcom_battmgr: Recognize "LiP" as lithium-polymer
On the Dell Latitude 7455, the firmware uses "LiP" with a lowercase 'i' for the battery chemistry type, but only all-uppercase "LIP" was being recognized. Add the CamelCase variant to the check to fix the "Unknown battery technology" warning.
--- drivers/power/supply/qcom_battmgr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/power/supply/qcom_battmgr.c +2 -1
@@ -1240,7 +1240,8 @@ static unsigned int qcom_battmgr_sc8280xp_parse_technology(const char *chemistryif ((!strncmp (chemistry,"LIO" ,BATTMGR_CHEMISTRY_LEN )) || (!strncmp (chemistry,"OOI" ,BATTMGR_CHEMISTRY_LEN )))return POWER_SUPPLY_TECHNOLOGY_LION ; -if (!strncmp (chemistry,"LIP" ,BATTMGR_CHEMISTRY_LEN )) +if (!strncmp (chemistry,"LIP" ,BATTMGR_CHEMISTRY_LEN ) || + (!strncmp (chemistry,"LiP" ,BATTMGR_CHEMISTRY_LEN )))return POWER_SUPPLY_TECHNOLOGY_LIPO ;pr_err ("Unknown battery technology '%s'\n" , chemistry);
Signature · 1 line
2.51.2
Quoted 16 lines · Val Packett
On the Dell Latitude 7455, the firmware uses "LiP" with a lowercase 'i' for the battery chemistry type, but only all-uppercase "LIP" was being recognized. Add the CamelCase variant to the check to fix the "Unknown battery technology" warning.
Fixes 202ac22b8e2e ("power: supply: qcom_battmgr: Add lithium-polymer entry")Signed-off-by Val Packett <[email protected]>--- drivers/power/supply/qcom_battmgr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/power/supply/qcom_battmgr.c +0
-0
drivers/power/supply/qcom_battmgr.c static unsigned int qcom_battmgr_sc8280xp_parse_technology(const char *chemistry · line 1244
Quoted 6 lines
drivers/power/supply/qcom_battmgr.c +2
-1@@ -1240,7 +1240,8 @@ static unsigned int qcom_battmgr_sc8280xp_parse_technology(const char *chemistryif ((!strncmp (chemistry,"LIO" ,BATTMGR_CHEMISTRY_LEN )) || (!strncmp (chemistry,"OOI" ,BATTMGR_CHEMISTRY_LEN )))return POWER_SUPPLY_TECHNOLOGY_LION ; -if (!strncmp (chemistry,"LIP" ,BATTMGR_CHEMISTRY_LEN )) +if (!strncmp (chemistry,"LIP" ,BATTMGR_CHEMISTRY_LEN ) || + (!strncmp (chemistry,"LiP" ,BATTMGR_CHEMISTRY_LEN )))
Why do you have extra brackets around the second strncmp?
Quoted 6 lines
drivers/power/supply/qcom_battmgr.c +0
-0return POWER_SUPPLY_TECHNOLOGY_LIPO ;pr_err ("Unknown battery technology '%s'\n" , chemistry);Signature · 1 line
2.51.2
Signature · 2 lines
With best wishes Dmitry
Quoted 12 lines · Dmitry Baryshkov
Quoted 11 lines · Val Packett
On the Dell Latitude 7455, the firmware uses "LiP" with a lowercase 'i' for the battery chemistry type, but only all-uppercase "LIP" was being recognized. Add the CamelCase variant to the check to fix the "Unknown battery technology" warning.
Fixes 202ac22b8e2e ("power: supply: qcom_battmgr: Add lithium-polymer entry")Signed-off-by Val Packett <[email protected]>--- drivers/power/supply/qcom_battmgr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 12 lines
drivers/power/supply/qcom_battmgr.c static unsigned int qcom_battmgr_sc8280xp_parse_technology(const char *chemistry · line 1244
Quoted 11 lines
drivers/power/supply/qcom_battmgr.c +2
-1@@ -1240,7 +1240,8 @@ static unsigned int qcom_battmgr_sc8280xp_parse_technology(const char *chemistryif ((!strncmp (chemistry,"LIO" ,BATTMGR_CHEMISTRY_LEN )) || (!strncmp (chemistry,"OOI" ,BATTMGR_CHEMISTRY_LEN )))return POWER_SUPPLY_TECHNOLOGY_LION ; -if (!strncmp (chemistry,"LIP" ,BATTMGR_CHEMISTRY_LEN )) +if (!strncmp (chemistry,"LIP" ,BATTMGR_CHEMISTRY_LEN ) || + (!strncmp (chemistry,"LiP" ,BATTMGR_CHEMISTRY_LEN )))Why do you have extra brackets around the second strncmp?
Copy-pasted from the line above (the "OOI" one) :) Didn't see that the first one in this expression doesn't have them.
Feel free to edit this when applying
~val
Quoted 27 lines · Val Packett
Quoted 12 lines · Dmitry Baryshkov
Quoted 11 lines · Val Packett
On the Dell Latitude 7455, the firmware uses "LiP" with a lowercase 'i' for the battery chemistry type, but only all-uppercase "LIP" was being recognized. Add the CamelCase variant to the check to fix the "Unknown battery technology" warning.
Fixes 202ac22b8e2e ("power: supply: qcom_battmgr: Add lithium-polymer entry")Signed-off-by Val Packett <[email protected]>--- drivers/power/supply/qcom_battmgr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)Quoted 12 lines
drivers/power/supply/qcom_battmgr.c static unsigned int qcom_battmgr_sc8280xp_parse_technology(const char *chemistry · line 1244
Quoted 11 lines
drivers/power/supply/qcom_battmgr.c +2
-1@@ -1240,7 +1240,8 @@ static unsigned int qcom_battmgr_sc8280xp_parse_technology(const char *chemistryif ((!strncmp (chemistry,"LIO" ,BATTMGR_CHEMISTRY_LEN )) || (!strncmp (chemistry,"OOI" ,BATTMGR_CHEMISTRY_LEN )))return POWER_SUPPLY_TECHNOLOGY_LION ; -if (!strncmp (chemistry,"LIP" ,BATTMGR_CHEMISTRY_LEN )) +if (!strncmp (chemistry,"LIP" ,BATTMGR_CHEMISTRY_LEN ) || + (!strncmp (chemistry,"LiP" ,BATTMGR_CHEMISTRY_LEN )))Why do you have extra brackets around the second strncmp?
Quoted 4 lines
Copy-pasted from the line above (the "OOI" one) :) Didn't see that the first one in this expression doesn't have them.
Feel free to edit this when applying
It depends on Sebastian, but I'd kindly suggest sending v2.
Signature · 2 lines
With best wishes Dmitry