Skip to contentSkip to conversation

Fix imx258 variant on pinephone pro

PATCH Applied Luis Garcia 3 participants 7 messages Jan 18 – Jan 21

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover Fix imx258 variant on pinephone pro

imx258 had the driver updated a while back and it introduced two variants, the imx258 and imx258-pdaf. The pinephone pro is using the pdaf variant so this switches it to the correct variant and eliminates the pdaf pixels from the sensor output resulting in a much cleaner image.

Luis Garcia (1):
arm64: dts: rockchip: Fix imx258 variant on pinephone pro

 arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 7 lines
2.50.1


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
#1 lore raw

PATCH 1/1 arm64: dts: rockchip: Fix imx258 variant on pinephone pro

Fix the variant of the imx258 camera sensor on the pinephone pro

---
 arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts +1 -1
index 2dca1dca20b8..fd6facf1da2b 100644
@@ -451,7 +451,7 @@ &i2c1 {
 	status = "okay";
 
 	wcam: camera@1a {
-		compatible = "sony,imx258";
+		compatible = "sony,imx258-pdaf";
 		reg = <0x1a>;
 		clocks = <&cru SCLK_CIF_OUT>; /* MIPI_MCLK0, derived from CIF_CLKO */
 		lens-focus = <&wcam_lens>;
Signature · 7 lines
2.50.1


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
#2 lore raw
In reply to Luis Garcia

Hi Luis,

Quoted 5 lines · Luis Garcia

imx258 had the driver updated a while back and it introduced two variants, the imx258 and imx258-pdaf. The pinephone pro is using the pdaf variant so this switches it to the correct variant and eliminates the pdaf pixels from the sensor output resulting in a much cleaner image.

You don't need a cover letter for a single patch. Also this description should be in the patch itself.

Thank you,

	o.
Quoted 9 lines

Luis Garcia (1):
arm64: dts: rockchip: Fix imx258 variant on pinephone pro

 arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
2.50.1
#3 lore raw

PATCH v2 1/1 arm64: dts: rockchip: Fix imx258 variant on pinephone pro

In reply to Luis Garcia

imx258 had the driver updated a while back and it introduced two variants, the imx258 and imx258-pdaf. The pinephone pro is using the pdaf variant so this switches it to the correct variant and eliminates the pdaf pixels from the sensor output resulting in a much cleaner image.

---
 arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts +1 -1
index 2dca1dca20b8..fd6facf1da2b 100644
@@ -451,7 +451,7 @@ &i2c1 {
 	status = "okay";
 
 	wcam: camera@1a {
-		compatible = "sony,imx258";
+		compatible = "sony,imx258-pdaf";
 		reg = <0x1a>;
 		clocks = <&cru SCLK_CIF_OUT>; /* MIPI_MCLK0, derived from CIF_CLKO */
 		lens-focus = <&wcam_lens>;
Signature · 1 line
2.50.1
maintainer Applied
#4 lore raw
In reply to Luis Garcia
Quoted 10 lines · Luis Garcia

imx258 had the driver updated a while back and it introduced two variants, the imx258 and imx258-pdaf. The pinephone pro is using the pdaf variant so this switches it to the correct variant and eliminates the pdaf pixels from the sensor output resulting in a much cleaner image.

Luis Garcia (1):
arm64: dts: rockchip: Fix imx258 variant on pinephone pro

[...]

Applied, thanks!

[1/1] arm64: dts: rockchip: Fix imx258 variant on pinephone pro

      commit: 6742b998166485558ccb0e89b5d5fd93c1aae3ca

In the future, please don't send v2 patches as replies to the previous version and instead start a new thread.

Next versions as replies, does sometimes confusing tooling.

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>
#5 lore raw

Thank you very much for the speedy turn around. Ohh

interesting, here i was thinking i did the right thing with

the reply to with the V2. Ill keep that in mind for the

future but considering how far and few my contributions

upstream are i hope i dont forget by then lol.

Quoted 23 lines · Heiko Stuebner
Quoted 10 lines · Luis Garcia

imx258 had the driver updated a while back and it introduced two variants, the imx258 and imx258-pdaf. The pinephone pro is using the pdaf variant so this switches it to the correct variant and eliminates the pdaf pixels from the sensor output resulting in a much cleaner image.

Luis Garcia (1):
arm64: dts: rockchip: Fix imx258 variant on pinephone pro

[...]

Applied, thanks!

[1/1] arm64: dts: rockchip: Fix imx258 variant on pinephone pro

       commit: 6742b998166485558ccb0e89b5d5fd93c1aae3ca

In the future, please don't send v2 patches as replies to the previous version and instead start a new thread.

Next versions as replies, does sometimes confusing tooling.

Best regards,

maintainer
#6 lore raw

Hi,

Am Dienstag, 20. Januar 2026, 17:33:37 Mitteleuropäische Normalzeit schrieb Luis Garcia:

Quoted 5 lines

Thank you very much for the speedy turn around. Ohh interesting, here i was thinking i did the right thing with the reply to with the V2. Ill keep that in mind for the future but considering how far and few my contributions upstream are i hope i dont forget by then lol.

no worries. For individual patches this is mostly easy to figure out and also recent versions of b4 handled this thread fine.

I think it's more a problem, once the thread goes deeper or multiple patches are involved.

Heiko

Quoted 25 lines · Heiko Stuebner
Quoted 23 lines · Luis Garcia
Quoted 10 lines

imx258 had the driver updated a while back and it introduced two variants, the imx258 and imx258-pdaf. The pinephone pro is using the pdaf variant so this switches it to the correct variant and eliminates the pdaf pixels from the sensor output resulting in a much cleaner image.

Luis Garcia (1):
arm64: dts: rockchip: Fix imx258 variant on pinephone pro

[...]

Applied, thanks!

[1/1] arm64: dts: rockchip: Fix imx258 variant on pinephone pro

       commit: 6742b998166485558ccb0e89b5d5fd93c1aae3ca

In the future, please don't send v2 patches as replies to the previous version and instead start a new thread.

Next versions as replies, does sometimes confusing tooling.

Best regards,