Skip to contentSkip to conversation

driver-core: move devres_for_each_res() to base.h

PATCH In review Danilo Krummrich 2 participants 3 messages Jan 19 – Jan 23 Driver core

lore
Share & tools
lore

Danilo Krummrich

author maintainer
#0 lore raw

PATCH 1/1 driver-core: move devres_for_each_res() to base.h

devres_for_each_res() is only used by .../firmware_loader/main.c, which already includes base.h.

The usage of devres_for_each_res() by code outside of driver-core is questionable, hence move it to base.h.

---
 drivers/base/base.h           | 4 ++++
 include/linux/device/devres.h | 4 ----
 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/base/base.h +4 -0
index 430cbefbc97f..60ee4d466b29 100644
@@ -213,6 +213,10 @@ static inline void device_set_driver(struct device *dev, const struct device_dri
 	WRITE_ONCE(dev->driver, (struct device_driver *)drv);
 }
 
+void devres_for_each_res(struct device *dev, dr_release_t release,
+			 dr_match_t match, void *match_data,
+			 void (*fn)(struct device *, void *, void *),
+			 void *data);
 int devres_release_all(struct device *dev);
 void device_block_probing(void);
 void device_unblock_probing(void);
include/linux/device/devres.h +0 -4
index 9c1e3d643d69..14ab9159bdda 100644
@@ -26,10 +26,6 @@ __devres_alloc_node(dr_release_t release, size_t size, gfp_t gfp, int nid, const
 #define devres_alloc_node(release, size, gfp, nid) \
 	__devres_alloc_node(release, size, gfp, nid, #release)
 
-void devres_for_each_res(struct device *dev, dr_release_t release,
-			 dr_match_t match, void *match_data,
-			 void (*fn)(struct device *, void *, void *),
-			 void *data);
 void devres_free(void *res);
 void devres_add(struct device *dev, void *res);
 void *devres_find(struct device *dev, dr_release_t release, dr_match_t match, void *match_data);

base-commit: 744905705113a6ab4c38127f18cc0d71594cfaec

Signature · 1 line
2.52.0
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Danilo Krummrich

devres_for_each_res() is only used by .../firmware_loader/main.c, which already includes base.h.

The usage of devres_for_each_res() by code outside of driver-core is questionable, hence move it to base.h.

---
 drivers/base/base.h           | 4 ++++
 include/linux/device/devres.h | 4 ----
 2 files changed, 4 insertions(+), 4 deletions(-)