net: add kdoc for napi_consume_skb()
Subsystems (2)
Jakub Kicinski
maintainerPATCH 1/1 net: add kdoc for napi_consume_skb()
Looks like AI reviewers miss that napi_consume_skb() must have a real budget passed to it. Let's see if adding a real kdoc will help them figure this out.
---
CC: [email protected]
--- net/core/skbuff.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
net/core/skbuff.c +12 -1
@@ -1499,9 +1499,20 @@ void napi_skb_free_stolen_head(struct sk_buff *skb)napi_skb_cache_put (skb); } +/** +* napi_consume_skb() - consume skb in NAPI context, try to feed skb cache +* @skb: buffer to free +* @budget: NAPI budget +* +* Non-zero @budget must come from the @budget argument passed by the core +* to a NAPI poll function. Note that core may pass budget of 0 to NAPI poll +* for example when polling for netpoll / netconsole. +* +* Passing @budget of 0 is safe from any context, it turns this function +* into dev_consume_skb_any(). +*/ void napi_consume_skb (struct sk_buff *skb,int budget) { -/* Zero budget indicate non-NAPI context called us, like netpoll */ if (unlikely (!budget || !skb)) {dev_consume_skb_any (skb);return ;
Signature · 1 line
2.52.0
Quoted 6 lines · Jakub Kicinski
Looks like AI reviewers miss that
napi_consume_skb()must have a real budget passed to it. Let's see if adding a real kdoc will help them figure this out.Signed-off-by Jakub Kicinski <[email protected]>
It does make sense if we add more useful comments like this to help AI review examine the patches on the mailing list.
Thanks,
Jason
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Mon, 19 Jan 2026 14:41:40 -0800 you wrote:
Looks like AI reviewers miss that
napi_consume_skb()must have a real budget passed to it. Let's see if adding a real kdoc will help them figure this out.Signed-off-by Jakub Kicinski <[email protected]>---
CC: [email protected][...]
Here is the summary with links:
- [net-next] net: add kdoc for napi_consume_skb()
https://git.kernel.org/netdev/net-next/c/cd18e8ac030e
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html