Skip to contentSkip to conversation

package/mpd: fix shellcheck warnings

PATCH In review Andreas Ziegler 2 participants 2 messages Jan 20

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/mpd: fix shellcheck warnings

Shellcheck commit 4f81dbe [1] added SC2329 (function is never invoked) and fixed SC2317 (Command appears to be unreachable).

[1] https://github.com/koalaman/shellcheck/commit/4f81dbe839091a06a5cfaea695cf1c451ff07565

$ shellcheck package/mpd/S95mpd

In package/mpd/S95mpd line 13:
start() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).

Change shellcheck exception number in header of S95mpd.

---
 package/mpd/S95mpd | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/mpd/S95mpd +1 -1
index ac971e04a2..481ee70a20 100644
@@ -2,7 +2,7 @@
 #
 # S95mpd	Starts Music Player daemon.
 #
-# shellcheck disable=SC2317 # functions are called via variable
+# shellcheck disable=SC2329 # functions are called via variable
 
 DAEMON="mpd"
 PIDFILE="/var/run/$DAEMON.pid"
Signature · 6 lines
2.51.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Reviewed-by J. Neuschäfer on v1 1/1
#1 lore raw
Quoted 7 lines · Andreas Ziegler

Shellcheck commit 4f81dbe [1] added SC2329 (function is never invoked) and fixed SC2317 (Command appears to be unreachable).

[1] https://github.com/koalaman/shellcheck/commit/4f81dbe839091a06a5cfaea695cf1c451ff07565

$ shellcheck package/mpd/S95mpd
Quoted 8 lines

In package/mpd/S95mpd line 13:
start() {
^-- SC2329 (info): This function is never invoked. Check usage (or ignored if invoked indirectly).

Change shellcheck exception number in header of S95mpd.

---

Looks good,

Thanks!

Quoted 23 lines
 package/mpd/S95mpd | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/mpd/S95mpd +1 -1
index ac971e04a2..481ee70a20 100644
@@ -2,7 +2,7 @@
 #
 # S95mpd	Starts Music Player daemon.
 #
-# shellcheck disable=SC2317 # functions are called via variable
+# shellcheck disable=SC2329 # functions are called via variable
 
 DAEMON="mpd"
 PIDFILE="/var/run/$DAEMON.pid"
Signature · 6 lines
2.51.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot