Skip to contentSkip to conversation

once-dont-use-a-work-queue-to-reset-sleepable-static-key.patch removed from -mm tree

merged mm-nonmm-stable Andrew Morton 1 participant 1 message Jan 21

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: once: don't use a work queue to reset sleepable static key
has been removed from the -mm tree. Its filename was
once-dont-use-a-work-queue-to-reset-sleepable-static-key.patch

This patch was dropped because it was merged into the mm-nonmm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: "Luck, Tony" <[email protected]>
Subject: once: don't use a work queue to reset sleepable static key
Date: Mon, 12 Jan 2026 10:08:53 -0800

Pointless overhead to use a work queue to reset the static key for a DO_ONCE_SLEEPABLE() invocation.

Note that the previous code path included a BUG_ON() if the static key was already disabled. Dropped that as part of this change because:
1) Use of BUG_ON() is highly discouraged.
2) There is a WARN_ON() in the static_branch_disable() code path that would provide adequate breadcrumbs to debug any issue.

---

 lib/once.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/once.c renamed from lib/once.c~once-dont-use-a-work-queue-to-reset-sleepable-static-key +1 -1
@@ -93,6 +93,6 @@ void __do_once_sleepable_done(bool *done
 {
 	*done = true;
 	mutex_unlock(&once_mutex);
-	once_disable_jump(once_key, mod);
+	static_branch_disable(once_key);
 }
 EXPORT_SYMBOL(__do_once_sleepable_done);

_

Patches currently in -mm which might be from [email protected] are