Skip to contentSkip to conversation

media: i2c: imx290: Adjust initialization registers for IMX327 sensor

PATCH In review Alexander Shiyan 2 participants 2 messages Jan 21

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: i2c: imx290: Adjust initialization registers for IMX327 sensor

This patch updates the global initialization sequence for the IMX327 sensor to match the recommended values from the IMX327LQR-C Rev0.2 datasheet.

Additionally, hexadecimal literals for registers 0x309e and 0x309f are changed to lowercase to maintain consistency with the rest of the driver code.

Fixes f2055c1d62d6 ("media: i2c: imx290: Register 0x3011 varies between imx327 and imx290")
---
 drivers/media/i2c/imx290.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/media/i2c/imx290.c +5 -4
index 9eca7f9db97d..da8966f0b243 100644
@@ -375,10 +375,11 @@ static const struct cci_reg_sequence xclk_regs[][IMX290_NUM_CLK_REGS] = {
 };
 
 static const struct cci_reg_sequence imx290_global_init_settings_327[] = {
-	{ CCI_REG8(0x3011), 0x02 },
-	{ CCI_REG8(0x309e), 0x4A },
-	{ CCI_REG8(0x309f), 0x4A },
-	{ CCI_REG8(0x313b), 0x61 },
+	{ CCI_REG8(0x3011), 0x0a },
+	{ CCI_REG8(0x309e), 0x4a },
+	{ CCI_REG8(0x309f), 0x4a },
+	{ CCI_REG8(0x3128), 0x04 },
+	{ CCI_REG8(0x313b), 0x41 },
 };
 
 static const struct cci_reg_sequence imx290_1080p_settings[] = {
Signature · 1 line
2.52.0
#1 lore raw

Hi Alexander

Quoted 3 lines · Alexander Shiyan

This patch updates the global initialization sequence for the IMX327 sensor to match the recommended values from the IMX327LQR-C Rev0.2 datasheet.

Rev 0.2 is dated 2017/05/25.
I have E17Z06B93 dated 2019/03/25 direct from our Sony contact.

Quoted 14 lines

Additionally, hexadecimal literals for registers 0x309e and 0x309f are changed to lowercase to maintain consistency with the rest of the driver code.

Fixes f2055c1d62d6 ("media: i2c: imx290: Register 0x3011 varies between imx327 and imx290")
---
 drivers/media/i2c/imx290.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/media/i2c/imx290.c +0 -0
index 9eca7f9db97d..da8966f0b243 100644

drivers/media/i2c/imx290.c static const struct cci_reg_sequence xclk_regs[][IMX290_NUM_CLK_REGS] = { · line 378

Quoted 4 lines
drivers/media/i2c/imx290.c +0 -1
@@ -375,10 +375,11 @@ static const struct cci_reg_sequence xclk_regs[][IMX290_NUM_CLK_REGS] = {
 };
 
 static const struct cci_reg_sequence imx290_global_init_settings_327[] = {
-       { CCI_REG8(0x3011), 0x02 },

Change in datasheet rev 0.3. "Correction: Register 3011h setting 0Ah -> 02h"

drivers/media/i2c/imx290.c static const struct cci_reg_sequence xclk_regs[][IMX290_NUM_CLK_REGS] = { · line 379

Quoted 1 line
drivers/media/i2c/imx290.c +0 -1
-       { CCI_REG8(0x309e), 0x4A },

Not listed in the change log, but highlighted in red as "set to 4Ah"

drivers/media/i2c/imx290.c static const struct cci_reg_sequence xclk_regs[][IMX290_NUM_CLK_REGS] = { · line 380

Quoted 1 line
drivers/media/i2c/imx290.c +0 -1
-       { CCI_REG8(0x309f), 0x4A },

Ditto.

drivers/media/i2c/imx290.c static const struct cci_reg_sequence xclk_regs[][IMX290_NUM_CLK_REGS] = { · line 381

Quoted 1 line
drivers/media/i2c/imx290.c +0 -1
-       { CCI_REG8(0x313b), 0x61 },

Change in datasheet rev 0.3. "Correction: Register 313bh setting 41h -> 61h"

So I'm afraid your datasheet is out of date on all of these.

Dave

Quoted 11 lines
drivers/media/i2c/imx290.c +5 -1
+       { CCI_REG8(0x3011), 0x0a },
+       { CCI_REG8(0x309e), 0x4a },
+       { CCI_REG8(0x309f), 0x4a },
+       { CCI_REG8(0x3128), 0x04 },
+       { CCI_REG8(0x313b), 0x41 },
 };
 
 static const struct cci_reg_sequence imx290_1080p_settings[] = {
--

2.52.0