Skip to contentSkip to conversation

drm/nouveau/disp: Set drm_mode_config_funcs.atomic_(check|commit)

PATCH In review Lyude Paul 2 participants 2 messages Jan 21

Subsystems (4)
Stable branch DRM drivers DRM misc nouveau
lore
Share & tools
lore

Lyude Paul

author maintainer
#0 lore raw

PATCH 1/1 drm/nouveau/disp: Set drm_mode_config_funcs.atomic_(check|commit)

Apparently we never actually filled these in, despite the fact that we do in fact technically support atomic modesetting.

Since not having these filled in causes us to potentially forget to disable fbdev and friends during suspend/resume, let's fix it.

Signed-off-by Lyude Paul <[email protected]>
Cc [email protected]
---
 drivers/gpu/drm/nouveau/nouveau_display.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/nouveau/nouveau_display.c +2 -0
index 00515623a2cc7..829c2b573971c 100644
@@ -352,6 +352,8 @@ nouveau_user_framebuffer_create(struct drm_device *dev,
 
 static const struct drm_mode_config_funcs nouveau_mode_config_funcs = {
 	.fb_create = nouveau_user_framebuffer_create,
+	.atomic_commit = drm_atomic_helper_commit,
+	.atomic_check = drm_atomic_helper_check,
 };

base-commit: 68b271a3a94cfd6c7695a96b6398b52feb89e2c2

Signature · 1 line
2.52.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Lyude Paul

Apparently we never actually filled these in, despite the fact that we do in fact technically support atomic modesetting.

Since not having these filled in causes us to potentially forget to disable fbdev and friends during suspend/resume, let's fix it.

Signed-off-by Lyude Paul <[email protected]>
Reviewed-by Dave Airlie <[email protected]>
Quoted 23 lines
Cc [email protected]
---
 drivers/gpu/drm/nouveau/nouveau_display.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/nouveau/nouveau_display.c +2 -0
index 00515623a2cc7..829c2b573971c 100644
@@ -352,6 +352,8 @@ nouveau_user_framebuffer_create(struct drm_device *dev,
 
 static const struct drm_mode_config_funcs nouveau_mode_config_funcs = {
        .fb_create = nouveau_user_framebuffer_create,
+       .atomic_commit = drm_atomic_helper_commit,
+       .atomic_check = drm_atomic_helper_check,
 };

base-commit: 68b271a3a94cfd6c7695a96b6398b52feb89e2c2 --
2.52.0