Bluetooth: L2CAP: Fix not tracking outstanding TX ident
Subsystems (2)
Luiz Augusto von Dentz
maintainerPATCH v2 1/1 Bluetooth: L2CAP: Fix not tracking outstanding TX ident
From: Luiz Augusto von Dentz <[email protected]>
This attempts to proper track outstanding request by using struct ida and allocating from it in l2cap_get_ident using ida_alloc_range which would reuse ids as they are free, then upon completion release the id using ida_free.
--- include/net/bluetooth/l2cap.h | 3 +-- net/bluetooth/l2cap_core.c | 46 ++++++++++++++++++++++++----------- 2 files changed, 33 insertions(+), 16 deletions(-)
include/net/bluetooth/l2cap.h +1 -2
@@ -655,8 +655,7 @@ struct l2cap_conn {struct sk_buff *rx_skb;__u32 rx_len; -__u8 tx_ident; -struct mutex ident_lock; +struct ida tx_ida;struct sk_buff_head pending_rx;struct work_struct pending_rx_work;
net/bluetooth/l2cap_core.c +32 -14
95 lines not on this page · raw message
Signature · 1 line
2.52.0
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1045342
---Test result---
Test Summary:
CheckPatch PENDING 0.54 seconds GitLint PENDING 0.32 seconds SubjectPrefix PASS 0.07 seconds BuildKernel PASS 25.25 seconds CheckAllWarning PASS 27.92 seconds CheckSparse PASS 31.15 seconds BuildKernel32 PASS 25.09 seconds TestRunnerSetup PASS 550.94 seconds TestRunner_l2cap-tester PASS 28.16 seconds TestRunner_iso-tester PASS 81.93 seconds TestRunner_bnep-tester PASS 6.17 seconds TestRunner_mgmt-tester FAIL 117.32 seconds TestRunner_rfcomm-tester PASS 9.46 seconds TestRunner_sco-tester FAIL 14.54 seconds TestRunner_ioctl-tester PASS 10.15 seconds TestRunner_mesh-tester FAIL 11.58 seconds TestRunner_smp-tester PASS 8.53 seconds TestRunner_userchan-tester PASS 6.52 seconds IncrementalBuild PENDING 1.09 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner Output:
Total: 494, Passed: 488 (98.8%), Failed: 2, Not Run: 4
Failed Test Cases
Read Exp Feature - Success Failed 0.108 seconds LL Privacy - Start Discovery 2 (Disable RL) Failed 0.187 seconds
##############################
Test: TestRunner_sco-tester - FAIL
Desc: Run sco-tester with test-runner
Output:
WARNING: possible circular locking dependency detected
BUG: sleeping function called from invalid context at net/core/sock.c:3782
Total: 30, Passed: 30 (100.0%), Failed: 0, Not Run: 0
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner Output:
Total: 10, Passed: 8 (80.0%), Failed: 2, Not Run: 0
Failed Test Cases
Mesh - Send cancel - 1 Timed out 1.837 seconds Mesh - Send cancel - 2 Timed out 1.997 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:
---
Regards,
Linux Bluetooth