Skip to contentSkip to conversation

dt-bindings: mtd: st,spear600-smi: convert to DT schema

PATCH Applied Akhila YS 4 participants 8 messages Jan 22 – Feb 26

Subsystems (2)

v1 of 2 Applied Latest is v2 →

lore
Share & tools
lore

Akhila YS

author
#0 lore raw

PATCH 1/1 dt-bindings: mtd: st,spear600-smi: convert to DT schema

Convert STMicroelectronics SPEAr600 Serial Memory Interface (SMI) Controller binding to YAML format.

---
 .../devicetree/bindings/mtd/spear_smi.txt          | 29 ---------
 .../devicetree/bindings/mtd/st,spear600-smi.yaml   | 72 ++++++++++++++++++++++
 2 files changed, 72 insertions(+), 29 deletions(-)
Documentation/devicetree/bindings/mtd/spear_smi.txt deleted +0 -29
deleted file mode 100644
index c41873e92d26..000000000000
@@ -1,29 +0,0 @@
-* SPEAr SMI
-
-Required properties:
-- compatible : "st,spear600-smi"
-- reg : Address range of the mtd chip
-- #address-cells, #size-cells : Must be present if the device has sub-nodes
-  representing partitions.
-- interrupts: Should contain the STMMAC interrupts
-- clock-rate : Functional clock rate of SMI in Hz
-
-Optional properties:
-- st,smi-fast-mode : Flash supports read in fast mode
-
-Example:
-
-	smi: flash@fc000000 {
-		compatible = "st,spear600-smi";
-		#address-cells = <1>;
-		#size-cells = <1>;
-		reg = <0xfc000000 0x1000>;
-		interrupt-parent = <&vic1>;
-		interrupts = <12>;
-		clock-rate = <50000000>;	/* 50MHz */
-
-		flash@f8000000 {
-			st,smi-fast-mode;
-			...
-		};
-	};
Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml new file +72 -0

72 lines not on this page · raw message

---
base-commit: cc3aa43b44bdb43dfbac0fcb51c56594a11338a8
change-id: 20260122-spear-e599dc4e7e32

Best regards,

Signature · 1 line
Akhila YS <[email protected]>
maintainer Applied
#2 lore raw
In reply to Akhila YS
Quoted 4 lines · Akhila YS

Convert STMicroelectronics SPEAr600 Serial Memory Interface (SMI) Controller binding to YAML format.

Applied to mtd/next, thanks!

[1/1] dt-bindings: mtd: st,spear600-smi: convert to DT schema

      commit: 68cd8ef484521a01826735518f173c4ae3900eff

Patche(s) should be available on mtd/linux.git and will be part of the next PR (provided that no robot complains by then).

Kind regards,
Miquèl

maintainer
#3 lore raw
In reply to Akhila YS
Quoted 108 lines · Akhila YS

Convert STMicroelectronics SPEAr600 Serial Memory Interface (SMI) Controller binding to YAML format.

---
 .../devicetree/bindings/mtd/spear_smi.txt          | 29 ---------
 .../devicetree/bindings/mtd/st,spear600-smi.yaml   | 72 ++++++++++++++++++++++
 2 files changed, 72 insertions(+), 29 deletions(-)
Documentation/devicetree/bindings/mtd/spear_smi.txt deleted +0 -29
deleted file mode 100644
index c41873e92d26..000000000000
@@ -1,29 +0,0 @@
-* SPEAr SMI
-
-Required properties:
-- compatible : "st,spear600-smi"
-- reg : Address range of the mtd chip
-- #address-cells, #size-cells : Must be present if the device has sub-nodes
-  representing partitions.
-- interrupts: Should contain the STMMAC interrupts
-- clock-rate : Functional clock rate of SMI in Hz
-
-Optional properties:
-- st,smi-fast-mode : Flash supports read in fast mode
-
-Example:
-
-       smi: flash@fc000000 {
-               compatible = "st,spear600-smi";
-               #address-cells = <1>;
-               #size-cells = <1>;
-               reg = <0xfc000000 0x1000>;
-               interrupt-parent = <&vic1>;
-               interrupts = <12>;
-               clock-rate = <50000000>;        /* 50MHz */
-
-               flash@f8000000 {
-                       st,smi-fast-mode;
-                       ...
-               };
-       };
Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml new file +57 -0
new file mode 100644
index 000000000000..8fe27aae7527
@@ -0,0 +1,72 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mtd/st,spear600-smi.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: STMicroelectronics SPEAr600 Serial Memory Interface (SMI) Controller
+
+maintainers:
+  - Richard Weinberger <[email protected]>
+
+description:
+  The SPEAr600 Serial Memory Interface (SMI) is a dedicated serial flash
+  controller supporting up to four chip selects for serial NOR flashes
+  connected in parallel. The controller is memory-mapped and the attached
+  flash devices appear in the CPU address space.The driver
+  (drivers/mtd/devices/spear_smi.c) probes the attached flashes
+  dynamically by sending commands (e.g., RDID) to each bank.
+  Flash sub nodes describe the memory range and optional per-flash
+  properties.
+
+allOf:
+  - $ref: mtd.yaml#
+
+properties:
+  compatible:
+    const: st,spear600-smi
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 1
+
+  clock-rate:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: Functional clock rate of the SMI controller in Hz.
+
+  st,smi-fast-mode:
+    type: boolean
+    description: Indicates that the attached flash supports fast read mode.
+
+required:
+  - compatible
+  - reg
+  - clock-rate
+
+unevaluatedProperties: false
+
+examples:
+  - |

Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml line 67

Quoted 10 lines
Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml new file +10 -0
+    flash@fc000000 {
+        compatible = "st,spear600-smi";
+        #address-cells = <1>;
+        #size-cells = <1>;
+        reg = <0xfc000000 0x1000>;
+        interrupt-parent = <&vic1>;
+        interrupts = <12>;
+        clock-rate = <50000000>;  /* 50 MHz */
+
+        flash@f8000000 {

This is now a warning in linux-next:

Documentation/devicetree/bindings/mtd/st,spear600-smi.example.dtb:
flash@fc000000 (st,spear600-smi): Unevaluated properties are not allowed ('flash@f8000000' was unexpected)
from schema $id: http://devicetree.org/schemas/mtd/st,spear600-smi.yaml

Please send a fix (and test your schemas before sending).

Rob

maintainer
#4 lore raw
Quoted 114 lines · Rob Herring
Quoted 112 lines · Akhila YS

Convert STMicroelectronics SPEAr600 Serial Memory Interface (SMI) Controller binding to YAML format.

---
 .../devicetree/bindings/mtd/spear_smi.txt          | 29 ---------
 .../devicetree/bindings/mtd/st,spear600-smi.yaml   | 72 ++++++++++++++++++++++
 2 files changed, 72 insertions(+), 29 deletions(-)
Documentation/devicetree/bindings/mtd/spear_smi.txt deleted +0 -29
deleted file mode 100644
index c41873e92d26..000000000000
@@ -1,29 +0,0 @@
-* SPEAr SMI
-
-Required properties:
-- compatible : "st,spear600-smi"
-- reg : Address range of the mtd chip
-- #address-cells, #size-cells : Must be present if the device has sub-nodes
-  representing partitions.
-- interrupts: Should contain the STMMAC interrupts
-- clock-rate : Functional clock rate of SMI in Hz
-
-Optional properties:
-- st,smi-fast-mode : Flash supports read in fast mode
-
-Example:
-
-       smi: flash@fc000000 {
-               compatible = "st,spear600-smi";
-               #address-cells = <1>;
-               #size-cells = <1>;
-               reg = <0xfc000000 0x1000>;
-               interrupt-parent = <&vic1>;
-               interrupts = <12>;
-               clock-rate = <50000000>;        /* 50MHz */
-
-               flash@f8000000 {
-                       st,smi-fast-mode;
-                       ...
-               };
-       };
Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml new file +61 -0
new file mode 100644
index 000000000000..8fe27aae7527
@@ -0,0 +1,72 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mtd/st,spear600-smi.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: STMicroelectronics SPEAr600 Serial Memory Interface (SMI) Controller
+
+maintainers:
+  - Richard Weinberger <[email protected]>
+
+description:
+  The SPEAr600 Serial Memory Interface (SMI) is a dedicated serial flash
+  controller supporting up to four chip selects for serial NOR flashes
+  connected in parallel. The controller is memory-mapped and the attached
+  flash devices appear in the CPU address space.The driver
+  (drivers/mtd/devices/spear_smi.c) probes the attached flashes
+  dynamically by sending commands (e.g., RDID) to each bank.
+  Flash sub nodes describe the memory range and optional per-flash
+  properties.
+
+allOf:
+  - $ref: mtd.yaml#
+
+properties:
+  compatible:
+    const: st,spear600-smi
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 1
+
+  clock-rate:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: Functional clock rate of the SMI controller in Hz.
+
+  st,smi-fast-mode:
+    type: boolean
+    description: Indicates that the attached flash supports fast read mode.
+
+required:
+  - compatible
+  - reg
+  - clock-rate
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    flash@fc000000 {
+        compatible = "st,spear600-smi";
+        #address-cells = <1>;
+        #size-cells = <1>;
Quoted 8 lines

Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml line 67

Quoted 6 lines
Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml new file +6 -0
+        reg = <0xfc000000 0x1000>;
+        interrupt-parent = <&vic1>;
+        interrupts = <12>;
+        clock-rate = <50000000>;  /* 50 MHz */
+
+        flash@f8000000 {

This is now a warning in linux-next:

Now this is a warning in v7.0-rc1. Miquel, please revert this as there has been no response.

Quoted 9 lines

Documentation/devicetree/bindings/mtd/st,spear600-smi.example.dtb:
flash@fc000000 (st,spear600-smi): Unevaluated properties are not allowed ('flash@f8000000' was unexpected)
from schema $id: http://devicetree.org/schemas/mtd/st,spear600-smi.yaml

Please send a fix (and test your schemas before sending).

Rob

maintainer
#5 lore raw

Hello Rob,

Quoted 11 lines
Quoted 11 lines
Quoted 10 lines
Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml new file +10 -0
+    flash@fc000000 {
+        compatible = "st,spear600-smi";
+        #address-cells = <1>;
+        #size-cells = <1>;
+        reg = <0xfc000000 0x1000>;
+        interrupt-parent = <&vic1>;
+        interrupts = <12>;
+        clock-rate = <50000000>;  /* 50 MHz */
+
+        flash@f8000000 {
Quoted 4 lines
Quoted 1 line

This is now a warning in linux-next:

Now this is a warning in v7.0-rc1. Miquel, please revert this as there has been no response.

Akhila staying silent, let's try to help with the YAML conversion effort:
https://lore.kernel.org/linux-devicetree/20260225-perso-fix-spear600-smi-yaml-v1-0-8ef3d205ab3a@bootlin.com/T/#m908bf59527847285c0447dd0379b3c88cfd71857

Thanks,
Miquèl

author
#6 lore raw
Quoted 12 lines · Miquel Raynal

Hello Rob,

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml new file +10 -0
+    flash@fc000000 {
+        compatible = "st,spear600-smi";
+        #address-cells = <1>;
+        #size-cells = <1>;
+        reg = <0xfc000000 0x1000>;
+        interrupt-parent = <&vic1>;
+        interrupts = <12>;
+        clock-rate = <50000000>;  /* 50 MHz */
+
+        flash@f8000000 {
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

This is now a warning in linux-next:

Now this is a warning in v7.0-rc1. Miquel, please revert this as there has been no response.

Akhila staying silent, let's try to help with the YAML conversion effort:
https://lore.kernel.org/linux-devicetree/20260225-perso-fix-spear600-smi-yaml-v1-0-8ef3d205ab3a@bootlin.com/T/#m908bf59527847285c0447dd0379b3c88cfd71857

Hi Miquel, i have sent a v2 patch yesterday just a few minutes before you sent a patch series.
Thank you for resolving the issue.

Quoted 3 lines

Thanks,
Miquèl

Signature · 2 lines
Best Regards,
Akhila.
author
#7 lore raw
In reply to Rob Herring
Quoted 120 lines · Rob Herring
Quoted 107 lines · Akhila YS

Convert STMicroelectronics SPEAr600 Serial Memory Interface (SMI) Controller binding to YAML format.

---
 .../devicetree/bindings/mtd/spear_smi.txt          | 29 ---------
 .../devicetree/bindings/mtd/st,spear600-smi.yaml   | 72 ++++++++++++++++++++++
 2 files changed, 72 insertions(+), 29 deletions(-)
Documentation/devicetree/bindings/mtd/spear_smi.txt deleted +0 -29
deleted file mode 100644
index c41873e92d26..000000000000
@@ -1,29 +0,0 @@
-* SPEAr SMI
-
-Required properties:
-- compatible : "st,spear600-smi"
-- reg : Address range of the mtd chip
-- #address-cells, #size-cells : Must be present if the device has sub-nodes
-  representing partitions.
-- interrupts: Should contain the STMMAC interrupts
-- clock-rate : Functional clock rate of SMI in Hz
-
-Optional properties:
-- st,smi-fast-mode : Flash supports read in fast mode
-
-Example:
-
-       smi: flash@fc000000 {
-               compatible = "st,spear600-smi";
-               #address-cells = <1>;
-               #size-cells = <1>;
-               reg = <0xfc000000 0x1000>;
-               interrupt-parent = <&vic1>;
-               interrupts = <12>;
-               clock-rate = <50000000>;        /* 50MHz */
-
-               flash@f8000000 {
-                       st,smi-fast-mode;
-                       ...
-               };
-       };
Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml new file +57 -0
new file mode 100644
index 000000000000..8fe27aae7527
@@ -0,0 +1,72 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mtd/st,spear600-smi.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: STMicroelectronics SPEAr600 Serial Memory Interface (SMI) Controller
+
+maintainers:
+  - Richard Weinberger <[email protected]>
+
+description:
+  The SPEAr600 Serial Memory Interface (SMI) is a dedicated serial flash
+  controller supporting up to four chip selects for serial NOR flashes
+  connected in parallel. The controller is memory-mapped and the attached
+  flash devices appear in the CPU address space.The driver
+  (drivers/mtd/devices/spear_smi.c) probes the attached flashes
+  dynamically by sending commands (e.g., RDID) to each bank.
+  Flash sub nodes describe the memory range and optional per-flash
+  properties.
+
+allOf:
+  - $ref: mtd.yaml#
+
+properties:
+  compatible:
+    const: st,spear600-smi
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 1
+
+  clock-rate:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: Functional clock rate of the SMI controller in Hz.
+
+  st,smi-fast-mode:
+    type: boolean
+    description: Indicates that the attached flash supports fast read mode.
+
+required:
+  - compatible
+  - reg
+  - clock-rate
+
+unevaluatedProperties: false
+
+examples:
+  - |

Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml line 67

Quoted 10 lines
Documentation/devicetree/bindings/mtd/st,spear600-smi.yaml new file +10 -0
+    flash@fc000000 {
+        compatible = "st,spear600-smi";
+        #address-cells = <1>;
+        #size-cells = <1>;
+        reg = <0xfc000000 0x1000>;
+        interrupt-parent = <&vic1>;
+        interrupts = <12>;
+        clock-rate = <50000000>;  /* 50 MHz */
+
+        flash@f8000000 {

This is now a warning in linux-next:

Quoted 6 lines

Documentation/devicetree/bindings/mtd/st,spear600-smi.example.dtb:
flash@fc000000 (st,spear600-smi): Unevaluated properties are not allowed ('flash@f8000000' was unexpected)
from schema $id: http://devicetree.org/schemas/mtd/st,spear600-smi.yaml

Please send a fix (and test your schemas before sending).

Sure, i will resolve that issue and send a next version.

Quoted 2 lines

Rob

Signature · 2 lines
Best Regards,
Akhila.