staging: fbtft: Fix build failure when CONFIG_FB_DEVICE=n
Subsystems (3)
PATCH v8 1/2 staging: fbtft: Fix build failure when CONFIG_FB_DEVICE=n
When CONFIG_FB_DEVICE is disabled, struct fb_info does not provide a valid dev pointer. Direct dereferences of fb_info->dev therefore result in build failures.
Fix this by avoiding direct accesses to fb_info->dev and switching the affected debug logging to framebuffer helpers that do not rely on a device pointer.
This fixes the following build failure reported by the kernel test robot.
---
Changes in v8:
- Add Reviewed-by tag from Andy Shevchenko.
Changes in v7:
- Split logging cleanups into a separate patch
- Limit this patch to the CONFIG_FB_DEVICE=n build fix only
Changes in v6:
- Switch debug/info logging to fb_dbg() and fb_info()(suggested by Thomas Zimmermann)
- Drop dev_of_fbinfo() usage in favor of framebuffer helpers that implicitly handle the debug/info context.
- Drop __func__ usage per review feedback(suggested by greg k-h)
- Add Fixes tag for a06d03f9f238 ("staging: fbtft: Make FB_DEVICE dependency optional") (suggested by Andy Shevchenko)
Changes in v5:
- Initial attempt to replace info->dev accesses using dev_of_fbinfo() helper
drivers/staging/fbtft/fbtft-core.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-)
drivers/staging/fbtft/fbtft-core.c +9 -10
@@ -365,9 +365,9 @@ static int fbtft_fb_setcolreg(unsigned int regno, unsigned int red,unsigned int val;int ret =1 ; -dev_dbg (info->dev, -"%s(regno=%u, red=0x%X, green=0x%X, blue=0x%X, trans=0x%X)\n" , - __func__, regno, red, green, blue, transp); +fb_dbg (info, +"regno=%u, red=0x%X, green=0x%X, blue=0x%X, trans=0x%X\n" , + regno, red, green, blue, transp);switch (info->fix.visual) {case FB_VISUAL_TRUECOLOR :
@@ -391,8 +391,7 @@ static int fbtft_fb_blank(int blank, struct fb_info *info)struct fbtft_par *par = info->par;int ret = -EINVAL ; -dev_dbg (info->dev,"%s(blank=%d)\n" , - __func__, blank); +fb_dbg (info,"blank=%d\n" , blank);if (!par->fbtftops.blank)return ret;
@@ -793,11 +792,11 @@ int fbtft_register_framebuffer(struct fb_info *fb_info)if (spi)sprintf (text2,", spi%d.%d at %d MHz" , spi->controller->bus_num,spi_get_chipselect (spi,0 ), spi->max_speed_hz /1000000 ); -dev_info (fb_info->dev, -"%s frame buffer, %dx%d, %d KiB video memory%s, fps=%lu%s\n" , - fb_info->fix.id, fb_info->var.xres, fb_info->var.yres, - fb_info->fix.smem_len >>10 , text1, -HZ / fb_info->fbdefio->delay, text2); +fb_info (fb_info, +"%s frame buffer, %dx%d, %d KiB video memory%s, fps=%lu%s\n" , + fb_info->fix.id, fb_info->var.xres, fb_info->var.yres, + fb_info->fix.smem_len >>10 , text1, +HZ / fb_info->fbdefio->delay, text2);/* Turn on backlight if available */ if (fb_info->bl_dev) {
Signature · 1 line
2.43.0
PATCH v8 2/2 staging: fbtft: Make framebuffer registration message debug-only
The framebuffer registration message is informational only and not useful during normal operation. Convert it to debug-level logging to keep the driver quiet when working correctly.
---
Changes in v8:
- Add Reviewed-by tag from Andy Shevchenko
- Add Suggested-by tag from Greg Kroah-Hartman
drivers/staging/fbtft/fbtft-core.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/staging/fbtft/fbtft-core.c +5 -5
@@ -792,11 +792,11 @@ int fbtft_register_framebuffer(struct fb_info *fb_info)if (spi)sprintf (text2,", spi%d.%d at %d MHz" , spi->controller->bus_num,spi_get_chipselect (spi,0 ), spi->max_speed_hz /1000000 ); -fb_info (fb_info, -"%s frame buffer, %dx%d, %d KiB video memory%s, fps=%lu%s\n" , - fb_info->fix.id, fb_info->var.xres, fb_info->var.yres, - fb_info->fix.smem_len >>10 , text1, -HZ / fb_info->fbdefio->delay, text2); +fb_dbg (fb_info, +"%s frame buffer, %dx%d, %d KiB video memory%s, fps=%lu%s\n" , + fb_info->fix.id, fb_info->var.xres, fb_info->var.yres, + fb_info->fix.smem_len >>10 , text1, +HZ / fb_info->fbdefio->delay, text2);/* Turn on backlight if available */ if (fb_info->bl_dev) {
Signature · 1 line
2.43.0
Hi,
we've seen reports about this bug from linux-next.
Did anyone merge this series?
Best regards
Thomas
Am 22.01.26 um 04:16 schrieb Chintan Patel:
Quoted 84 lines
When
CONFIG_FB_DEVICEis disabled, structfb_infodoes not provide a valid dev pointer. Direct dereferences offb_info->devtherefore result in build failures.Fix this by avoiding direct accesses to
fb_info->devand switching the affected debug logging to framebuffer helpers that do not rely on a device pointer.This fixes the following build failure reported by the kernel test robot.
Fixes a06d03f9f238 ("staging: fbtft: Make FB_DEVICE dependency optional")Reported-by kernel test robot <[email protected]>Reviewed-by Andy Shevchenko <[email protected]>Signed-off-by Chintan Patel <[email protected]>---
Changes in v8:
- Add Reviewed-by tag from Andy Shevchenko.Changes in v7:
- Split logging cleanups into a separate patch
- Limit this patch to theCONFIG_FB_DEVICE=nbuild fix onlyChanges in v6:
- Switch debug/info logging tofb_dbg()and fb_info()(suggested by Thomas Zimmermann)
- Dropdev_of_fbinfo()usage in favor of framebuffer helpers that implicitly handle the debug/info context.
- Drop__func__usage per review feedback(suggested by greg k-h)
- Add Fixes tag fora06d03f9f238("staging: fbtft: MakeFB_DEVICEdependency optional") (suggested by Andy Shevchenko)Changes in v5:
- Initial attempt to replaceinfo->devaccesses usingdev_of_fbinfo()helperdrivers/staging/fbtft/fbtft-core.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-)drivers/staging/fbtft/fbtft-core.c +9
-10@@ -365,9 +365,9 @@ static int fbtft_fb_setcolreg(unsigned int regno, unsigned int red,unsigned int val;int ret =1 ; -dev_dbg (info->dev, -"%s(regno=%u, red=0x%X, green=0x%X, blue=0x%X, trans=0x%X)\n" , - __func__, regno, red, green, blue, transp); +fb_dbg (info, +"regno=%u, red=0x%X, green=0x%X, blue=0x%X, trans=0x%X\n" , + regno, red, green, blue, transp);switch (info->fix.visual) {case FB_VISUAL_TRUECOLOR :@@ -391,8 +391,7 @@ static int fbtft_fb_blank(int blank, struct fb_info *info)struct fbtft_par *par = info->par;int ret = -EINVAL ; -dev_dbg (info->dev,"%s(blank=%d)\n" , - __func__, blank); +fb_dbg (info,"blank=%d\n" , blank);if (!par->fbtftops.blank)return ret;@@ -793,11 +792,11 @@ int fbtft_register_framebuffer(struct fb_info *fb_info)if (spi)sprintf (text2,", spi%d.%d at %d MHz" , spi->controller->bus_num,spi_get_chipselect (spi,0 ), spi->max_speed_hz /1000000 ); -dev_info (fb_info->dev, -"%s frame buffer, %dx%d, %d KiB video memory%s, fps=%lu%s\n" , - fb_info->fix.id, fb_info->var.xres, fb_info->var.yres, - fb_info->fix.smem_len >>10 , text1, -HZ / fb_info->fbdefio->delay, text2); +fb_info (fb_info, +"%s frame buffer, %dx%d, %d KiB video memory%s, fps=%lu%s\n" , + fb_info->fix.id, fb_info->var.xres, fb_info->var.yres, + fb_info->fix.smem_len >>10 , text1, +HZ / fb_info->fbdefio->delay, text2);/* Turn on backlight if available */ if (fb_info->bl_dev) {
Signature · 6 lines
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)