Skip to contentSkip to conversation

vma05: fix the needs_cmds format

PATCH In review Li Wang via ltp 2 participants 4 messages Jan 22

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vma05: fix the needs_cmds format

Fixes 39a28444272 ("lib: Add support option for .needs_cmds")
Cc Wei Gao <[email protected]>
---
 testcases/kernel/mem/vma/vma05.sh | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
testcases/kernel/mem/vma/vma05.sh +8 -1
index 34a82162c..b9654e80c 100755
@@ -26,7 +26,14 @@
 # {
 #  "needs_root": true,
 #  "needs_tmpdir": true,
-#  "needs_cmds": ["gdb", "uname"],
+#  "needs_cmds": [
+#     {
+#       "cmd": "gdb"
+#     },
+#     {
+#       "cmd": "uname"
+#     }
+#   ],
 #  "save_restore": [
 #   ["/proc/sys/kernel/core_pattern", "core", "TBROK"],
 #   ["/proc/sys/kernel/core_uses_pid", "0", "TBROK"]
Signature · 5 lines
2.52.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
Reviewed-by on v1 1/1
#1 lore raw

Hi Li,

Quoted 14 lines
Fixes 39a28444272 ("lib: Add support option for .needs_cmds")
Cc Wei Gao <[email protected]>
---
 testcases/kernel/mem/vma/vma05.sh | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
testcases/kernel/mem/vma/vma05.sh +0 -0
index 34a82162c..b9654e80c 100755
@@ -26,7 +26,14 @@
 # {
 #  "needs_root": true,

testcases/kernel/mem/vma/vma05.sh line 36

Quoted 10 lines
testcases/kernel/mem/vma/vma05.sh +8 -1
 #  "needs_tmpdir": true,
-#  "needs_cmds": ["gdb", "uname"],
+#  "needs_cmds": [
+#     {
+#       "cmd": "gdb"
+#     },
+#     {
+#       "cmd": "uname"
+#     }
+#   ],

Good catch, thanks!

Kind regards,
Petr

Quoted 3 lines
testcases/kernel/mem/vma/vma05.sh +0 -0
 #  "save_restore": [
 #   ["/proc/sys/kernel/core_pattern", "core", "TBROK"],
 #   ["/proc/sys/kernel/core_uses_pid", "0", "TBROK"]
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
author Reviewed-by Wei Gao
#2 lore raw
Quoted 28 lines · Petr Vorel

Hi Li,

Quoted 14 lines
Fixes 39a28444272 ("lib: Add support option for .needs_cmds")
Cc Wei Gao <[email protected]>
---
 testcases/kernel/mem/vma/vma05.sh | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
testcases/kernel/mem/vma/vma05.sh +0 -0
index 34a82162c..b9654e80c 100755
@@ -26,7 +26,14 @@
 # {
 #  "needs_root": true,

testcases/kernel/mem/vma/vma05.sh line 36

Quoted 10 lines
testcases/kernel/mem/vma/vma05.sh +8 -1
 #  "needs_tmpdir": true,
-#  "needs_cmds": ["gdb", "uname"],
+#  "needs_cmds": [
+#     {
+#       "cmd": "gdb"
+#     },
+#     {
+#       "cmd": "uname"
+#     }
+#   ],

Good catch, thanks!

Quoted 2 lines

Thanks!

Quoted 9 lines

Kind regards,
Petr

Quoted 3 lines
testcases/kernel/mem/vma/vma05.sh +0 -0
 #  "save_restore": [
 #   ["/proc/sys/kernel/core_pattern", "core", "TBROK"],
 #   ["/proc/sys/kernel/core_uses_pid", "0", "TBROK"]
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#3 lore raw

Thanks Petr, Wei.

Merged.

Signature · 6 lines
Regards,
Li Wang


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp