Skip to contentSkip to conversation

ALSA: hda/realtek: Fix headset mic for TongFang X6AR55xU

PATCH Superseded Werner Sembach 2 participants 5 messages Jan 22 – Jan 23 Sound

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

cover ALSA: hda/realtek: Fix headset mic for TongFang X6AR55xU

Sorry the last patch I sent didn't actually work. Here is a revert and a new version. Luckily it was catched quickly.

Tim Guttzeit (1):
ALSA: hda/realtek: Really fix headset mic for TongFang X6AR55xU

Werner Sembach (1):
Revert "ALSA: hda/realtek: Fix headset mic for TongFang X6AR55xU"

 sound/hda/codecs/realtek/alc269.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
Signature · 1 line
2.43.0
#1 lore raw

PATCH 1/2 Revert "ALSA: hda/realtek: Fix headset mic for TongFang X6AR55xU"

This reverts commit 89f135b774c71ab603a5da66d0c1449e76750389.

---
 sound/hda/codecs/realtek/alc269.c | 4 ----
 1 file changed, 4 deletions(-)
sound/hda/codecs/realtek/alc269.c +0 -4
index 24d534f6d3d3a..eb6197d19078c 100644
@@ -7674,10 +7674,6 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
 		{0x12, 0x90a60140},
 		{0x19, 0x04a11030},
 		{0x21, 0x04211020}),
-	SND_HDA_PIN_QUIRK(0x10ec0274, 0x1d05, "TongFang", ALC274_FIXUP_HP_HEADSET_MIC,
-		{0x17, 0x90170110},
-		{0x19, 0x03a11030},
-		{0x21, 0x03211020}),
 	SND_HDA_PIN_QUIRK(0x10ec0282, 0x1025, "Acer", ALC282_FIXUP_ACER_DISABLE_LINEOUT,
 		ALC282_STANDARD_PINS,
 		{0x12, 0x90a609c0},
Signature · 1 line
2.43.0
#2 lore raw

PATCH 2/2 ALSA: hda/realtek: Really fix headset mic for TongFang X6AR55xU

In reply to Werner Sembach

From: Tim Guttzeit <[email protected]>

Add a PCI quirk to enable microphone detection on the headphone jack of TongFang X6AR55xU devices.

---
 sound/hda/codecs/realtek/alc269.c | 1 +
 1 file changed, 1 insertion(+)
sound/hda/codecs/realtek/alc269.c +1 -0
index eb6197d19078c..c709d19a824d3 100644
@@ -7205,6 +7205,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1d05, 0x1409, "TongFang GMxIXxx", ALC2XX_FIXUP_HEADSET_MIC),
 	SND_PCI_QUIRK(0x1d05, 0x300f, "TongFang X6AR5xxY", ALC2XX_FIXUP_HEADSET_MIC),
 	SND_PCI_QUIRK(0x1d05, 0x3019, "TongFang X6FR5xxY", ALC2XX_FIXUP_HEADSET_MIC),
+	SND_PCI_QUIRK(0x1d05, 0x3031, "TongFang X6AR55xU", ALC2XX_FIXUP_HEADSET_MIC),
 	SND_PCI_QUIRK(0x1d17, 0x3288, "Haier Boyue G42", ALC269VC_FIXUP_ACER_VCOPPERBOX_PINS),
 	SND_PCI_QUIRK(0x1d72, 0x1602, "RedmiBook", ALC255_FIXUP_XIAOMI_HEADSET_MIC),
 	SND_PCI_QUIRK(0x1d72, 0x1701, "XiaomiNotebook Pro", ALC298_FIXUP_DELL1_MIC_NO_PRESENCE),
Signature · 1 line
2.43.0
#3 lore raw
In reply to Werner Sembach
Quoted 9 lines · Werner Sembach

Sorry the last patch I sent didn't actually work. Here is a revert and a new version. Luckily it was catched quickly.

Tim Guttzeit (1):
ALSA: hda/realtek: Really fix headset mic for TongFang X6AR55xU

Werner Sembach (1):
Revert "ALSA: hda/realtek: Fix headset mic for TongFang X6AR55xU"

Could you rather fold into a single patch with a Fixes tag? Or, at least, give more details in the revert patch. It says only reverting, and it doesn't help understanding what's going on.

thanks,

Takashi

#4 lore raw

Am 23.01.26 um 12:36 schrieb Takashi Iwai:

Quoted 11 lines
Quoted 8 lines · Werner Sembach

Sorry the last patch I sent didn't actually work. Here is a revert and a new version. Luckily it was catched quickly.

Tim Guttzeit (1):
ALSA: hda/realtek: Really fix headset mic for TongFang X6AR55xU

Werner Sembach (1):
Revert "ALSA: hda/realtek: Fix headset mic for TongFang X6AR55xU"

Could you rather fold into a single patch with a Fixes tag?

ok will do

Quoted 7 lines

Or, at least, give more details in the revert patch. It says only reverting, and it doesn't help understanding what's going on.

thanks,

Takashi