Skip to contentSkip to conversation

drm/amdgpu/soc21: fix xclk for APUs

PATCH In review Alex Deucher 3 participants 3 messages Jan 23 – Jan 28

Subsystems (2)
lore
Share & tools
lore

Alex Deucher

author maintainer
#0 lore raw

PATCH 1/1 drm/amdgpu/soc21: fix xclk for APUs

The reference clock is supposed to be 100Mhz, but it appears to actually be slightly lower (99.81Mhz).

---
 drivers/gpu/drm/amd/amdgpu/soc21.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/soc21.c +7 -1
index 2da733b45c21a..d9cc649d81ad4 100644
@@ -256,7 +256,13 @@ static u32 soc21_get_config_memsize(struct amdgpu_device *adev)
 
 static u32 soc21_get_xclk(struct amdgpu_device *adev)
 {
-	return adev->clock.spll.reference_freq;
+	u32 reference_clock = adev->clock.spll.reference_freq;
+
+	/* reference clock is actually 99.81 Mhz rather than 100 Mhz */
+	if ((adev->flags & AMD_IS_APU) && reference_clock == 10000)
+		return 9981;
+
+	return reference_clock;
 }
 
 
Signature · 1 line
2.52.0
#1 lore raw

Ping?

Quoted 32 lines · Alex Deucher

The reference clock is supposed to be 100Mhz, but it appears to actually be slightly lower (99.81Mhz).

---
 drivers/gpu/drm/amd/amdgpu/soc21.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/soc21.c +7 -2
index 2da733b45c21a..d9cc649d81ad4 100644
@@ -256,7 +256,13 @@ static u32 soc21_get_config_memsize(struct amdgpu_device *adev)
 
 static u32 soc21_get_xclk(struct amdgpu_device *adev)
 {
-       return adev->clock.spll.reference_freq;
+       u32 reference_clock = adev->clock.spll.reference_freq;
+
+       /* reference clock is actually 99.81 Mhz rather than 100 Mhz */
+       if ((adev->flags & AMD_IS_APU) && reference_clock == 10000)
+               return 9981;
+
+       return reference_clock;
 }
 
 
--

2.52.0

Reviewed-by Alex Deucher
#2 lore raw

[AMD Official Use Only - AMD Internal Distribution Only]

Quoted 45 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Alex Deucher
Sent: Wednesday, January 28, 2026 6:55 AM
To: Deucher, Alexander <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] drm/amdgpu/soc21: fix xclk for APUs

Ping?

Quoted 33 lines · Alex Deucher

The reference clock is supposed to be 100Mhz, but it appears to actually be slightly lower (99.81Mhz).

---
 drivers/gpu/drm/amd/amdgpu/soc21.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/soc21.c +7 -2
index 2da733b45c21a..d9cc649d81ad4 100644
@@ -256,7 +256,13 @@ static u32 soc21_get_config_memsize(struct
 amdgpu_device *adev)
 
 static u32 soc21_get_xclk(struct amdgpu_device *adev)  {
-       return adev->clock.spll.reference_freq;
+       u32 reference_clock = adev->clock.spll.reference_freq;
+
+       /* reference clock is actually 99.81 Mhz rather than 100 Mhz */
+       if ((adev->flags & AMD_IS_APU) && reference_clock == 10000)
+               return 9981;
+
+       return reference_clock;
 }
 
 
--

2.52.0