netdevsim: use u64_stats_t with u64_stats_sync properly
Subsystems (3)
PATCH 1/1 netdevsim: use u64_stats_t with u64_stats_sync properly
On 64bit arches, struct u64_stats_sync is empty and provides no help against load/store tearing. Convert to u64_stats_t to ensure atomic operations.
Signed-off-by David Yang <[email protected]>
--- drivers/net/netdevsim/netdevsim.h | 8 ++++---- drivers/net/netdevsim/psp.c | 18 ++++++++++-------- 2 files changed, 14 insertions(+), 12 deletions(-)
drivers/net/netdevsim/netdevsim.h +4 -4
@@ -109,10 +109,10 @@ struct netdevsim {int rq_reset_mode;struct { -u64 rx_packets; -u64 rx_bytes; -u64 tx_packets; -u64 tx_bytes; +u64_stats_t rx_packets; +u64_stats_t rx_bytes; +u64_stats_t tx_packets; +u64_stats_t tx_bytes;struct u64_stats_sync syncp;struct psp_dev *dev;u32 spi;
drivers/net/netdevsim/psp.c +10 -8
@@ -72,10 +72,12 @@ nsim_do_psp(struct sk_buff *skb, struct netdevsim *ns, skb->decrypted =1 ;u64_stats_update_begin (&ns->psp.syncp); - ns->psp.tx_packets++; - ns->psp.rx_packets++; - ns->psp.tx_bytes += skb->len -skb_inner_transport_offset (skb); - ns->psp.rx_bytes += skb->len -skb_inner_transport_offset (skb); +u64_stats_inc (&ns->psp.tx_packets); +u64_stats_inc (&ns->psp.rx_packets); +u64_stats_add (&ns->psp.tx_bytes, + skb->len -skb_inner_transport_offset (skb)); +u64_stats_add (&ns->psp.rx_bytes, + skb->len -skb_inner_transport_offset (skb));u64_stats_update_end (&ns->psp.syncp); }else {struct ipv6hdr *ip6h__maybe_unused ;
@@ -183,10 +185,10 @@ static void nsim_get_stats(struct psp_dev *psd, struct psp_dev_stats *stats)do { start =u64_stats_fetch_begin (&ns->psp.syncp); - stats->rx_bytes = ns->psp.rx_bytes; - stats->rx_packets = ns->psp.rx_packets; - stats->tx_bytes = ns->psp.tx_bytes; - stats->tx_packets = ns->psp.tx_packets; + stats->rx_bytes =u64_stats_read (&ns->psp.rx_bytes); + stats->rx_packets =u64_stats_read (&ns->psp.rx_packets); + stats->tx_bytes =u64_stats_read (&ns->psp.tx_bytes); + stats->tx_packets =u64_stats_read (&ns->psp.tx_packets); }while (u64_stats_fetch_retry (&ns->psp.syncp, start)); }
Signature · 1 line
2.51.0
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Sat, 24 Jan 2026 05:10:55 +0800 you wrote:
On 64bit arches, struct
u64_stats_syncis empty and provides no help against load/store tearing. Convert tou64_stats_tto ensure atomic operations.Signed-off-by David Yang <[email protected]>--- drivers/net/netdevsim/netdevsim.h | 8 ++++---- drivers/net/netdevsim/psp.c | 18 ++++++++++-------- 2 files changed, 14 insertions(+), 12 deletions(-)
Here is the summary with links:
- [net-next] netdevsim: use u64_stats_t with u64_stats_sync properly
https://git.kernel.org/netdev/net-next/c/5c05b3dbccb1
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html