usb: gadget: Add a prefix to log messages
cover usb: gadget: Add a prefix to log messages
I met some log as below:
[ 581.262476] read descriptors [ 581.265558] bcdVersion must be 0x0100, stored in Little Endian order...
To be honest, if I'm not familiar with the usb gadget framework, I dunno which component is complaining. Add a prefix to log messages, so the above messages will be look as below:
[ 581.262476] usb_f_fs: read descriptors [ 581.265558] usb_f_fs: bcdVersion must be 0x0100, stored in Little Endian order...
Then solve similar issues for f_mass_storage and f_tcm.
Jisheng Zhang (3):
usb: gadget: f_fs: Add a prefix to log messages
usb: gadget: f_mass_storage: Add a prefix to log messages
usb: gadget: f_tcm: Add a prefix to log messages
drivers/usb/gadget/function/f_fs.c | 2 ++ drivers/usb/gadget/function/f_mass_storage.c | 2 ++ drivers/usb/gadget/function/f_tcm.c | 3 +++ 3 files changed, 7 insertions(+)
Signature · 1 line
2.51.0
PATCH 1/3 usb: gadget: f_fs: Add a prefix to log messages
I met some log as below:
[ 581.262476] read descriptors [ 581.265558] bcdVersion must be 0x0100, stored in Little Endian order...
To be honest, if I'm not familiar with the usb gadget framework, I dunno which component is complaining. Add a prefix to log messages, so the above messages will look like:
[ 581.262476] usb_f_fs: read descriptors [ 581.265558] usb_f_fs: bcdVersion must be 0x0100, stored in Little Endian order...
--- drivers/usb/gadget/function/f_fs.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/usb/gadget/function/f_fs.c +2 -0
@@ -14,6 +14,8 @@/* #define DEBUG */ /* #define VERBOSE_DEBUG */ +#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt +#include <linux/blkdev.h> #include <linux/dma-buf.h> #include <linux/dma-fence.h>
Signature · 1 line
2.51.0
PATCH 2/3 usb: gadget: f_mass_storage: Add a prefix to log messages
In reply to Jisheng ZhangSimilar as last patch, add a prefix to log messages so that users can convienently know where's the msg from.
--- drivers/usb/gadget/function/f_mass_storage.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/usb/gadget/function/f_mass_storage.c +2 -0
@@ -168,6 +168,8 @@/* #define VERBOSE_DEBUG */ /* #define DUMP_MSGS */ +#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt +#include <linux/blkdev.h> #include <linux/completion.h> #include <linux/dcache.h>
Signature · 1 line
2.51.0
Re: [PATCH 2/3] usb: gadget: f_mass_storage: Add a prefix to log messages
Quoted 1 line · Jisheng Zhang
Similar as last patch,
This is not a good thing to put in a patch description. Once the patch has been merged into the kernel source, nobody will know what the "last patch" was -- it refers to something in a mailing list, not something available to people reading a changelog in Git.
Alan Stern
Quoted 25 lines
add a prefix to log messages so that users can
convienently know where's the msg from.Signed-off-by Jisheng Zhang <[email protected]>--- drivers/usb/gadget/function/f_mass_storage.c | 2 ++ 1 file changed, 2 insertions(+)drivers/usb/gadget/function/f_mass_storage.c +2
-0@@ -168,6 +168,8 @@/* #define VERBOSE_DEBUG */ /* #define DUMP_MSGS */ +#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt +#include <linux/blkdev.h> #include <linux/completion.h> #include <linux/dcache.h> Signature · 1 line
2.51.0
PATCH 3/3 usb: gadget: f_tcm: Add a prefix to log messages
In reply to Jisheng ZhangSimilar as last patch, add a prefix to log messages so that users can convienently know where's the msg from.
--- drivers/usb/gadget/function/f_tcm.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/usb/gadget/function/f_tcm.c +3 -0
@@ -6,6 +6,9 @@* * Author: Sebastian Andrzej Siewior <bigeasy at linutronix dot de> */ + +#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt +#include <linux/kernel.h> #include <linux/module.h> #include <linux/types.h>
Signature · 1 line
2.51.0
Greg Kroah-Hartman
maintainerQuoted 4 lines · Jisheng Zhang
I met some log as below:
[ 581.262476] read descriptors [ 581.265558] bcdVersion must be 0x0100, stored in Little Endian order...
Quoted 8 lines
To be honest, if I'm not familiar with the usb gadget framework, I dunno which component is complaining. Add a prefix to log messages, so the above messages will be look as below:
[ 581.262476] usb_f_fs: read descriptors [ 581.265558] usb_f_fs: bcdVersion must be 0x0100, stored in Little Endian order...Then solve similar issues for
f_mass_storageandf_tcm.
These should all be using the dev_info() and like calls, not pr_*(), and if that happens, then you will get the correct prefix. Can you make that change instead?
thanks,
greg k-h
Quoted 9 lines · Greg Kroah-Hartman
Quoted 8 lines · Jisheng Zhang
I met some log as below:
[ 581.262476] read descriptors [ 581.265558] bcdVersion must be 0x0100, stored in Little Endian order...To be honest, if I'm not familiar with the usb gadget framework, I dunno which component is complaining. Add a prefix to log messages, so the above messages will be look as below:
Quoted 8 lines
Quoted 4 lines
[ 581.262476] usb_f_fs: read descriptors [ 581.265558] usb_f_fs: bcdVersion must be 0x0100, stored in Little Endian order...Then solve similar issues for
f_mass_storageandf_tcm.These should all be using the
dev_info()and like calls, not pr_*(), and if that happens, then you will get the correct prefix. Can you make that change instead?
Unfortunately, the composite gadget driver doesn't create sub-devices of the gadget for the various function drivers to bind to. The only device available is the gadget itself, and its driver's name is just "composite". Therefore dev_info() and others will not show the particular function driver, which is what Jisheng wants to see.
Also, some of the calls affected by these changes occur at module initialization time, before anything has been bound. They don't yet have any device to refer to.
Alan Stern
Greg Kroah-Hartman
maintainerQuoted 25 lines · Alan Stern
Quoted 9 lines · Greg Kroah-Hartman
Quoted 8 lines · Jisheng Zhang
I met some log as below:
[ 581.262476] read descriptors [ 581.265558] bcdVersion must be 0x0100, stored in Little Endian order...To be honest, if I'm not familiar with the usb gadget framework, I dunno which component is complaining. Add a prefix to log messages, so the above messages will be look as below:
Quoted 8 lines
Quoted 4 lines
[ 581.262476] usb_f_fs: read descriptors [ 581.265558] usb_f_fs: bcdVersion must be 0x0100, stored in Little Endian order...Then solve similar issues for
f_mass_storageandf_tcm.These should all be using the
dev_info()and like calls, not pr_*(), and if that happens, then you will get the correct prefix. Can you make that change instead?Unfortunately, the composite gadget driver doesn't create sub-devices of the gadget for the various function drivers to bind to. The only device available is the gadget itself, and its driver's name is just "composite". Therefore
dev_info()and others will not show the particular function driver, which is what Jisheng wants to see.
Quoted 3 lines
Also, some of the calls affected by these changes occur at module initialization time, before anything has been bound. They don't yet have any device to refer to.
For things that happen before a device, sure, pr_() is ok (but really should be quiet unless it's for debugging stuff.) The other ones should have or get a device pointer eventually. Using dev_info() AND the function driver name is the best way forward here, that way you know exactly what device it is referring to.
thanks,
greg k-h