Skip to contentSkip to conversation

drm/i915: Register vGPU after DRM dev register and fix fail path

PATCH New Kaushlendra Kumar 2 participants 2 messages Jan 24

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Register vGPU after DRM dev register and fix fail path

Move vGPU registration after successful drm_dev_register(). Avoid drm_dev_unregister() on failed registration attempt.

Fixes 223038731489 ("drm/i915: Fix harmful driver register/unregister asymmetry")
---
 drivers/gpu/drm/i915/i915_driver.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/i915/i915_driver.c +1 -3
index c97b76771917..725c60399d80 100644
@@ -630,19 +630,17 @@ static int i915_driver_register(struct drm_i915_private *dev_priv)
 	i915_gem_driver_register(dev_priv);
 	i915_pmu_register(dev_priv);
 
-	intel_vgpu_register(dev_priv);
-
 	/* Reveal our presence to userspace */
 	ret = drm_dev_register(&dev_priv->drm, 0);
 	if (ret) {
 		i915_probe_error(dev_priv,
 				 "Failed to register driver for userspace access!\n");
-		drm_dev_unregister(&dev_priv->drm);
 		i915_pmu_unregister(dev_priv);
 		i915_gem_driver_unregister(dev_priv);
 		return ret;
 	}
 
+	intel_vgpu_register(dev_priv);
 	i915_debugfs_register(dev_priv);
 	i915_setup_sysfs(dev_priv);
 
Signature · 1 line
2.34.1
#1 lore raw

✗ i915.CI.BAT: failure for drm/i915: Register vGPU after DRM dev register and fix fail path

== Series Details ==

== Series Details ==

Series: drm/i915: Register vGPU after DRM dev register and fix fail path
URL : https://patchwork.freedesktop.org/series/160598/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_17882 -> Patchwork_160598v1
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_160598v1 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in Patchwork_160598v1, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_160598v1/index.html

Participating hosts (43 -> 41)
------------------------------

Missing (2): bat-dg2-13 fi-snb-2520m

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_160598v1:

### IGT changes ###

#### Possible regressions ####

* igt@kms_flip@basic-flip-vs-dpms@c-dp1:
- bat-adlp-9: [PASS][1] -> [FAIL][2] +2 other tests fail
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17882/bat-adlp-9/igt@kms_flip@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_160598v1/bat-adlp-9/igt@kms_flip@[email protected]

Known issues
------------

Here are the changes found in Patchwork_160598v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live@workarounds:
- bat-dg2-14: [PASS][3] -> [DMESG-FAIL][4] ([i915#12061]) +1 other test dmesg-fail
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17882/bat-dg2-14/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_160598v1/bat-dg2-14/igt@i915_selftest@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@workarounds:
- bat-arls-5: [DMESG-FAIL][5] ([i915#12061]) -> [PASS][6] +1 other test pass
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_17882/bat-arls-5/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_160598v1/bat-arls-5/igt@i915_selftest@[email protected]

[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061

Build changes
-------------

* Linux: CI_DRM_17882 -> Patchwork_160598v1

CI-20190529: 20190529
CI_DRM_17882: 6d7af7c5b6b121d5595b64be7dfcbf33be53287b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8716: 8716
Patchwork_160598v1: 6d7af7c5b6b121d5595b64be7dfcbf33be53287b @ git://anongit.freedesktop.org/gfx-ci/linux

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_160598v1/index.html