Skip to contentSkip to conversation

drm/tyr: depend on `COMMON_CLK` to fix build error

PATCH Applied Miguel Ojeda 3 participants 5 messages Jan 24 – Jan 26

Subsystems (5)
Stable branch DRM drivers Rust DRM Rust +1 more subsystems
lore
Share & tools
lore

Miguel Ojeda

author maintainer
#0 lore raw

PATCH 1/1 drm/tyr: depend on `COMMON_CLK` to fix build error

Tyr needs CONFIG_COMMON_CLK to build:

    error[E0432]: unresolved import `kernel::clk::Clk`
     --> drivers/gpu/drm/tyr/driver.rs:3:5
      |
    3 | use kernel::clk::Clk;
      |     ^^^^^^^^^^^^^^^^ no `Clk` in `clk`

    error[E0432]: unresolved import `kernel::clk::OptionalClk`
     --> drivers/gpu/drm/tyr/driver.rs:4:5
      |
    4 | use kernel::clk::OptionalClk;
      |     ^^^^^^^^^^^^^^^^^^^^^^^^ no `OptionalClk` in `clk`

Thus add the dependency to fix it.

Fixes cf4fd52e3236 ("rust: drm: Introduce the Tyr driver for Arm Mali GPUs")
Cc [email protected]
Signed-off-by Miguel Ojeda <[email protected]>
---
 drivers/gpu/drm/tyr/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/tyr/Kconfig +1 -0
index 4b55308fd2eb..e933e6478027 100644
@@ -6,6 +6,7 @@ config DRM_TYR
 	depends on RUST
 	depends on ARM || ARM64 || COMPILE_TEST
 	depends on !GENERIC_ATOMIC64  # for IOMMU_IO_PGTABLE_LPAE
+	depends on COMMON_CLK
 	default n
 	help
 	  Rust DRM driver for ARM Mali CSF-based GPUs.

base-commit: 24d479d26b25bce5faea3ddd9fa8f3a6c3129ea7

Signature · 1 line
2.52.0
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 15 lines · Miguel Ojeda

Tyr needs CONFIG_COMMON_CLK to build:

    error[E0432]: unresolved import `kernel::clk::Clk`
     --> drivers/gpu/drm/tyr/driver.rs:3:5
      |
    3 | use kernel::clk::Clk;
      |     ^^^^^^^^^^^^^^^^ no `Clk` in `clk`

    error[E0432]: unresolved import `kernel::clk::OptionalClk`
     --> drivers/gpu/drm/tyr/driver.rs:4:5
      |
    4 | use kernel::clk::OptionalClk;
      |     ^^^^^^^^^^^^^^^^^^^^^^^^ no `OptionalClk` in `clk`
Quoted 5 lines

Thus add the dependency to fix it.

Fixes cf4fd52e3236 ("rust: drm: Introduce the Tyr driver for Arm Mali GPUs")
Cc [email protected]
Signed-off-by Miguel Ojeda <[email protected]>

Thanks Miguel. Since the drm fixes PR for this week was already sent I think we can just include this in drm-rust-next.

Though, if you plan a fixes PR for this cycle, you're also welcome to include this patch with my ack.

Acked-by Alice Ryhl <[email protected]>

Alice

#2 lore raw
Quoted 7 lines · Alice Ryhl

Thanks Miguel. Since the drm fixes PR for this week was already sent I think we can just include this in drm-rust-next.

Though, if you plan a fixes PR for this cycle, you're also welcome to include this patch with my ack.

Acked-by Alice Ryhl <[email protected]>

You're welcome!

Yeah, I am sending the fixes PR in a few days, so I can pick it up if it is easier for you. Either way, it is not very urgent.

Cheers,
Miguel

Applied
#3 lore raw
In reply to Miguel Ojeda
Quoted 15 lines · Miguel Ojeda

Tyr needs CONFIG_COMMON_CLK to build:

    error[E0432]: unresolved import `kernel::clk::Clk`
     --> drivers/gpu/drm/tyr/driver.rs:3:5
      |
    3 | use kernel::clk::Clk;
      |     ^^^^^^^^^^^^^^^^ no `Clk` in `clk`

    error[E0432]: unresolved import `kernel::clk::OptionalClk`
     --> drivers/gpu/drm/tyr/driver.rs:4:5
      |
    4 | use kernel::clk::OptionalClk;
      |     ^^^^^^^^^^^^^^^^^^^^^^^^ no `OptionalClk` in `clk`
Quoted 5 lines

Thus add the dependency to fix it.

Fixes cf4fd52e3236 ("rust: drm: Introduce the Tyr driver for Arm Mali GPUs")
Cc [email protected]
Signed-off-by Miguel Ojeda <[email protected]>

Applied to rust-fixes -- thanks!

Cheers,
Miguel

maintainer
#4 lore raw
Quoted 17 lines · Miguel Ojeda
Quoted 15 lines · Miguel Ojeda

Tyr needs CONFIG_COMMON_CLK to build:

    error[E0432]: unresolved import `kernel::clk::Clk`
     --> drivers/gpu/drm/tyr/driver.rs:3:5
      |
    3 | use kernel::clk::Clk;
      |     ^^^^^^^^^^^^^^^^ no `Clk` in `clk`

    error[E0432]: unresolved import `kernel::clk::OptionalClk`
     --> drivers/gpu/drm/tyr/driver.rs:4:5
      |
    4 | use kernel::clk::OptionalClk;
      |     ^^^^^^^^^^^^^^^^^^^^^^^^ no `OptionalClk` in `clk`
Quoted 7 lines
Quoted 5 lines

Thus add the dependency to fix it.

Fixes cf4fd52e3236 ("rust: drm: Introduce the Tyr driver for Arm Mali GPUs")
Cc [email protected]
Signed-off-by Miguel Ojeda <[email protected]>

Applied to rust-fixes -- thanks!

Thanks!