Skip to contentSkip to conversation

net: usb: int51x1: remove unused includes

PATCH In review Ethan Nelson-Moore 2 participants 3 messages Jan 26 – Jan 28

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: usb: int51x1: remove unused includes

Most of the headers the int51x1 driver includes are not actually used. Remove these unused includes.

---
 drivers/net/usb/int51x1.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/net/usb/int51x1.c +0 -5
index 6fde41550de1..317ae365277f 100644
@@ -13,13 +13,8 @@
  */
 
 #include <linux/module.h>
-#include <linux/ctype.h>
 #include <linux/netdevice.h>
 #include <linux/etherdevice.h>
-#include <linux/ethtool.h>
-#include <linux/slab.h>
-#include <linux/mii.h>
-#include <linux/usb.h>
 #include <linux/usb/usbnet.h>
 
 #define INT51X1_VENDOR_ID	0x09e1
Signature · 1 line
2.43.0
maintainer
#1 lore raw
Quoted 1 line · On Sun, 25 Jan 2026 23:06:13 -0800 Ethan Nelson-Moore wrote:

-#include <linux/usb.h>

$ git grep 'struct usb_driver {' 
include/linux/usb.h:struct usb_driver {

Please do not send v2 of this one.

Signature · 1 line
pw-bot: reject
#2 lore raw
Quoted 2 lines · Jakub Kicinski
$ git grep 'struct usb_driver {'
include/linux/usb.h:struct usb_driver {

Good point. I'll try to avoid introducing indirect header dependencies in the future.

Quoted 1 line

Please do not send v2 of this one.

Understandable. This kind of trivial cleanup isn't really necessary anyway; I just happened to notice the unused includes.

Ethan