Skip to contentSkip to conversation

00_header: Omit loading efi_uga on non-x86 EFI platforms

PATCH In review Michael Chang via Grub-devel 1 participant 5 messages Jan 26 – Jan 29

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 00_header: Omit loading efi_uga on non-x86 EFI platforms

When booting the arm64-efi target, GRUB prints the error message that may disrupt the boot process:

error: ../../grub-core/fs/btrfs.c:find_path:2163:file `/boot/grub2/arm64-efi/efi_uga.mod' not found.

This is introduced by the commit:

ea0b76dc4 util/grub.d/00_header.in: Disable loading all_video for EFI

However the efi_uga module is only enabled for x86_64-efi and i386-efi. The script should therefore check the CPU target before attempting to load it.

---
 util/grub.d/00_header.in | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
util/grub.d/00_header.in +3 -1
index 77834cfaf..737132e90 100644
@@ -135,7 +135,9 @@ else # GRUB_FORCE_EFI_ALL_VIDEO is not set true
     cat <<EOF
   if [ x\$grub_platform = xefi ]; then
     insmod efi_gop
-    insmod efi_uga
+    if [ x\$grub_cpu = xx86_64 -o x\$grub_cpu = xi386 ]; then
+        insmod efi_uga
+    fi
   elif [ x\$feature_all_video_module = xy ]; then
 EOF
 fi # end GRUB_FORCE_EFI_ALL_VIDEO
Signature · 7 lines
2.52.0


_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel
#1 lore raw

Hi,

Quoted 3 lines

However the efi_uga module is only enabled for x86_64-efi and i386-efi. The script should therefore check the CPU target before attempting to load it.

Or just remove efi_uga?

tianocore has removed uga support from the source tree last year, noting that "The UGA I/O and Draw protocols are deprecated since UEFI 2.0 was introduced". UEFI 2.0 spec was released in January 2006.

https://github.com/tianocore/edk2/pull/11200

take care,
Gerd

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel

#2 lore raw
Quoted 6 lines · Gerd Hoffmann

Hi,

Quoted 3 lines

However the efi_uga module is only enabled for x86_64-efi and i386-efi. The script should therefore check the CPU target before attempting to load it.

Quoted 7 lines

Or just remove efi_uga?

tianocore has removed uga support from the source tree last year, noting that "The UGA I/O and Draw protocols are deprecated since UEFI 2.0 was introduced". UEFI 2.0 spec was released in January 2006.

https://github.com/tianocore/edk2/pull/11200

Thanks for the info. Yes, it looks like a viable decision to remove it as well. However the patch is intended as a quick fix for the released 2.14 branch, where efi_uga is still a supported module.

Perhaps a separate drop request to drop it in the next GRUB release would be better, and would also allow more time to collect feedback.

Thanks,
Michael

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel

#3 lore raw
Quoted 13 lines · Michael Chang
Quoted 12 lines · Gerd Hoffmann

Hi,

Quoted 3 lines

However the efi_uga module is only enabled for x86_64-efi and i386-efi. The script should therefore check the CPU target before attempting to load it.

Or just remove efi_uga?

tianocore has removed uga support from the source tree last year, noting that "The UGA I/O and Draw protocols are deprecated since UEFI 2.0 was introduced". UEFI 2.0 spec was released in January 2006.

Quoted 8 lines
Quoted 1 line

https://github.com/tianocore/edk2/pull/11200

Thanks for the info. Yes, it looks like a viable decision to remove it as well. However the patch is intended as a quick fix for the released 2.14 branch, where efi_uga is still a supported module.

Perhaps a separate drop request to drop it in the next GRUB release would be better, and would also allow more time to collect feedback.

Well, the removal can be staged in two steps, first remove from the config, and in case nobody misses it for one release cycle purge it completely from the code base.

IMHO removal from the config is fine even for the 2.14 branch.

take care,
Gerd

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel

#4 lore raw
Quoted 20 lines · Gerd Hoffmann via Grub-devel
Quoted 19 lines · Michael Chang
Quoted 6 lines · Gerd Hoffmann

Hi,

Quoted 3 lines

However the efi_uga module is only enabled for x86_64-efi and i386-efi. The script should therefore check the CPU target before attempting to load it.

Quoted 7 lines

Or just remove efi_uga?

tianocore has removed uga support from the source tree last year, noting that "The UGA I/O and Draw protocols are deprecated since UEFI 2.0 was introduced". UEFI 2.0 spec was released in January 2006.

https://github.com/tianocore/edk2/pull/11200

Thanks for the info. Yes, it looks like a viable decision to remove it as well. However the patch is intended as a quick fix for the released 2.14 branch, where efi_uga is still a supported module.

Quoted 8 lines
Quoted 2 lines

Perhaps a separate drop request to drop it in the next GRUB release would be better, and would also allow more time to collect feedback.

Well, the removal can be staged in two steps, first remove from the config, and in case nobody misses it for one release cycle purge it completely from the code base.

IMHO removal from the config is fine even for the 2.14 branch.

I just did a quick check by removing all the efi_* modules from the config and the terminal falls back to text menu gracefully. So it seems to me this is not too much hassle for users: even if the efi video drivers missing, the system still boots and they can add the modules back to the config later.

So I'm not against the idea, but I'd like to hear more from Daniel if he's OK with this. :)

Thanks,
Michael

Quoted 9 lines

take care,
Gerd

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel