Skip to contentSkip to conversation

xfs/841: fix the fsstress invocation

PATCH In review Christoph Hellwig 3 participants 3 messages Jan 26 – Jan 29

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs/841: fix the fsstress invocation

xfs/841 fails for me with:

+/root/xfstests-dev/tests/xfs/841: line 79: -f: command not found

Looks like the recent edits missed a \ escape. Fix that.

---
 tests/xfs/841 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/xfs/841 +1 -1
index b4bf538f1526..ee2368d4a746 100755
@@ -64,7 +64,7 @@ _create_proto_dir()
 	rm -rf "$PROTO_DIR"
 	mkdir -p "$PROTO_DIR"
 
-	FSSTRESS_ARGS=`_scale_fsstress_args -d $PROTO_DIR -s 1 -n 2000 -p 2 -z
+	FSSTRESS_ARGS=`_scale_fsstress_args -d $PROTO_DIR -s 1 -n 2000 -p 2 -z \
 		-f creat=15 \
 		-f mkdir=8 \
 		-f write=15 \
Signature · 1 line
2.47.3
Reviewed-by on v1 1/1
#1 lore raw

[cc fstests]

Quoted 7 lines · Christoph Hellwig

xfs/841 fails for me with:

+/root/xfstests-dev/tests/xfs/841: line 79: -f: command not found

Looks like the recent edits missed a \ escape. Fix that.

Doh!

--D

Quoted 21 lines
---
 tests/xfs/841 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/xfs/841 +1 -1
index b4bf538f1526..ee2368d4a746 100755
@@ -64,7 +64,7 @@ _create_proto_dir()
 	rm -rf "$PROTO_DIR"
 	mkdir -p "$PROTO_DIR"
 
-	FSSTRESS_ARGS=`_scale_fsstress_args -d $PROTO_DIR -s 1 -n 2000 -p 2 -z
+	FSSTRESS_ARGS=`_scale_fsstress_args -d $PROTO_DIR -s 1 -n 2000 -p 2 -z \
 		-f creat=15 \
 		-f mkdir=8 \
 		-f write=15 \
Signature · 1 line
2.47.3
#2 lore raw
Quoted 5 lines · Darrick J. Wong

[cc fstests]

Quoted 2 lines · Christoph Hellwig

xfs/841 fails for me with:

Quoted 8 lines
Quoted 5 lines

+/root/xfstests-dev/tests/xfs/841: line 79: -f: command not found

Looks like the recent edits missed a \ escape. Fix that.

Doh!

Thanks Christoph and Darrick, sorry I failed to push the lastest for-next branch. You might find this failure on old patches-in-queue branch. I did basic regression test on that branch, and I think I've found and fixed this issue before merging into for-next last week. Could you please pull the latest for-next branch again and see if the issue persists?

Thanks,
Zorro

Quoted 25 lines

--D

Quoted 21 lines
---
 tests/xfs/841 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/xfs/841 +1 -1
index b4bf538f1526..ee2368d4a746 100755
@@ -64,7 +64,7 @@ _create_proto_dir()
 	rm -rf "$PROTO_DIR"
 	mkdir -p "$PROTO_DIR"
 
-	FSSTRESS_ARGS=`_scale_fsstress_args -d $PROTO_DIR -s 1 -n 2000 -p 2 -z
+	FSSTRESS_ARGS=`_scale_fsstress_args -d $PROTO_DIR -s 1 -n 2000 -p 2 -z \
 		-f creat=15 \
 		-f mkdir=8 \
 		-f write=15 \
Signature · 1 line
2.47.3