Skip to contentSkip to conversation

rust/hpet: remove stale TODO comment

PATCH Applied Mohd Kashif Khan 3 participants 3 messages Jan 26 – Jan 27 Rust

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rust/hpet: remove stale TODO comment

The irq binding is already implemented in the following line, so the TODO comment is obsolete.

---
 rust/hw/timer/hpet/src/device.rs | 1 -
 1 file changed, 1 deletion(-)
rust/hw/timer/hpet/src/device.rs +0 -1
index 4757bf5fd5..ebf715d399 100644
@@ -725,7 +725,6 @@ fn set_cfg_reg(&self, regs: &mut HPETRegisters, shift: u32, len: u32, val: u64)
             self.irqs[0].lower();
             self.irqs[RTC_ISA_IRQ].lower();
         } else if deactivating_bit(old_val, new_val, HPET_CFG_LEG_RT_SHIFT) {
-            // TODO: Add irq binding: qemu_irq_lower(s->irqs[0])
             self.irqs[0].lower();
             self.pit_enabled.set(true);
             self.irqs[RTC_ISA_IRQ].set(self.rtc_irq_level.get() != 0);
Signature · 1 line
2.43.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · Mohd Kashif Khan

Date: Tue, 27 Jan 2026 02:39:10 +0530
From: Mohd Kashif Khan <[email protected]>
Subject: [PATCH] rust/hpet: remove stale TODO comment
X-Mailer: git-send-email 2.43.0

The irq binding is already implemented in the following line, so the TODO comment is obsolete.

---
 rust/hw/timer/hpet/src/device.rs | 1 -
 1 file changed, 1 deletion(-)