Skip to contentSkip to conversation

ice: Make name member of struct ice_cgu_pin_desc const

PATCH In review Simon Horman 3 participants 3 messages Jan 27 – Jan 28

Subsystems (3)
lore
Share & tools
lore

Simon Horman

author reviewer
#0 lore raw

PATCH 1/1 ice: Make name member of struct ice_cgu_pin_desc const

The name member of struct ice_cgu_pin_desc never modified. Make it const.

Found by inspection.
Compile tested only.

---
 drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/ice/ice_ptp_hw.h +1 -1
index 93901bccf1c4ae1e1782e7a2af4322a6777d0b6c..87aa4cfc5a463f74509ecc4cfbc00e06f26cab5c 100644
@@ -258,7 +258,7 @@ enum ice_si_cgu_out_pins {
 };
 
 struct ice_cgu_pin_desc {
-	char *name;
+	const char *name;
 	u8 index;
 	enum dpll_pin_type type;
 	u32 freq_supp_num;
Reviewed-by on v1 1/1
#1 lore raw

Dear Simon,

Thank you for your patch.

Am 27.01.26 um 17:16 schrieb Simon Horman:

Quoted 16 lines

The name member of struct ice_cgu_pin_desc never modified. Make it const.

Found by inspection.
Compile tested only.

---
  drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/ice/ice_ptp_hw.h +0 -0
index 93901bccf1c4ae1e1782e7a2af4322a6777d0b6c..87aa4cfc5a463f74509ecc4cfbc00e06f26cab5c 100644

drivers/net/ethernet/intel/ice/ice_ptp_hw.h enum ice_si_cgu_out_pins { · line 264

Quoted 8 lines
drivers/net/ethernet/intel/ice/ice_ptp_hw.h +1 -1
@@ -258,7 +258,7 @@ enum ice_si_cgu_out_pins {
  };
 
  struct ice_cgu_pin_desc {
-	char *name;
+	const char *name;
  	u8 index;
  	enum dpll_pin_type type;
  	u32 freq_supp_num;

Kind regards,

Paul Menzel

Reviewed-by on v1 1/1
#2 lore raw
In reply to Simon Horman
Quoted 33 lines

-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Simon Horman
Sent: Tuesday, January 27, 2026 5:17 PM
To: [email protected]
Cc: Nguyen, Anthony L <[email protected]>; Kitszel, Przemyslaw <[email protected]>; Richard Cochran <[email protected]>; [email protected]
Subject: [Intel-wired-lan] [PATCH iwl-next] ice: Make name member of struct ice_cgu_pin_desc const

The name member of struct ice_cgu_pin_desc never modified. Make it const.

Found by inspection.
Compile tested only.

---
 drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/ice/ice_ptp_hw.h +0 -0

index 93901bccf1c4ae1e1782e7a2af4322a6777d0b6c..87aa4cfc5a463f74509ecc4cfbc0 0e06f26cab5c 100644

drivers/net/ethernet/intel/ice/ice_ptp_hw.h enum ice_si_cgu_out_pins { }; · line 264

Quoted 8 lines
drivers/net/ethernet/intel/ice/ice_ptp_hw.h +1 -1
@@ -258,7 +258,7 @@ enum ice_si_cgu_out_pins {  };
 
 struct ice_cgu_pin_desc {
-	char *name;
+	const char *name;
 	u8 index;
 	enum dpll_pin_type type;
 	u32 freq_supp_num;