ice: Make name member of struct ice_cgu_pin_desc const
Subsystems (3)
Simon Horman
reviewerPATCH 1/1 ice: Make name member of struct ice_cgu_pin_desc const
The name member of struct ice_cgu_pin_desc never modified. Make it const.
Found by inspection.
Compile tested only.
--- drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/ice/ice_ptp_hw.h +1 -1
@@ -258,7 +258,7 @@ enum ice_si_cgu_out_pins { };struct ice_cgu_pin_desc { -char *name; +const char *name;u8 index;enum dpll_pin_type type;u32 freq_supp_num;
Dear Simon,
Thank you for your patch.
Am 27.01.26 um 17:16 schrieb Simon Horman:
Quoted 16 lines
The name member of struct
ice_cgu_pin_descnever modified. Make it const.Found by inspection.
Compile tested only.Signed-off-by Simon Horman <[email protected]>--- drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/ethernet/intel/ice/ice_ptp_hw.h +0
-0
drivers/net/ethernet/intel/ice/ice_ptp_hw.h enum ice_si_cgu_out_pins { · line 264
Quoted 8 lines
drivers/net/ethernet/intel/ice/ice_ptp_hw.h +1
-1@@ -258,7 +258,7 @@ enum ice_si_cgu_out_pins { };struct ice_cgu_pin_desc { -char *name; +const char *name;u8 index;enum dpll_pin_type type;u32 freq_supp_num;
Kind regards,
Paul Menzel
Quoted 33 lines
-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Simon Horman
Sent: Tuesday, January 27, 2026 5:17 PM
To: [email protected]
Cc: Nguyen, Anthony L <[email protected]>; Kitszel, Przemyslaw <[email protected]>; Richard Cochran <[email protected]>; [email protected]
Subject: [Intel-wired-lan] [PATCH iwl-next] ice: Make name member of structice_cgu_pin_descconstThe name member of struct
ice_cgu_pin_descnever modified. Make it const.Found by inspection.
Compile tested only.Signed-off-by Simon Horman <[email protected]>--- drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/ethernet/intel/ice/ice_ptp_hw.h +0
-0index
93901bccf1c4ae1e1782e7a2af4322a6777d0b6c..87aa4cfc5a463f74509ecc4cfbc00e06f26cab5c100644
drivers/net/ethernet/intel/ice/ice_ptp_hw.h enum ice_si_cgu_out_pins { }; · line 264
Quoted 8 lines
drivers/net/ethernet/intel/ice/ice_ptp_hw.h +1
-1@@ -258,7 +258,7 @@ enum ice_si_cgu_out_pins { };struct ice_cgu_pin_desc { -char *name; +const char *name;u8 index;enum dpll_pin_type type;u32 freq_supp_num;