Skip to contentSkip to conversation

platform/x86/intel/tpmi/plr: Make the file domain<n>/status writeable

PATCH In review Ricardo Neri 2 participants 2 messages Jan 27 – Jan 29 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86/intel/tpmi/plr: Make the file domain<n>/status writeable

The file sys/kernel/debug/tpmi-<n>/plr/domain<n>/status has store and show callbacks. Make it writeable.

Fixes 811f67c51636d ("platform/x86/intel/tpmi: Add new auxiliary driver for performance limits")

---
I tested this patch in Sierra Forest and Granite Rapids-D systems.

$ echo 0 > /sys/kernel/debug/tpmi-<n>/plr/domain<m>/status
$ cat /sys/kernel/debug/tpmi-<n>/plr/domain<m>/status
cpus none
cpu0 none
cpu1 none
...
---
 drivers/platform/x86/intel/plr_tpmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/intel/plr_tpmi.c +1 -1
index 58132da47745..05727169f49c 100644
@@ -316,7 +316,7 @@ static int intel_plr_probe(struct auxiliary_device *auxdev, const struct auxilia
 		snprintf(name, sizeof(name), "domain%d", i);
 
 		dentry = debugfs_create_dir(name, plr->dbgfs_dir);
-		debugfs_create_file("status", 0444, dentry, &plr->die_info[i],
+		debugfs_create_file("status", 0644, dentry, &plr->die_info[i],
 				    &plr_status_fops);
 	}
 

---
base-commit: 63804fed149a6750ffd28610c5c1c98cce6bd377
change-id: 20260127-plr-debugfs-write-0f47092b3af2

Best regards,

Signature · 1 line
Ricardo Neri <[email protected]>
maintainer
#1 lore raw
Quoted 4 lines · Ricardo Neri

The file sys/kernel/debug/tpmi-<n>/plr/domain<n>/status has store and show callbacks. Make it writeable.

Thank you for your contribution, it has been applied to my local review-ilpo-fixes branch. Note it will show up in the public platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86/intel/tpmi/plr: Make the file domain<n>/status writeable

      commit: 008bec8ffe6e7746588d1e12c5b3865fa478fc91

--
i.