Skip to contentSkip to conversation

block: Replace snprintf with strscpy in check_partition

PATCH Applied Thorsten Blum 2 participants 2 messages Jan 27 – Jan 28 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 block: Replace snprintf with strscpy in check_partition

Replace snprintf("%s", ...) with the faster and more direct strscpy().

---
 block/partitions/core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
block/partitions/core.c +2 -1
index 815ed33caa1b..079057ab535a 100644
@@ -7,6 +7,7 @@
 #include <linux/fs.h>
 #include <linux/major.h>
 #include <linux/slab.h>
+#include <linux/string.h>
 #include <linux/ctype.h>
 #include <linux/vmalloc.h>
 #include <linux/raid/detect.h>
@@ -130,7 +131,7 @@ static struct parsed_partitions *check_partition(struct gendisk *hd)
 	state->pp_buf[0] = '\0';
 
 	state->disk = hd;
-	snprintf(state->name, BDEVNAME_SIZE, "%s", hd->disk_name);
+	strscpy(state->name, hd->disk_name);
 	snprintf(state->pp_buf, PAGE_SIZE, " %s:", state->name);
 	if (isdigit(state->name[strlen(state->name)-1]))
 		sprintf(state->name, "p");
Signature · 2 lines
Thorsten Blum <[email protected]>
GPG: 1D60 735E 8AEF 3BE4 73B6  9D84 7336 78FD 8DFE EAD4
maintainer Applied
#1 lore raw
Quoted 3 lines · Thorsten Blum

Replace snprintf("%s", ...) with the faster and more direct strscpy().

Applied, thanks!

[1/1] block: Replace snprintf with strscpy in check_partition

      commit: f46ebb910989a1db244f95bd1f937907591aa2ee

Best regards,

Signature · 1 line
Jens Axboe