pinctrl: meson: amlogic-a4: Fix device node reference leak in bank helpers
Subsystems (4)
PATCH 1/1 pinctrl: meson: amlogic-a4: Fix device node reference leak in bank helpers
of_parse_phandle_with_fixed_args() increments the reference count of the returned device node, so it must be explicitly released using of_node_put() after use.
Fix the reference leak in aml_bank_pins() and aml_bank_number() by adding the missing of_node_put() calls.
--- drivers/pinctrl/meson/pinctrl-amlogic-a4.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
drivers/pinctrl/meson/pinctrl-amlogic-a4.c +6 -4
@@ -725,8 +725,9 @@ static u32 aml_bank_pins(struct device_node *np)if (of_parse_phandle_with_fixed_args (np,"gpio-ranges" ,3 ,0 , &of_args))return 0 ; -else -return of_args.args[2 ]; + +of_node_put (of_args.np); +return of_args.args[2 ]; }static int aml_bank_number (struct device_node *np)
@@ -736,8 +737,9 @@ static int aml_bank_number(struct device_node *np)if (of_parse_phandle_with_fixed_args (np,"gpio-ranges" ,3 ,0 , &of_args))return -EINVAL ; -else -return of_args.args[1 ] >>8 ; + +of_node_put (of_args.np); +return of_args.args[1 ] >>8 ; }static unsigned int aml_count_pins (struct device_node *np)
---
base-commit: 615aad0f61e0c7a898184a394dc895c610100d4f
change-id: 20260128-amlogic-0d08ef086c8b
Best regards,
Signature · 1 line
Felix Gu <[email protected]>
Quoted 54 lines · Felix Gu
[You don't often get email from [email protected]. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
[ EXTERNAL EMAIL ]
of_parse_phandle_with_fixed_args()increments the reference count of the returned device node, so it must be explicitly released usingof_node_put()after use.Fix the reference leak in
aml_bank_pins()andaml_bank_number()by adding the missingof_node_put()calls.Fixes 6e9be3abb78c ("pinctrl: Add driver support for Amlogic SoCs")Signed-off-by Felix Gu <[email protected]>--- drivers/pinctrl/meson/pinctrl-amlogic-a4.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)drivers/pinctrl/meson/pinctrl-amlogic-a4.c +6
-5@@ -725,8 +725,9 @@ static u32 aml_bank_pins(struct device_node *np)if (of_parse_phandle_with_fixed_args (np,"gpio-ranges" ,3 ,0 , &of_args))return 0 ; -else -return of_args.args[2 ]; + +of_node_put (of_args.np); +return of_args.args[2 ]; }static int aml_bank_number (struct device_node *np)@@ -736,8 +737,9 @@ static int aml_bank_number(struct device_node *np)if (of_parse_phandle_with_fixed_args (np,"gpio-ranges" ,3 ,0 , &of_args))return -EINVAL ; -else -return of_args.args[1 ] >>8 ; + +of_node_put (of_args.np); +return of_args.args[1 ] >>8 ; }static unsigned int aml_count_pins (struct device_node *np) ---base-commit:
615aad0f61e0c7a898184a394dc895c610100d4f
change-id: 20260128-amlogic-0d08ef086c8bBest regards,
--
Felix Gu <[email protected]>
Linus Walleij
maintainerQuoted 9 lines · Felix Gu
of_parse_phandle_with_fixed_args()increments the reference count of the returned device node, so it must be explicitly released usingof_node_put()after use.Fix the reference leak in
aml_bank_pins()andaml_bank_number()by adding the missingof_node_put()calls.Fixes 6e9be3abb78c ("pinctrl: Add driver support for Amlogic SoCs")Signed-off-by Felix Gu <[email protected]>
Patch applied!
Yours,
Linus Walleij