Skip to contentSkip to conversation

spi: dw: Remove duplicate error message

PATCH In review Andy Shevchenko 2 participants 2 messages Jan 28 SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: dw: Remove duplicate error message

devm_platform_ioremap_resource() prints an error message depending on the actual error. The caller doesn't need to repeat that.

---
 drivers/spi/spi-dw-mmio.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/spi/spi-dw-mmio.c +1 -3
index 33239b4778cb..1332fdbf9a21 100644
@@ -104,10 +104,8 @@ static int dw_spi_mscc_init(struct platform_device *pdev,
 		return -ENOMEM;
 
 	dwsmscc->spi_mst = devm_platform_ioremap_resource(pdev, 1);
-	if (IS_ERR(dwsmscc->spi_mst)) {
-		dev_err(&pdev->dev, "SPI_MST region map failed\n");
+	if (IS_ERR(dwsmscc->spi_mst))
 		return PTR_ERR(dwsmscc->spi_mst);
-	}
 
 	dwsmscc->syscon = syscon_regmap_lookup_by_compatible(cpu_syscon);
 	if (IS_ERR(dwsmscc->syscon))
Signature · 1 line
2.50.1
maintainer
#1 lore raw
Quoted 4 lines · Andy Shevchenko

devm_platform_ioremap_resource() prints an error message depending on the actual error. The caller doesn't need to repeat that.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: dw: Remove duplicate error message

      commit: 5c6808d10499f6c8a8d5ee948a22fc93814f6d66

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark