drm/amdgpu: validate user queue size constraints
Subsystems (2)
PATCH 1/1 drm/amdgpu: validate user queue size constraints
Add validation to ensure user queue sizes meet hardware requirements:
- Size must be a power of two for efficient ring buffer wrapping
- Size must be at least AMDGPU_GPU_PAGE_SIZE to prevent undersized allocations
This prevents invalid configurations that could lead to GPU faults or unexpected behavior.
Signed-off-by Jesse Zhang <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c +11 -0
@@ -864,6 +864,17 @@ static int amdgpu_userq_input_args_validate(struct drm_device *dev,drm_file_err (filp,"invalidate userq queue va or size\n" );return -EINVAL ; } + +if (!is_power_of_2 (args->in.queue_size)) { +drm_file_err (filp,"Queue size must be a power of 2\n" ); +return -EINVAL ; + } + +if (args->in.queue_size <AMDGPU_GPU_PAGE_SIZE ) { +drm_file_err (filp,"Queue size smaller than AMDGPU_GPU_PAGE_SIZE\n" ); +return -EINVAL ; + } +if (!args->in.wptr_va || !args->in.rptr_va) {drm_file_err (filp,"invalidate userq queue rptr or wptr\n" );return -EINVAL ;
Signature · 1 line
2.49.0
Quoted 8 lines · Jesse.Zhang
Add validation to ensure user queue sizes meet hardware requirements:
- Size must be a power of two for efficient ring buffer wrapping
- Size must be at leastAMDGPU_GPU_PAGE_SIZEto prevent undersized allocationsThis prevents invalid configurations that could lead to GPU faults or unexpected behavior.
Signed-off-by Jesse Zhang <[email protected]>
Reviewed-by Christian König <[email protected]>
Quoted 26 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 11 +++++++++++ 1 file changed, 11 insertions(+)drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c +11
-0@@ -864,6 +864,17 @@ static int amdgpu_userq_input_args_validate(struct drm_device *dev,drm_file_err (filp,"invalidate userq queue va or size\n" );return -EINVAL ; } + +if (!is_power_of_2 (args->in.queue_size)) { +drm_file_err (filp,"Queue size must be a power of 2\n" ); +return -EINVAL ; + } + +if (args->in.queue_size <AMDGPU_GPU_PAGE_SIZE ) { +drm_file_err (filp,"Queue size smaller than AMDGPU_GPU_PAGE_SIZE\n" ); +return -EINVAL ; + } +if (!args->in.wptr_va || !args->in.rptr_va) {drm_file_err (filp,"invalidate userq queue rptr or wptr\n" );return -EINVAL ;